Bug 2238292 - blivet-gui on Workstation Live doesn't show existing btrfs subvolumes
Summary: blivet-gui on Workstation Live doesn't show existing btrfs subvolumes
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: blivet-gui
Version: 39
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Vojtech Trefny
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: AcceptedBlocker
Depends On:
Blocks: F40BetaBlocker 2238542
TreeView+ depends on / blocked
 
Reported: 2023-09-11 09:20 UTC by Kamil Páral
Modified: 2023-09-21 10:32 UTC (History)
5 users (show)

Fixed In Version: blivet-gui-2.4.2-3.fc40
Clone Of:
: 2238542 (view as bug list)
Environment:
Last Closed: 2023-09-19 14:13:03 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
subvolumes missing in Workstation (52.58 KB, image/png)
2023-09-11 09:21 UTC, Kamil Páral
no flags Details
subvolumes present in KDE (81.19 KB, image/png)
2023-09-11 09:21 UTC, Kamil Páral
no flags Details
subvolumes present in netinst (77.54 KB, image/png)
2023-09-11 09:21 UTC, Kamil Páral
no flags Details
workstation-anaconda.log (6.00 KB, text/plain)
2023-09-11 09:22 UTC, Kamil Páral
no flags Details
workstation-program.log (1.70 KB, text/plain)
2023-09-11 09:22 UTC, Kamil Páral
no flags Details
workstation-storage.log (114.06 KB, text/plain)
2023-09-11 09:22 UTC, Kamil Páral
no flags Details

Description Kamil Páral 2023-09-11 09:20:35 UTC
Description of problem:
When I run blivet-gui on Workstation Live as part of the anaconda webui, I don't see any btrfs subvolumes, under any btrfs volume. In comparison, when I launch blivet-gui from KDE Live or netinst, I see btrfs subvolumes.

This is of course a problem. I can't delete a subvolume to save space. I can't create a new subvolume. If I try to create a new subvolume which name happens to already exist, I get an error message and blivet-gui exits (can be re-launched).

Fortunately, I can use the existing subvolumes in Anaconda webui in the mount point mapping screen. However, any adjustment is just not possible because of blivet-gui not showing them.

Note: Blivet-gui shows a subvolume immediately after you create a new one (either under a new btrfs volume or an existing one). But if you "Reload Storage" or you quit blivet-gui and start it again, it disappears.


Version-Release number of selected component (if applicable):
Fedora-Workstation-Live-x86_64-39-20230910.n.0.iso - doesn't work
Fedora-KDE-Live-x86_64-39-20230910.n.0.iso - works
Fedora-Everything-netinst-x86_64-39-20230910.n.0.iso - works
blivet-data-3.8.1-1.fc39.noarch
python3-blivet-3.8.1-1.fc39.noarch
blivet-gui-runtime-2.4.2-2.fc39.noarch

How reproducible:
always

Steps to Reproduce:
1. create a btrfs volume with just subvolumes, or just have some existing Workstation installation on your disk
2. boot Workstation Live, run blivet-gui from anaconda
3. see that btrfs volumes have no subvolumes listed
4. compare to e.g. netinst, they show up there

Comment 1 Kamil Páral 2023-09-11 09:21:22 UTC
Created attachment 1988119 [details]
subvolumes missing in Workstation

Comment 2 Kamil Páral 2023-09-11 09:21:30 UTC
Created attachment 1988120 [details]
subvolumes present in KDE

Comment 3 Kamil Páral 2023-09-11 09:21:40 UTC
Created attachment 1988121 [details]
subvolumes present in netinst

Comment 4 Kamil Páral 2023-09-11 09:22:35 UTC
Created attachment 1988122 [details]
workstation-anaconda.log

Comment 5 Kamil Páral 2023-09-11 09:22:40 UTC
Created attachment 1988123 [details]
workstation-program.log

Comment 6 Kamil Páral 2023-09-11 09:22:46 UTC
Created attachment 1988124 [details]
workstation-storage.log

Comment 7 Kamil Páral 2023-09-11 09:24:22 UTC
Proposing for a blocker discussion:
https://fedoraproject.org/wiki/Fedora_39_Beta_Release_Criteria#Custom_partitioning
"Correctly interpret, and modify as described below, any disk with a valid ms-dos or gpt disk label and partition table containing ext4 partitions, LVM and/or btrfs volumes, and/or software RAID arrays at RAID levels 0, 1 and 5 containing ext4 partitions"

Comment 8 Vojtech Trefny 2023-09-11 11:15:18 UTC
This is somewhat intentional. We cannot get list of btrfs subvolumes without mounting the device and in general we don't want to "randomly" mount devices in blivet-gui. This isn't a problem when running in Anaconda, because Anaconda mounts everything anyway, but with the WebUI blivet-gui is just started as a standalone application and nobody tells it that it's ok to mount devices in this special situation. To fix this, we'd probably need a new command line option for blivet-gui adjusting its behaviour when being started from Anaconda.

Comment 9 Kamil Páral 2023-09-11 11:35:06 UTC
So if I understand you correctly, it is intentional when launching blivet-gui standalone, but it is *not* intentional when launching blivet-gui from anaconda - it's just a use case that nobody thought of, correct? Because I either need an auto-mount or some button to mount/discover it manually to be able to manage those subvolumes.

Comment 10 Geoffrey Marr 2023-09-11 18:09:07 UTC
Discussed during the 2023-09-11 blocker review meeting: [0]

The decision to classify this bug as an "AcceptedBlocker (Beta)" was made as it violates the following criterion:

"The installer must be able to: Correctly interpret, and modify as described below, any disk ... containing ... btrfs volumes".

[0] https://meetbot.fedoraproject.org/fedora-blocker-review/2023-09-11/f39-blocker-review.2023-09-11-16.00.txt

Comment 11 Vojtech Trefny 2023-09-12 12:07:56 UTC
upstream PRs:
  - Anaconda: https://github.com/rhinstaller/anaconda/pull/5164
  - blivet-gui: https://github.com/storaged-project/blivet-gui/pull/412

Comment 12 Fedora Update System 2023-09-12 14:38:52 UTC
FEDORA-2023-d97eb6a6eb has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-d97eb6a6eb

Comment 13 Fedora Update System 2023-09-12 21:39:00 UTC
FEDORA-2023-d97eb6a6eb has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-d97eb6a6eb`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-d97eb6a6eb

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Adam Williamson 2023-09-12 21:51:55 UTC
As webUI has been deferred to F40 and this bug is specific to the webUI flow (in the GTK UI, blivet-gui is launched in its installer mode where this is not an issue), it is clearly no longer a blocker.

Comment 15 Adam Williamson 2023-09-12 22:03:01 UTC
actually, the logical thing to do is to defer the blocker status to F40, I guess. The blivet-gui update already went stable for F40; it would be good if someone can test and confirm the fix.

Comment 16 Kamil Páral 2023-09-21 10:32:26 UTC
I tested with Fedora-Workstation-Live-x86_64-Rawhide-20230920.n.0.iso and btrfs subvolumes now correctly show up in blivet-gui launched from anaconda webUI. Thanks.


Note You need to log in before you can comment on or make changes to this bug.