Spec URL: https://rpms.remirepo.net/temp/php-pecl-redis6.spec SRPM URL: https://rpms.remirepo.net/temp/php-pecl-redis6-6.0.0-1.fedora.src.rpm Description: The phpredis extension provides an API for communicating with the Redis key-value store. This Redis client implements most of the latest Redis API. As method only only works when also implemented on the server side, some doesn't work with an old redis server version. Fedora Account System Username: remi -- Plan is to add new version in F38+ (user choice) and to remove old version in F40+ as it was done with v3, v4, v5...
Copr build: https://copr.fedorainfracloud.org/coprs/build/6394496 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2238342-php-pecl-redis6/fedora-rawhide-x86_64/06394496-php-pecl-redis6/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://rpms.remirepo.net/temp/php-pecl-redis6.spec SRPM URL: https://rpms.remirepo.net/temp/php-pecl-redis6-6.0.1-1.fedora.src.rpm
Spec URL: https://rpms.remirepo.net/temp/php-pecl-redis6.spec SRPM URL: https://rpms.remirepo.net/temp/php-pecl-redis6-6.0.2-1.fedora.src.rpm
Created attachment 1995173 [details] The .spec file difference from Copr build 6394496 to 6557871
Copr build: https://copr.fedorainfracloud.org/coprs/build/6557871 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2238342-php-pecl-redis6/fedora-rawhide-x86_64/06557871-php-pecl-redis6/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Minor update https://git.remirepo.net/cgit/rpms/php/pecl/php-pecl-redis6.git/commit/?h=fedora&id=ef541033e21af1431416a784048cee9cd225da64 - use valkey on Rawhide - upstream patch for PHP 8.4 Spec URL: https://rpms.remirepo.net/temp/php-pecl-redis6.spec SRPM URL: https://rpms.remirepo.net/temp/php-pecl-redis6-6.0.2-2.fedora.src.rpm
Spec cleanup Spec URL: https://rpms.remirepo.net/temp/php-pecl-redis6.spec SRPM URL: https://rpms.remirepo.net/temp/php-pecl-redis6-6.0.2-3.fedora.src.rpm
Created attachment 2047042 [details] The .spec file difference from Copr build 6557871 to 8023395
Copr build: https://copr.fedorainfracloud.org/coprs/build/8023395 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2238342-php-pecl-redis6/fedora-rawhide-x86_64/08023395-php-pecl-redis6/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Output of Fedora-Review. Give me a moment to process this. ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "PHP License v3.01", "*No copyright* PHP License v3.01", "BSD 3-Clause License". 47 files have unknown license. Detailed output of licensecheck in /home/abauer/2238342-php- pecl-redis6/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/doc/pecl/redis(php-pecl-redis5) [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 159435 bytes in 5 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. PHP: [!]: Run phpci static analyze on all php files. Note: phpcompatinfo not found. Install php-bartlett-PHP-CompatInfo package to get a more comprehensive php review. See: url: undefined Rpmlint ------- Checking: php-pecl-redis6-6.0.2-3.fc42.x86_64.rpm php-pecl-redis6-debuginfo-6.0.2-3.fc42.x86_64.rpm php-pecl-redis6-debugsource-6.0.2-3.fc42.x86_64.rpm php-pecl-redis6-6.0.2-3.fc42.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpkdpkodg_')] checks: 32, packages: 4 php-pecl-redis6.src: E: spelling-error ('phpredis', '%description -l en_US phpredis -> predispose') php-pecl-redis6.x86_64: E: spelling-error ('phpredis', '%description -l en_US phpredis -> predispose') 4 packages and 0 specfiles checked; 2 errors, 0 warnings, 18 filtered, 2 badness; has taken 1.3 s Rpmlint (debuginfo) ------------------- Checking: php-pecl-redis6-debuginfo-6.0.2-3.fc42.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp3rqu_n3i')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.2 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so sapi_module (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_known_strings (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_string_init_interned (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so std_object_handlers (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so spl_ce_RuntimeException (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_empty_string (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so executor_globals (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_zval_type_name (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so add_next_index_bool (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so convert_to_long (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_hash_str_del (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so _php_stream_cast (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so add_assoc_zval_ex (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_sort (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so _emalloc_128 (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so php_session_register_module (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_parse_parameters (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_is_true (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_llist_remove_tail (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_parse_method_parameters (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so _efree_56 (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_get_parameters_array_ex (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so _emalloc_256 (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_strpprintf (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so php_json_decode_ex (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so _emalloc_56 (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_llist_get_next_ex (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_object_std_init (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so ap_php_snprintf (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_hash_index_update (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so smart_str_erealloc (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_wrong_param_count (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so _php_stream_write (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so _estrdup (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so _safe_emalloc (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so _php_stream_xport_create (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so PHP_MD5Final (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so _zend_new_array (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_llist_destroy (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_hash_index_del (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so php_var_unserialize_init (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so php_var_serialize_init (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so convert_to_double (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so php_url_parse_ex (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so php_info_print_table_row (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so _php_stream_get_line (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so php_var_serialize_destroy (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so add_assoc_double_ex (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so php_session_valid_key (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_parse_arg_str_slow (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_hash_get_current_key_type_ex (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so php_var_unserialize (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_wrong_parameters_count_error (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so _emalloc_32 (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so add_next_index_stringl (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so _zend_hash_init (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_llist_prepend_element (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_llist_get_last_ex (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so add_assoc_string_ex (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so _smart_string_alloc (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so php_mt_rand_range (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so php_random_bytes (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_spprintf (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so _emalloc_112 (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so _erealloc (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_hash_index_find (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_string_equal_val (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_llist_count (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_llist_get_first_ex (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_ini_long (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so add_assoc_bool_ex (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zval_get_double_func (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zval_get_string_func (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so rc_dtor_func (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so _php_stream_getc (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so php_error_docref (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_hash_get_current_key_ex (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_register_ini_entries_ex (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so php_info_print_table_end (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so display_ini_entries (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so _call_user_function_impl (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_hash_destroy (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so _emalloc_64 (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_parse_arg_bool_slow (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_register_list_destructors_ex (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_call_function (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_throw_exception_ex (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so add_next_index_null (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_hash_str_update (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so _emalloc_16 (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_hash_get_current_data_ex (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so __zend_malloc (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_register_internal_class_ex (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so add_assoc_null_ex (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so igbinary_serialize (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so php_info_print_table_header (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so php_var_serialize (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_hash_str_find (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so php_stream_context_alloc (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so object_init_ex (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_add_attribute (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so php_var_unserialize_destroy (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_throw_exception (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_is_callable_ex (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so _emalloc_96 (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_parse_arg_long_slow (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so _ecalloc (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_array_to_list (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_hash_next_index_insert (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_object_std_dtor (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_wrong_parameters_none_error (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so _is_numeric_string_ex (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_parse_arg_double_slow (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so _php_stream_set_option (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_wrong_parameter_error (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so _convert_to_string (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so _efree (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so _php_stream_seek (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so _emalloc_40 (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_llist_init (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so _zend_new_array_0 (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_register_persistent_resource (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_hash_clean (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_binary_strcasecmp (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so __zend_calloc (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zval_ptr_dtor (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so PHP_MD5InitArgs (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so _php_stream_free (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so _php_stream_eof (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_value_error (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so php_session_create_id (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_declare_class_constant_ex (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so _php_stream_read (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so add_next_index_string (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so php_msgpack_serialize (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so PHP_MD5Update (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_hash_apply (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so _estrndup (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so php_url_free (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so _emalloc (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_hash_internal_pointer_reset_ex (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so php_stream_context_set_option (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_ini_string_ex (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_hash_move_forward_ex (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so add_assoc_long_ex (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so add_assoc_stringl_ex (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so php_json_encode (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so add_next_index_long (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so php_info_print_table_start (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_hash_update (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so php_msgpack_unserialize (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so add_next_index_str (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so _emalloc_24 (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_llist_add_element (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so php_hash_fetch_ops (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so add_next_index_double (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_hash_find (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zval_get_long_func (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so object_properties_init (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_argument_type_error (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so zend_hash_del (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: W: undefined-non-weak-symbol /usr/lib64/php/modules/redis.so igbinary_unserialize (/usr/lib64/php/modules/redis.so) php-pecl-redis6.x86_64: E: spelling-error ('phpredis', '%description -l en_US phpredis -> predispose') 3 packages and 0 specfiles checked; 1 errors, 162 warnings, 15 filtered, 1 badness; has taken 0.6 s Unversioned so-files -------------------- php-pecl-redis6: /usr/lib64/php/modules/redis.so Source checksums ---------------- https://pecl.php.net/get/redis-6.0.2.tgz : CHECKSUM(SHA256) this package : 01aeccb0e14f897fe56f0509be6e6991ff0ad459f9d34e95e4556d02699b9a03 CHECKSUM(SHA256) upstream package : 01aeccb0e14f897fe56f0509be6e6991ff0ad459f9d34e95e4556d02699b9a03 Requires -------- php-pecl-redis6 (rpmlib, GLIBC filtered): config(php-pecl-redis6) libc.so.6()(64bit) liblz4.so.1()(64bit) liblzf.so.1()(64bit) libzstd.so.1()(64bit) php(api) php(zend-abi) php-igbinary(x86-64) php-json(x86-64) php-msgpack(x86-64) rtld(GNU_HASH) php-pecl-redis6-debuginfo (rpmlib, GLIBC filtered): php-pecl-redis6-debugsource (rpmlib, GLIBC filtered): Provides -------- php-pecl-redis6: config(php-pecl-redis6) php-pecl(redis) php-pecl(redis)(x86-64) php-pecl-redis php-pecl-redis(x86-64) php-pecl-redis4 php-pecl-redis4(x86-64) php-pecl-redis5 php-pecl-redis5(x86-64) php-pecl-redis6 php-pecl-redis6(x86-64) php-redis php-redis(x86-64) php-pecl-redis6-debuginfo: debuginfo(build-id) php-pecl-redis6-debuginfo php-pecl-redis6-debuginfo(x86-64) php-pecl-redis6-debugsource: php-pecl-redis6-debugsource php-pecl-redis6-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2238342 Buildroot used: fedora-rawhide-x86_64 Active plugins: PHP, C/C++, Generic, Shell-api Disabled plugins: fonts, Haskell, Java, R, Ocaml, SugarActivity, Perl, Python Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
The word "only" is duplicated in the description. >As method only only works should be >As method only works The only other thing I noticed were all the undefined-non-weak-symbol warnings. It is unclear to me where these are coming from or what to do about them. For comparison, I ran rmplint on php-pecl-redis5, which does not show these warnings, so this is something new with redis6. I also do not see any related issues on upstream's github page.
Actually I take that back. After asking in devel list, I've got to install the package first, then run rpmlint -i on the installed package. When I do that, I now see the undefined-non-weak-symbol warnings for the older php-pecl-redis5 package... so this problem has indeed been around a while. Do you recall if this was mentioned during the php-pecl-redis5 review? If so, what was the resolution?
I've submitted an issue upstream and will wait to see how they respond: https://github.com/phpredis/phpredis/issues/2553
Remi - Sorry for all the noise on this one. After receiving a nudge from the upstream developer, I am confident the undefined-non-weak-symbol warnings are by design (this is a php module calling external symbols from php itself, duh). Package APPROVED.
> Do you recall if this was mentioned during the php-pecl-redis5 review? If so, what was the resolution? 1st time I see these BTW redis.so is NIT a library but a module loaded by PHP All these symbols are provided by PHP, so are present when loaded from PHP. > Package APPROVED. Thanks for the review
The Pagure repository was created at https://src.fedoraproject.org/rpms/php-pecl-redis6
SCM requests https://pagure.io/releng/fedora-scm-requests/issue/67877 rawhide https://pagure.io/releng/fedora-scm-requests/issue/67878 f41 https://pagure.io/releng/fedora-scm-requests/issue/67879 f40 https://pagure.io/releng/fedora-scm-requests/issue/67880 epel9 EPEL-10 will come later
Notice - php-pecl-redis5 will be removed from rawhide - php-pecl-redis6 6.0.2 will be built today, and updated to the upcoming 6.1.0 shortly (6.1.0RC2 is released today)
FEDORA-2024-7dcca06de5 (php-pecl-redis6-6.0.2-3.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-7dcca06de5
FEDORA-EPEL-2024-891796e76e (php-pecl-redis6-6.0.2-3.el9) has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-891796e76e
FEDORA-2024-7dcca06de5 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-7dcca06de5 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-7dcca06de5 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-88ff8b5acd has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-88ff8b5acd \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-88ff8b5acd See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2024-891796e76e has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-891796e76e See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-7dcca06de5 (php-pecl-redis6-6.0.2-3.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-88ff8b5acd (php-pecl-redis6-6.0.2-3.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-EPEL-2024-891796e76e (php-pecl-redis6-6.0.2-3.el9) has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report.