Spec URL: https://download.copr.fedorainfracloud.org/results/atim/for-review/fedora-rawhide-x86_64/06395285-speedtest/speedtest.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/atim/for-review/fedora-rawhide-x86_64/06395285-speedtest/speedtest-1.0.0-1.fc40.src.rpm Description: A graphical librespeed client written using gtk4 + libadwaita Fedora Account System Username: atim
https://download.copr.fedorainfracloud.org/results/atim/for-review/fedora-rawhide-x86_64/06395285-speedtest/fedora-review/review.txt
Copr build: https://copr.fedorainfracloud.org/coprs/build/6395298 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2238435-speedtest/fedora-rawhide-x86_64/06395298-speedtest/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
> Version: 1.0.0 v1.0.1 is now available, and includes the two patches present in the srpm. > License: GPLv3 Old Callaway-style license tag. The SPDX equivalent of this is "GPL-3.0-only".
Indeed, thanks for reminding to update license tags. I still using old-style for all my package. New Spec and SRPM: Spec URL: https://copr-dist-git.fedorainfracloud.org/cgit/atim/for-review/speedtest.git/plain/speedtest.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/5453/106275453/speedtest-1.0.1-1.fc40.src.rpm
- Bump to 1.1.0 - Enable localization: %global rdnsappid xyz.ketok.Speedtest Name: speedtest Version: 1.1.0 Release: %autorelease Summary: A graphical librespeed client written using gtk4 + libadwaita License: GPL-3.0-or-later URL: https://github.com/Ketok4321/speedtest Source0: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz BuildArch: noarch BuildRequires: desktop-file-utils BuildRequires: intltool BuildRequires: libappstream-glib BuildRequires: meson >= 0.62.0 BuildRequires: python3-devel BuildRequires: blueprint-compiler >= 0.10.0 BuildRequires: python3dist(setuptools) BuildRequires: python3dist(aiohttp) BuildRequires: pkgconfig(gio-2.0) BuildRequires: pkgconfig(glib-2.0) BuildRequires: pkgconfig(gobject-introspection-1.0) BuildRequires: pkgconfig(gtk4) BuildRequires: pkgconfig(libadwaita-1) Requires: hicolor-icon-theme Requires: libadwaita Requires: python3-gobject %description %{summary} %prep %autosetup -p1 %build %meson %meson_build %install %meson_install %find_lang %{name} %check appstream-util validate-relax --nonet %{buildroot}%{_metainfodir}/*.xml desktop-file-validate %{buildroot}%{_datadir}/applications/*.desktop %files -f %{name}.lang %license LICENSE %{_bindir}/%{name} %{_datadir}/%{name}/ %{_datadir}/applications/*.desktop %{_datadir}/glib-2.0/schemas/*.gschema.xml %{_datadir}/icons/hicolor/*/*/*.svg %{_metainfodir}/*.xml %changelog %autochangelog Actual review: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License v3.0 or later". 31 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/speedtest/review- speedtest/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: speedtest-1.1.0-1.fc40.noarch.rpm speedtest-1.1.0-1.fc40.src.rpm ============================================================================================================================================== rpmlint session starts ============================================================================================================================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpmrdy8np7')] checks: 31, packages: 2 speedtest.noarch: W: no-manual-page-for-binary speedtest speedtest.noarch: W: no-documentation speedtest.noarch: E: explicit-lib-dependency libadwaita =============================================================================================================== 2 packages and 0 specfiles checked; 1 errors, 2 warnings, 2 badness; has taken 0.2 s =============================================================================================================== LGTM, package approved assuming you update to the latest version.
The Pagure repository was created at https://src.fedoraproject.org/rpms/speedtest
@artem: there is an issue I didn't detect, the permissions are wrong: speedtest.noarch: E: non-standard-executable-perm /usr/bin/speedtest 555 because the meson.build states: install_mode: 'r-xr-xr-x' You need to fix this permission to 0755.
Thanks a lot! Please ask me anytime if you need to review your packages. Fix submitted upstream: https://github.com/Ketok4321/speedtest/pull/19
FEDORA-2023-d90caa0ee6 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-d90caa0ee6
FEDORA-2023-d90caa0ee6 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-d90caa0ee6 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-d90caa0ee6 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-d90caa0ee6 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.