Boot installer on a VM with two disks,create a btrfs volume on that two disks, set mount point,create other partitions and set mount points accordingly,finish the installation,boot into the newly installed system,find the second part is not shown as mounted,when you run lsblk/mount,users may forget that the second disk is also in-use and try to modify the second disk,and then result in data loss. Reproducible: Always
Created attachment 1988966 [details] screenshot
Created attachment 1988967 [details] anaconda.log
Created attachment 1988968 [details] storage.log
Moving to util-linux (provider of lsblk), this isn't related to the installation process, it's just how multi-device btrfs volumes and their mountpoints are displayed by lsblk (and other system tools).
Created attachment 1989311 [details] screenshot
Created attachment 1989312 [details] screencast
As you can see from the screenshot,the vdb1 partition which is part of / may be deleted by mistake,and as an easy-to tell result,the system is died.
Proposing this as a blocker,as it's kind of violates https://fedoraproject.org/wiki/Fedora_39_Final_Release_Criteria#Disk_layouts, What's more worse,after a *long* time,maybe several months later,users may delete / or /home partition by mistake,as both lsblk and mount Not showing that partitions are in use.
The question is where lsblk can get the information that the partition is used. Please provide "cat /proc/self/mountinfo" and "findmnt" output. (you can use copy & paste to bugzilla, screenshots are unnecessary ;-))
Er,sure:) lnie@localhost-live:~$ sudo cat /proc/self/mountinfo 65 1 252:2 / / rw,relatime shared:1 - ext4 /dev/vda2 rw,seclabel 34 65 0:5 / /dev rw,nosuid shared:2 - devtmpfs devtmpfs rw,seclabel,size=4096k,nr_inodes=994746,mode=755,inode64 35 34 0:24 / /dev/shm rw,nosuid,nodev shared:3 - tmpfs tmpfs rw,seclabel,inode64 36 34 0:25 / /dev/pts rw,nosuid,noexec,relatime shared:4 - devpts devpts rw,seclabel,gid=5,mode=620,ptmxmode=000 37 65 0:23 / /sys rw,nosuid,nodev,noexec,relatime shared:5 - sysfs sysfs rw,seclabel 38 37 0:6 / /sys/kernel/security rw,nosuid,nodev,noexec,relatime shared:6 - securityfs securityfs rw 39 37 0:27 / /sys/fs/cgroup rw,nosuid,nodev,noexec,relatime shared:7 - cgroup2 cgroup2 rw,seclabel,nsdelegate,memory_recursiveprot 40 37 0:28 / /sys/fs/pstore rw,nosuid,nodev,noexec,relatime shared:8 - pstore pstore rw,seclabel 41 37 0:29 / /sys/firmware/efi/efivars rw,nosuid,nodev,noexec,relatime shared:9 - efivarfs efivarfs rw 42 37 0:30 / /sys/fs/bpf rw,nosuid,nodev,noexec,relatime shared:10 - bpf bpf rw,mode=700 43 37 0:31 / /sys/kernel/config rw,nosuid,nodev,noexec,relatime shared:11 - configfs configfs rw 44 65 0:22 / /proc rw,nosuid,nodev,noexec,relatime shared:13 - proc proc rw 45 65 0:26 / /run rw,nosuid,nodev shared:14 - tmpfs tmpfs rw,seclabel,size=1599980k,nr_inodes=819200,mode=755,inode64 24 37 0:20 / /sys/fs/selinux rw,nosuid,noexec,relatime shared:12 - selinuxfs selinuxfs rw 23 44 0:32 / /proc/sys/fs/binfmt_misc rw,relatime shared:15 - autofs systemd-1 rw,fd=34,pgrp=1,timeout=0,minproto=5,maxproto=5,direct,pipe_ino=16944 26 34 0:33 / /dev/hugepages rw,nosuid,nodev,relatime shared:16 - hugetlbfs hugetlbfs rw,seclabel,pagesize=2M 27 34 0:19 / /dev/mqueue rw,nosuid,nodev,noexec,relatime shared:17 - mqueue mqueue rw,seclabel 30 37 0:7 / /sys/kernel/debug rw,nosuid,nodev,noexec,relatime shared:18 - debugfs debugfs rw,seclabel 31 37 0:12 / /sys/kernel/tracing rw,nosuid,nodev,noexec,relatime shared:19 - tracefs tracefs rw,seclabel 32 37 0:34 / /sys/fs/fuse/connections rw,nosuid,nodev,noexec,relatime shared:20 - fusectl fusectl rw 46 65 0:35 / /tmp rw,nosuid,nodev shared:44 - tmpfs tmpfs rw,seclabel,size=3999952k,nr_inodes=1048576,inode64 48 65 0:36 / /home rw,relatime shared:46 - btrfs /dev/vda1 rw,seclabel,discard=async,space_cache=v2,subvolid=5,subvol=/ 50 65 252:18 / /boot rw,relatime shared:48 - ext4 /dev/vdb2 rw,seclabel 52 50 252:19 / /boot/efi rw,relatime shared:50 - vfat /dev/vdb3 rw,fmask=0077,dmask=0077,codepage=437,iocharset=ascii,shortname=winnt,errors=remount-ro 54 23 0:38 / /proc/sys/fs/binfmt_misc rw,nosuid,nodev,noexec,relatime shared:52 - binfmt_misc binfmt_misc rw 60 65 0:41 / /var/lib/nfs/rpc_pipefs rw,relatime shared:123 - rpc_pipefs sunrpc rw 25 45 0:63 / /run/user/1000 rw,nosuid,nodev,relatime shared:648 - tmpfs tmpfs rw,seclabel,size=799988k,nr_inodes=199997,mode=700,uid=1000,gid=1000,inode64 773 25 0:73 / /run/user/1000/gvfs rw,nosuid,nodev,relatime shared:687 - fuse.gvfsd-fuse gvfsd-fuse rw,user_id=1000,group_id=1000 707 45 11:0 / /run/media/lnie/Fedora-WS-Live-39-20230916-n-0 ro,nosuid,nodev,relatime shared:659 - iso9660 /dev/sr0 ro,nojoliet,check=s,map=n,blocksize=2048,uid=1000,gid=1000,dmode=500,fmode=400,iocharset=utf8 394 25 0:67 / /run/user/1000/doc rw,nosuid,nodev,relatime shared:757 - fuse.portal portal rw,user_id=1000,group_id=1000 lnie@localhost-live:~$ sudo findmnt TARGET SOURCE FSTYPE OPTIONS / /dev/vda2 ext4 rw,relatime,seclabel ├─/dev devtmpfs devtmpfs rw,nosuid,seclabel,size=4096k,nr_inodes=994746,mode=755,inode64 │ ├─/dev/hugepages hugetlbfs hugetlbfs rw,nosuid,nodev,relatime,seclabel,pagesize=2M │ ├─/dev/mqueue mqueue mqueue rw,nosuid,nodev,noexec,relatime,seclabel │ ├─/dev/shm tmpfs tmpfs rw,nosuid,nodev,seclabel,inode64 │ └─/dev/pts devpts devpts rw,nosuid,noexec,relatime,seclabel,gid=5,mode=620,ptmxmode=000 ├─/sys sysfs sysfs rw,nosuid,nodev,noexec,relatime,seclabel │ ├─/sys/fs/selinux selinuxfs selinuxfs rw,nosuid,noexec,relatime │ ├─/sys/kernel/debug debugfs debugfs rw,nosuid,nodev,noexec,relatime,seclabel │ ├─/sys/kernel/tracing tracefs tracefs rw,nosuid,nodev,noexec,relatime,seclabel │ ├─/sys/fs/fuse/connections fusectl fusectl rw,nosuid,nodev,noexec,relatime │ ├─/sys/kernel/security securityfs securityfs rw,nosuid,nodev,noexec,relatime │ ├─/sys/fs/cgroup cgroup2 cgroup2 rw,nosuid,nodev,noexec,relatime,seclabel,nsdelegate,memory_recursiveprot │ ├─/sys/fs/pstore pstore pstore rw,nosuid,nodev,noexec,relatime,seclabel │ ├─/sys/firmware/efi/efivars efivarfs efivarfs rw,nosuid,nodev,noexec,relatime │ ├─/sys/fs/bpf bpf bpf rw,nosuid,nodev,noexec,relatime,mode=700 │ └─/sys/kernel/config configfs configfs rw,nosuid,nodev,noexec,relatime ├─/proc proc proc rw,nosuid,nodev,noexec,relatime │ └─/proc/sys/fs/binfmt_misc systemd-1 autofs rw,relatime,fd=34,pgrp=1,timeout=0,minproto=5,maxproto=5,direct,pipe_ino=16944 │ └─/proc/sys/fs/binfmt_misc binfmt_misc binfmt_misc rw,nosuid,nodev,noexec,relatime ├─/run tmpfs tmpfs rw,nosuid,nodev,seclabel,size=1599980k,nr_inodes=819200,mode=755,inode64 │ ├─/run/user/1000 tmpfs tmpfs rw,nosuid,nodev,relatime,seclabel,size=799988k,nr_inodes=199997,mode=700,uid=10 │ │ ├─/run/user/1000/doc portal fuse.portal rw,nosuid,nodev,relatime,user_id=1000,group_id=1000 │ │ └─/run/user/1000/gvfs gvfsd-fuse fuse.gvfsd-fuse rw,nosuid,nodev,relatime,user_id=1000,group_id=1000 │ └─/run/media/lnie/Fedora-WS-Live-39-20230916-n-0 /dev/sr0 iso9660 ro,nosuid,nodev,relatime,nojoliet,check=s,map=n,blocksize=2048,uid=1000,gid=100 ├─/tmp tmpfs tmpfs rw,nosuid,nodev,seclabel,size=3999952k,nr_inodes=1048576,inode64 ├─/home /dev/vda1 btrfs rw,relatime,seclabel,discard=async,space_cache=v2,subvolid=5,subvol=/ ├─/boot /dev/vdb2 ext4 rw,relatime,seclabel │ └─/boot/efi /dev/vdb3 vfat rw,relatime,fmask=0077,dmask=0077,codepage=437,iocharset=ascii,shortname=winnt, └─/var/lib/nfs/rpc_pipefs sunrpc rpc_pipefs rw,relatime
Created attachment 1989697 [details] gnome-disks shows the btrfs volume part on send disk as not-mounted
Created attachment 1989866 [details] screencast
Hi developer, /proc/self/mountinfo is not owned by any package,while findmnt is owned by util-linux-core, please reassign to the package that util-linux-core get information from, if you think it's not util-linux'problem,thanks.
Also CCing mcatanzaro for a Workstation WG take - ideally it would be good to ask the gnome-disk-utility devs, but AFAICS it's fairly lightly maintained by folks who aren't very Fedora-adjacent, so I don't want to just drag them into this.
OK slow down. This started out assigned to anaconda, then moved to util-linux. How is it that we're talking about gnome-disk-utility now? The upstream issue tracker for gnome-disk-utility is https://gitlab.gnome.org/GNOME/gnome-disk-utility/-/issues so if something is wrong, we'd need an issue report there for starters.
Ah, that part was covered more clearly in the blocker ticket, sorry. Copying here from https://pagure.io/fedora-qa/blocker-review/issue/1335#comment-875104 : "Gnome-disks warn users and not allow them to delete the btrfs volume part on the first disk,while allow them to delete the btrfs volume part on the second disk,I think the basic function of gnome-disk include:1)show disks usage,mounted/not-mounted2)allow users to delete an unused device while reject it if it's not used." the latest screencast and screenshot attachment to this bug are about the gnome-disks angle.
Discussed during the 2023-09-25 blocker review meeting: [0] The decision to delay the classification of this as a blocker bug was made as we would like to ask the GNOME Disks developers (and possibly util-linux too) for their opinion on this bug and how practical it is to try and address it. [0] https://meetbot.fedoraproject.org/fedora-blocker-review/2023-09-25/f39-blocker-review.2023-09-25-16.02.txt
Thanks,Adam. @Michael Catanzaro,here is the upstream issue I reported:https://gitlab.gnome.org/GNOME/gnome-disk-utility/-/issues/311
Discussed during the 2023-10-02 blocker review meeting: [1] The decision to classify this bug as a RejectedBlocker (Final) was made: "We find this to be a more advanced use case where the user would have a reason for having two btrfs drives, and would probably remember why they did it, thus making this bug less of an issue in this context. We also acknowledge that a lot would probably have to change in the stack to fix it." [1] https://meetbot-raw.fedoraproject.org/fedora-blocker-review/2023-10-02/f39-blocker-review.2023-10-02-16.01.log.txt