Fedora Account System
Red Hat Associate
Red Hat Customer
spec: https://suve.fedorapeople.org/review/reversal-icon-theme-0%5E20230513.bdae2ea-1/reversal-icon-theme.spec srpm: https://suve.fedorapeople.org/review/reversal-icon-theme-0%5E20230513.bdae2ea-1/reversal-icon-theme-0%5E20230513.bdae2ea-1.fc38.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=106271699 Description: Reversal is a colorful icon theme inspired by Mac OS X aesthetic. FAS username: suve
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience.
No new version released since; package is up to date.
Updated to latest git snapshot. spec: https://suve.fedorapeople.org/review/reversal-icon-theme-0%5E20250826.1bdf4c6-1/reversal-icon-theme.spec srpm: https://suve.fedorapeople.org/review/reversal-icon-theme-0%5E20250826.1bdf4c6-1/reversal-icon-theme-0%5E20250826.1bdf4c6-1.fc43.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=136602190
Copr build: https://copr.fedorainfracloud.org/coprs/build/9509761 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2239258-reversal-icon-theme/fedora-rawhide-x86_64/09509761-reversal-icon-theme/fedora-review/review.txt Found issues: - License file text-x-copying-symbolic.svg is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Updated to latest git snapshot. spec: https://suve.fedorapeople.org/review/reversal-icon-theme-0%5E20260317.git2c81222-1/reversal-icon-theme.spec srpm: https://suve.fedorapeople.org/review/reversal-icon-theme-0%5E20260317.git2c81222-1/reversal-icon-theme-0%5E20260317.git2c81222-1.fc45.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=149249721
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 329 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: reversal-icon-theme-0^20260317.git2c81222-1.fc46.noarch.rpm reversal-icon-theme-0^20260317.git2c81222-1.fc46.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpa_czrb4f')] checks: 32, packages: 2 reversal-icon-theme.spec: W: no-%check-section reversal-icon-theme.noarch: W: dangling-relative-symlink /usr/share/icons/Reversal-dark/actions/22/audio.svg ../../status/22/audio-volume-high.svg reversal-icon-theme.noarch: W: dangling-relative-symlink /usr/share/icons/Reversal-dark/actions/22/kdenlive-hide-audio.svg ../../status/22/audio-volume-muted.svg reversal-icon-theme.noarch: W: dangling-relative-symlink /usr/share/icons/Reversal-dark/actions/22/kdenlive-show-audio.svg ../../status/22/audio-volume-high.svg reversal-icon-theme.noarch: W: dangling-relative-symlink /usr/share/icons/Reversal-dark/actions/24/audio.svg ../../status/24/audio-volume-high.svg reversal-icon-theme.noarch: W: dangling-relative-symlink /usr/share/icons/Reversal-dark/actions/24/kdenlive-hide-audio.svg ../../status/22/audio-volume-muted.svg reversal-icon-theme.noarch: W: dangling-relative-symlink /usr/share/icons/Reversal-dark/actions/24/kdenlive-show-audio.svg ../../status/22/audio-volume-high.svg reversal-icon-theme.noarch: W: dangling-relative-symlink /usr/share/icons/Reversal-dark/actions/24/player-volume-muted.svg ../../status/22/audio-volume-muted.svg 2 packages and 0 specfiles checked; 0 errors, 8 warnings, 655 filtered, 0 badness; has taken 6.2 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.10.0 configuration: /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 33, packages: 1 reversal-icon-theme.noarch: W: dangling-relative-symlink /usr/share/icons/Reversal-dark/actions/22/audio.svg ../../status/22/audio-volume-high.svg reversal-icon-theme.noarch: W: dangling-relative-symlink /usr/share/icons/Reversal-dark/actions/22/kdenlive-hide-audio.svg ../../status/22/audio-volume-muted.svg reversal-icon-theme.noarch: W: dangling-relative-symlink /usr/share/icons/Reversal-dark/actions/22/kdenlive-show-audio.svg ../../status/22/audio-volume-high.svg reversal-icon-theme.noarch: W: dangling-relative-symlink /usr/share/icons/Reversal-dark/actions/24/audio.svg ../../status/24/audio-volume-high.svg reversal-icon-theme.noarch: W: dangling-relative-symlink /usr/share/icons/Reversal-dark/actions/24/kdenlive-hide-audio.svg ../../status/22/audio-volume-muted.svg reversal-icon-theme.noarch: W: dangling-relative-symlink /usr/share/icons/Reversal-dark/actions/24/kdenlive-show-audio.svg ../../status/22/audio-volume-high.svg reversal-icon-theme.noarch: W: dangling-relative-symlink /usr/share/icons/Reversal-dark/actions/24/player-volume-muted.svg ../../status/22/audio-volume-muted.svg 1 packages and 0 specfiles checked; 0 errors, 7 warnings, 651 filtered, 0 badness; has taken 5.0 s Seems to be false finding Source checksums ---------------- https://github.com/yeyushengfan258/Reversal-icon-theme/archive/2c8122287e3bad5a6bf860ddd8c7e3b78cf4d451/Reversal-icon-theme-2c8122287e3bad5a6bf860ddd8c7e3b78cf4d451.tar.gz : CHECKSUM(SHA256) this package : 3053cef3034a424be0dc5a81a70550c6f9653e8839b1a1bdc13fbd19fb11c344 CHECKSUM(SHA256) upstream package : 3053cef3034a424be0dc5a81a70550c6f9653e8839b1a1bdc13fbd19fb11c344 Requires -------- reversal-icon-theme (rpmlib, GLIBC filtered): /bin/sh hicolor-icon-theme Provides -------- reversal-icon-theme: reversal-icon-theme Issues: - don't use macro url: URL: https://github.com/yeyushengfan258/%{repo_name} the rest is fine, package is APPROVED
Other thing: Mac OS X is called macOS these days
The Pagure repository was created at https://src.fedoraproject.org/rpms/reversal-icon-theme Monitoring: Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`
FEDORA-2026-77e6cade57 (reversal-icon-theme-0^20260317.git2c81222-1.fc45) has been submitted as an update to Fedora 45. https://bodhi.fedoraproject.org/updates/FEDORA-2026-77e6cade57
FEDORA-2026-9c905b8904 (reversal-icon-theme-0^20260317.git2c81222-1.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2026-9c905b8904
FEDORA-2026-77e6cade57 has been pushed to the Fedora 45 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-77e6cade57 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-77e6cade57 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2026-9c905b8904 has been pushed to the Fedora 44 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-9c905b8904 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-9c905b8904 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.