Bug 223949 - postuninstall calls initscript with unimplemented condrestart option
postuninstall calls initscript with unimplemented condrestart option
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: heartbeat (Show other bugs)
6
All Linux
medium Severity low
: ---
: ---
Assigned To: Kevin Fenzi
Fedora Extras Quality Assurance
:
Depends On:
Blocks: FE7Target
  Show dependency treegraph
 
Reported: 2007-01-23 03:22 EST by Tomas Hoger
Modified: 2007-11-30 17:11 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-06-27 23:28:51 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:


Attachments (Terms of Use)

  None (edit)
Description Tomas Hoger 2007-01-23 03:22:19 EST
Description of problem:

postuninstall script calls heartbeat init script with option condrestart:

# rpm -q --scripts heartbeat
[ ... ]
postuninstall scriptlet (using /bin/sh):
if [ "$1" -ge "1" ] ; then
    /sbin/service heartbeat condrestart
fi

However, condrestart is not supported by script:

# /sbin/service heartbeat condrestart
Usage: /etc/init.d/heartbeat {start|stop|status|restart|reload|force-reload}


Version-Release number of selected component (if applicable):

heartbeat-2.0.8-1.fc6


How reproducible:

Upgrade heartbeat package.
Comment 1 Ville Skyttä 2007-02-09 15:32:49 EST
The script was changed to call "restart" instead which is incorrect too:
http://www.redhat.com/archives/fedora-extras-list/2007-February/msg00115.html
Comment 2 Kevin Fenzi 2007-02-18 00:49:44 EST
I would agree... I suspect the right thing to do would not be any restarting at
all. When applying an update to a heartbeat cluster, you don't want it to stop
heartbeat and cause a failover in the middle of updates. 

I will take a deeper look next week... 
Comment 3 Kevin Fenzi 2007-02-26 13:41:25 EST
I am taking over the heartbeat package, so re-assigning this to me to look at. 
Comment 4 Kevin Fenzi 2007-06-27 23:28:51 EDT
Sorry for the big delay here. ;(

I have removed the restart entirely in 2.0.8-3.fc8. 
I don't think we want to restart on upgrade as that will (or can) cause a
unplanned failover.

If everything looks good in fc8 I will push f7 and fc6 updates soon. 

I am going to close this out now. If anyone disagrees, or has better ideas, feel
free to re-open this or file a new bug. Thanks for the report!

Note You need to log in before you can comment on or make changes to this bug.