Bug 2239511 - Review Request: chayang - Gradually dim the screen on wlroots-based compositors
Summary: Review Request: chayang - Gradually dim the screen on wlroots-based compositors
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Dominik 'Rathann' Mierzejewski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-09-18 18:03 UTC by Zephyr Lykos
Modified: 2023-10-06 12:31 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
If this bug requires documentation, please select an appropriate Doc Type value.
Last Closed: 2023-10-06 12:31:09 UTC
Type: ---
Embargoed:
dominik: fedora-review+


Attachments (Terms of Use)

Description Zephyr Lykos 2023-09-18 18:03:12 UTC
Spec URL: https://pagure.io/mochaa-rpms/chayang/raw/rawhide/f/chayang.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/mochaa/chayang/fedora-rawhide-x86_64/06415278-chayang/chayang-0.1.0-1.fc40.src.rpm
Description: Gradually dim the screen. Can be used to implement a grace period before locking the session.
Fedora Account System Username: mochaa

Comment 1 Dominik 'Rathann' Mierzejewski 2023-09-28 16:55:01 UTC
Taking review.

Comment 2 Dominik 'Rathann' Mierzejewski 2023-09-28 17:14:20 UTC
Source matches upstream:
$ sha512sum chayang-0.1.0.tar.gz chayang-0.1.0.tar.gz.orig 
62924d1cf66b43882672f917499e4e73ca221bc1fbeaee2ac3efb9969a5d022c0d414d043b50905a619b9963bf5281b735e4903cfaa68b794c03b46f569aab02  chayang-0.1.0.tar.gz
62924d1cf66b43882672f917499e4e73ca221bc1fbeaee2ac3efb9969a5d022c0d414d043b50905a619b9963bf5281b735e4903cfaa68b794c03b46f569aab02  chayang-0.1.0.tar.gz.orig

licensecheck finds a file licensed under HPND-sell-variant license:
./protocol/wlr-layer-shell-unstable-v1.xml: HPND-sell-variant and/or ntp_disclaimer

So, the License: tag must be corrected.

Fortunately, the missing license is already in allowed list:
https://docs.fedoraproject.org/en-US/legal/allowed-licenses/

The package builds in mock on rawhide.

rpmlint is clean:
chayang.x86_64: W: no-manual-page-for-binary chayang
chayang.spec:40: W: macro-in-%changelog %{autochangelog}
=========================== 4 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 0.3 s ===========================

Comment 3 Zephyr Lykos 2023-09-28 17:59:43 UTC
As per discussed in #fedora-devel, those XML files are used to generate C bindings, so it is not relevant.

See https://src.fedoraproject.org/rpms/wlroots and https://src.fedoraproject.org/rpms/sway

Comment 4 Dominik 'Rathann' Mierzejewski 2023-09-28 21:44:02 UTC
I'd say I agree with the view presented here:
https://opensource.stackexchange.com/questions/6058/is-code-generated-from-an-interface-definition-file-a-derivative-work

Namely, that the generated C source inherits the license of the XML files from which it's generated.

Comment 5 Zephyr Lykos 2023-09-29 07:06:37 UTC
I kinda know why is that.

This is just the "old way" of writing the MIT license,
see <https://fedoraproject.org/wiki/Licensing:MIT?rd=Licensing/MIT#Old_Style_with_legal_disclaimer>.

I think it is safe to just keep the MIT tag.

Comment 7 Dominik 'Rathann' Mierzejewski 2023-10-04 15:27:20 UTC
Looks good now, approved.

Comment 8 Fedora Admin user for bugzilla script actions 2023-10-06 12:05:58 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/chayang

Comment 9 Fedora Update System 2023-10-06 12:29:42 UTC
FEDORA-2023-8839d8d417 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-8839d8d417

Comment 10 Fedora Update System 2023-10-06 12:31:09 UTC
FEDORA-2023-8839d8d417 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.