This bug has been migrated to another issue tracking site. It has been closed here and may no longer be being monitored.

If you would like to get updates for this issue, or to participate in it, you may do so at Red Hat Issue Tracker .
Bug 2239648 - VMI Migration metrics names are inconsistent
Summary: VMI Migration metrics names are inconsistent
Keywords:
Status: CLOSED MIGRATED
Alias: None
Product: Container Native Virtualization (CNV)
Classification: Red Hat
Component: Metrics
Version: 4.15.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: 4.15.0
Assignee: Assaf Admi
QA Contact: Ahmad
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-09-19 15:20 UTC by Shirly Radco
Modified: 2024-02-19 07:29 UTC (History)
3 users (show)

Fixed In Version: hco-bundle-registry-container-v4.15.0.rhel9-1200
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-12-14 16:16:25 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker   CNV-33042 0 None None None 2023-12-14 16:16:24 UTC

Description Shirly Radco 2023-09-19 15:20:11 UTC 
Description of problem:
Migration metrics names are inconsistent.
The following metrics :
kubevirt_migrate_vmi_data_processed_bytes
kubevirt_migrate_vmi_data_remaining_bytes
kubevirt_migrate_vmi_dirty_memory_rate_bytes
kubevirt_migrate_vmi_disk_transfer_rate_bytes
kubevirt_migrate_vmi_memory_transfer_rate_bytes

Have a "kubevirt_migrate_vmi" prefix, while the following metrics:

kubevirt_vmi_migrations_failed
kubevirt_vmi_migrations_succeeded
kubevirt_vmi_migrations_pending
kubevirt_vmi_migrations_running
kubevirt_vmi_migrations_scheduling

Have a "kubevirt_vmi_migrations_" prefix.
All these metrics should have the same prefix.

We may want to have it as "kubevirt_vmi_migration_" where we use the singular form of "migration".

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Search for vmi migration metric.
2.
3.

Actual results:
Not all vmi migration metrics have the same prefix

Expected results:
All vmi migration metrics should have the same prefix.


Additional info:
Comment 1 Assaf Admi 2023-10-03 14:40:44 UTC 
Fix PR was merged - https://github.com/kubevirt/kubevirt/pull/10486.
Comment 2 Ahmad 2023-10-16 18:13:22 UTC 

QA: tested
OCP-4.14.0-rc.4 CNV-v4.15.0.rhel9-1349
naming is not as it's expected


expected names as https://access.redhat.com/articles/7028805  & https://github.com/kubevirt/monitoring/blob/main/docs/metrics.md

kubevirt_vmi_migrations_succeeded
kubevirt_vmi_migrations_pending
kubevirt_vmi_migrations_failed 
kubevirt_vmi_migrations_running
kubevirt_vmi_migrations_scheduling


actual names:
kubevirt_vmi_migration_succeeded 
kubevirt_vmi_migrations_in_pending_phase
kubevirt_vmi_migrations_in_running_phase
kubevirt_vmi_migrations_in_scheduling_phase
Comment 3 Ahmad 2023-10-18 14:49:21 UTC 
QA: tested
OCP-4.14.0-rc.4 CNV-v4.15.0.rhel9-1349
naming is correct  


|kubevirt_migrate_vmi_data_processed_bytes | kubevirt_vmi_migration_data_processed_bytes|
|kubevirt_migrate_vmi_data_remaining_bytes | kubevirt_vmi_migration_data_remaining_bytes|
|kubevirt_migrate_vmi_dirty_memory_rate_bytes | kubevirt_vmi_migration_dirty_memory_rate_bytes|
|kubevirt_migrate_vmi_disk_transfer_rate_bytes | kubevirt_vmi_migration_disk_transfer_rate_bytes|
|kubevirt_migrate_vmi_memory_transfer_rate_bytes | kubevirt_vmi_migration_memory_transfer_rate_bytes|
|kubevirt_vmi_migrations_failed | kubevirt_vmi_migration_failed|
|kubevirt_vmi_migrations_succeeded | kubevirt_vmi_migration_succeeded|
|kubevirt_vmi_migrations_pending | kubevirt_vmi_migrations_in_pending_phase|
|kubevirt_vmi_migrations_running | kubevirt_vmi_migrations_in_running_phase|
|kubevirt_vmi_migrations_scheduling | kubevirt_vmi_migrations_in_scheduling_phase|



regard kubevirt_vmi_migration_memory_transfer_rate_bytes it's not working properly but a separate bug is reported https://bugzilla.redhat.com/show_bug.cgi?id=2117186
moving to verified
Note You need to log in before you can comment on or make changes to this bug.