The patch at https://src.fedoraproject.org/rpms/salt/blob/rawhide/f/match_hostname.patch breaks salt-ssh when managing other distributions with older Python version (like Debian stable with Python 3.11). Reproducible: Always Steps to Reproduce: 1. Configure salt-ssh to manage Debian stable system over ssh 2. Call `salt-ssh $REMOTE_HOSTNAME state.highstate` (with $REMOTE_HOSTNAME replaced with the actual hostname. Probably simpler commands like `salt-ssh grains.items` are affected too. Actual Results: ``` Traceback (most recent call last): File "/var/tmp/.root_dd8a91_salt/salt-call", line 27, in <module> salt_call() File "/var/tmp/.root_dd8a91_salt/pyall/salt/scripts.py", line 438, in salt_call import salt.cli.call File "/var/tmp/.root_dd8a91_salt/pyall/salt/cli/call.py", line 3, in <module> import salt.cli.caller File "/var/tmp/.root_dd8a91_salt/pyall/salt/cli/caller.py", line 12, in <module> import salt.channel.client File "/var/tmp/.root_dd8a91_salt/pyall/salt/channel/client.py", line 13, in <module> import salt.crypt File "/var/tmp/.root_dd8a91_salt/pyall/salt/crypt.py", line 26, in <module> import salt.payload File "/var/tmp/.root_dd8a91_salt/pyall/salt/payload.py", line 12, in <module> import salt.loader.context File "/var/tmp/.root_dd8a91_salt/pyall/salt/loader/__init__.py", line 23, in <module> import salt.utils.event File "/var/tmp/.root_dd8a91_salt/pyall/salt/utils/event.py", line 67, in <module> import salt.ext.tornado.iostream File "/var/tmp/.root_dd8a91_salt/pyall/salt/ext/tornado/iostream.py", line 42, in <module> import urllib3.util.ssl_match_hostname ModuleNotFoundError: No module named 'urllib3.util.ssl_match_hostname' [ERROR ] An un-handled exception was caught by Salt's global exception handler: ModuleNotFoundError: No module named 'urllib3.util.ssl_match_hostname' Traceback (most recent call last): File "/var/tmp/.root_dd8a91_salt/salt-call", line 27, in <module> salt_call() File "/var/tmp/.root_dd8a91_salt/pyall/salt/scripts.py", line 438, in salt_call import salt.cli.call File "/var/tmp/.root_dd8a91_salt/pyall/salt/cli/call.py", line 3, in <module> import salt.cli.caller File "/var/tmp/.root_dd8a91_salt/pyall/salt/cli/caller.py", line 12, in <module> import salt.channel.client File "/var/tmp/.root_dd8a91_salt/pyall/salt/channel/client.py", line 13, in <module> import salt.crypt File "/var/tmp/.root_dd8a91_salt/pyall/salt/crypt.py", line 26, in <module> import salt.payload File "/var/tmp/.root_dd8a91_salt/pyall/salt/payload.py", line 12, in <module> import salt.loader.context File "/var/tmp/.root_dd8a91_salt/pyall/salt/loader/__init__.py", line 23, in <module> import salt.utils.event File "/var/tmp/.root_dd8a91_salt/pyall/salt/utils/event.py", line 67, in <module> import salt.ext.tornado.iostream File "/var/tmp/.root_dd8a91_salt/pyall/salt/ext/tornado/iostream.py", line 42, in <module> import urllib3.util.ssl_match_hostname ModuleNotFoundError: No module named 'urllib3.util.ssl_match_hostname' ``` Expected Results: No exception Removing the patch fixes the issue. It worked correctly in 3006.1-2.
Created attachment 1989723 [details] Patch Does this modified patch help?
Yes, it helps, thanks for quick response!
Excellent, I'll get out an update ASAP. Anytime!
FEDORA-2023-e5b9511c5a has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-e5b9511c5a
FEDORA-2023-cd02b95c02 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-cd02b95c02
FEDORA-2023-e5b9511c5a has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-e5b9511c5a` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-e5b9511c5a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-cd02b95c02 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-cd02b95c02` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-cd02b95c02 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-e5b9511c5a has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-cd02b95c02 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.