Bug 2240173 - backport fvwm3 xthreadlock() patch
Summary: backport fvwm3 xthreadlock() patch
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: fvwm
Version: 39
Hardware: x86_64
OS: Linux
unspecified
urgent
Target Milestone: ---
Assignee: Peter Lemenkov
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-09-22 08:58 UTC by Phil Smith
Modified: 2024-01-29 07:53 UTC (History)
3 users (show)

Fixed In Version: fvwm-2.7.0-9.fc39 fvwm-2.7.0-9.fc38
Clone Of:
Environment:
Last Closed: 2024-01-29 06:25:14 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
fvwm xthreadlock patch (2.60 KB, patch)
2023-09-22 09:25 UTC, Phil Smith
no flags Details | Diff

Description Phil Smith 2023-09-22 08:58:00 UTC
fvwm2 crashes on various machines when, for example, exiting emacs and almost every time Zoom (meeting) quits. This is fixed by applying the fvwm3 xthreadlock() patch to fvwm2. This problem causes loss of data so is important (complete window manager crash).
See: https://github.com/fvwmorg/fvwm/pull/102
I've applied the patch to the current Fedora fvwm and it fixes the problem. No more crashes and no side-effects.

Reproducible: Always

Steps to Reproduce:
1.use fvwm as window manager
2.open zoom
3.close zoom
Actual Results:  
Window manager crashes killing all windows and losing work

Expected Results:  
Window should gracefully close.

Known problem and known cause which has been fixed on fvwm github in fvwm3 but not yet backported to fvwm2. Fedora uses fvwm2.

See: https://github.com/fvwmorg/fvwm3/commit/5c17c83df4605d2d97999740cf180af983298896
"XCheckIfEvent() holds the X display lock and the predicate
function it calls is not allowed to call any Xlib function that
would re-enter the lock.
libX11 1.8.1 enables X display locks unconditionnaly (it was only
enabled by XInitThreads() when called explicitely before) and
thus exposes the issue."

"So don't process events in the FCheckPeekIfEvent() predicate, but
instead use a separate handler that is called for the returned event
out of the lock."

Comment 1 Phil Smith 2023-09-22 09:25:50 UTC
Created attachment 1990029 [details]
fvwm xthreadlock patch

This is the xthreadlock patch from Thomas Adam at https://github.com/fvwmorg/fvwm/pull/102
see also https://github.com/fvwmorg/fvwm3/commit/5c17c83df4605d2d97999740cf180af983298896

I applied this patch. Lots of crashes before, no crashes after. No side-effects. I'm a long-term (decades!) fvwm user.

Comment 2 Aoife Moloney 2023-11-23 01:50:31 UTC
This message is a reminder that Fedora Linux 37 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora Linux 37 on 2023-12-05.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
'version' of '37'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, change the 'version' 
to a later Fedora Linux version. Note that the version field may be hidden.
Click the "Show advanced fields" button if you do not see it.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora Linux 37 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora Linux, you are encouraged to change the 'version' to a later version
prior to this bug being closed.

Comment 3 Fedora Update System 2024-01-21 13:53:22 UTC
FEDORA-2024-7f70c1c68c has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-7f70c1c68c

Comment 4 Fedora Update System 2024-01-21 13:53:23 UTC
FEDORA-2024-0db23f9222 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-0db23f9222

Comment 5 Fedora Update System 2024-01-22 01:22:26 UTC
FEDORA-2024-0db23f9222 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-0db23f9222`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-0db23f9222

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2024-01-22 02:15:50 UTC
FEDORA-2024-7f70c1c68c has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-7f70c1c68c`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-7f70c1c68c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2024-01-29 06:25:14 UTC
FEDORA-2024-0db23f9222 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2024-01-29 07:53:42 UTC
FEDORA-2024-7f70c1c68c has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.