Spec URL: https://git.remirepo.net/cgit/rpms/php/nikic/php-nikic-php-parser5.git/plain/php-nikic-php-parser5.spec?id=9141ee7420894c44d00deb896976d43d45df6044 SRPM URL: https://rpms.remirepo.net/SRPMS/php-nikic-php-parser5-5.0.0~alpha3-1.remi.src.rpm Description: This is a PHP parser written in PHP. Its purpose is to simplify static code analysis and manipulation. This package provides the library version 5 and the php-parse5 command. Documentation: https://github.com/nikic/PHP-Parser/tree/master/doc Autoloader: /usr/share/php/PhpParser5/autoload.php Fedora Account System Username: remi --- Used by PHP version 8.3 https://fedoraproject.org/wiki/Changes/php83 Notice: beta1 is tagged but PHP still requires alpha3 for now.
Spec URL: https://git.remirepo.net/cgit/rpms/php/nikic/php-nikic-php-parser5.git/plain/php-nikic-php-parser5.spec?id=a11fc03d51aeb3860f2df138078b75238e62fead SRPM URL: https://rpms.remirepo.net/SRPMS/php-nikic-php-parser5-5.0.0~rc1-1.remi.src.rpm ---- Notice: now used by PHP 8.3 (recommended) and phpunit10 stack (v4 or v5 are supported)
Copr build: https://copr.fedorainfracloud.org/coprs/build/6782729 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2240617-php-nikic-php-parser5/fedora-rawhide-x86_64/06782729-php-nikic-php-parser5/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://git.remirepo.net/cgit/rpms/php/nikic/php-nikic-php-parser5.git/plain/php-nikic-php-parser5.spec?id=b8b450cc541fe6f9daf7374cbd538a93ab7cbfcb SRPM URL: https://rpms.remirepo.net/SRPMS/php-nikic-php-parser5-5.0.0-1.remi.src.rpm
Created attachment 2007725 [details] The .spec file difference from Copr build 6782729 to 6871399
Copr build: https://copr.fedorainfracloud.org/coprs/build/6871399 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2240617-php-nikic-php-parser5/fedora-rawhide-x86_64/06871399-php-nikic-php-parser5/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://git.remirepo.net/cgit/rpms/php/nikic/php-nikic-php-parser5.git/plain/php-nikic-php-parser5.spec?id=09b83c010ef0b06139c6204bdee13b5d6a568e1b SRPM URL: https://rpms.remirepo.net/SRPMS/php-nikic-php-parser5-5.0.1-1.remi.src.rpm
Created attachment 2018127 [details] The .spec file difference from Copr build 6871399 to 7048729
Copr build: https://copr.fedorainfracloud.org/coprs/build/7048729 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2240617-php-nikic-php-parser5/fedora-rawhide-x86_64/07048729-php-nikic-php-parser5/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Update to 5.0.2 Spec URL: https://git.remirepo.net/cgit/rpms/php/nikic/php-nikic-php-parser5.git/plain/php-nikic-php-parser5.spec?id=eedda06923ce27ddc7f291c49343a440f7d9d613 SRPM URL: https://rpms.remirepo.net/SRPMS/php-nikic-php-parser5-5.0.2-1.remi.src.rpm
Created attachment 2020315 [details] The .spec file difference from Copr build 7048729 to 7109466
Copr build: https://copr.fedorainfracloud.org/coprs/build/7109466 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2240617-php-nikic-php-parser5/fedora-rawhide-x86_64/07109466-php-nikic-php-parser5/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
A couple comments. - For my education, could you please explain ? ``` # For compatibility with SCL %undefine __brp_mangle_shebangs ``` - Typo : `# disabled as phpunit not availble` --> available - Add a comment explaining upstream tarball is not usable due to missing tests, etc... - In %%files, spurious line : ``` # remirepo:1 ``` - In %%files, I believe the following line has lost its purpose nowadays: ``` %{!?_licensedir:%global license %%doc} ``` - I find using ':' rather than '#' for commented lines to be confusing, but that is probably just me
(In reply to Xavier Bachelot from comment #12) > A couple comments. > > - For my education, could you please explain ? > ``` > # For compatibility with SCL > %undefine __brp_mangle_shebangs This is only for my repository, with Software Collection allowing to run the provided command with enabled collection > ``` > > - Typo : `# disabled as phpunit not availble` --> available Fixed > > - Add a comment explaining upstream tarball is not usable due to missing > tests, etc... Fixed > > - In %%files, spurious line : > ``` > # remirepo:1 Only a comment ;) This is design ro remove next line(s) with I copy from my repo to fedora one > ``` > > - In %%files, I believe the following line has lost its purpose nowadays: > ``` > %{!?_licensedir:%global license %%doc} > ``` Still needed for EL-7 ;) > > - I find using ':' rather than '#' for commented lines to be confusing, but > that is probably just me I use ':' as this appears in the build output (and avoid duplicate output of 'echo') I have removed my repo specific stuff Spec URL: https://rpms.remirepo.net/temp/php-nikic-php-parser5.spec SRPM URL: https://rpms.remirepo.net/temp/php-nikic-php-parser5-5.0.2-1.fedora.src.rpm
Created attachment 2020345 [details] The .spec file difference from Copr build 7109466 to 7111038
Copr build: https://copr.fedorainfracloud.org/coprs/build/7111038 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2240617-php-nikic-php-parser5/fedora-rawhide-x86_64/07111038-php-nikic-php-parser5/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/php [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 93767 bytes in 9 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. PHP: [x]: Run phpci static analyze on all php files. Note: usage /usr/share/php-bartlett-PHP-CompatInfo/fedora-review-check logname dirname 7.1.2@072d0f8 static analyze results in /tmp/2240617-php-nikic-php-parser5/phpci.log Rpmlint ------- Checking: php-nikic-php-parser5-5.0.2-1.fc41.noarch.rpm php-nikic-php-parser5-5.0.2-1.fc41.src.rpm ============================================== rpmlint session starts ============================================= rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpa_7ljvq9')] checks: 32, packages: 2 php-nikic-php-parser5.noarch: E: spelling-error ('autoload', '%description -l en_US autoload -> auto load, auto-load, tautology') php-nikic-php-parser5.src: E: spelling-error ('usr', '%description -l en_US usr -> use, us, user') php-nikic-php-parser5.src: E: spelling-error ('autoload', '%description -l en_US autoload -> auto load, auto-load, tautology') php-nikic-php-parser5.noarch: W: no-manual-page-for-binary php-parse5 php-nikic-php-parser5.spec: W: invalid-url Source0: php-nikic-php-parser5-5.0.2-1396767.tgz ========= 2 packages and 0 specfiles checked; 3 errors, 2 warnings, 7 filtered, 3 badness; has taken 0.3 s ======== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 php-nikic-php-parser5.noarch: E: spelling-error ('autoload', '%description -l en_US autoload -> auto load, auto-load, tautology') php-nikic-php-parser5.noarch: W: no-manual-page-for-binary php-parse5 1 packages and 0 specfiles checked; 1 errors, 1 warnings, 3 filtered, 1 badness; has taken 0.1 s Requires -------- php-nikic-php-parser5 (rpmlib, GLIBC filtered): /usr/bin/php php(language) php-cli php-composer(fedora/autoloader) php-ctype php-json php-pcre php-reflection php-spl php-tokenizer Provides -------- php-nikic-php-parser5: php-composer(nikic/php-parser) php-nikic-php-parser5 Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2240617 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, PHP, Generic Disabled plugins: SugarActivity, R, C/C++, Java, Ocaml, Perl, Python, Haskell, fonts Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Package is APPROVED
The Pagure repository was created at https://src.fedoraproject.org/rpms/php-nikic-php-parser5
Thanks for the review! SCM requests Rawhide: https://pagure.io/releng/fedora-scm-requests/issue/60784 F40: https://pagure.io/releng/fedora-scm-requests/issue/60785 F39: https://pagure.io/releng/fedora-scm-requests/issue/60786 EPEL-9: https://pagure.io/releng/fedora-scm-requests/issue/60787
FEDORA-EPEL-2024-358d5fe1a9 (php-nikic-php-parser5-5.0.2-1.el9) has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-358d5fe1a9
FEDORA-2024-7eaf3c9062 (php-nikic-php-parser5-5.0.2-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-7eaf3c9062
FEDORA-2024-981fc6003e (php-nikic-php-parser5-5.0.2-1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-981fc6003e
FEDORA-2024-7eaf3c9062 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-7eaf3c9062 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-7eaf3c9062 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2024-358d5fe1a9 has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-358d5fe1a9 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-981fc6003e has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-981fc6003e \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-981fc6003e See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2024-358d5fe1a9 (php-nikic-php-parser5-5.0.2-1.el9) has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-981fc6003e (php-nikic-php-parser5-5.0.2-1.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-7eaf3c9062 (php-nikic-php-parser5-5.0.2-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.