Spec URL: https://sham1.xyz/files/rpm-review/xss-lock/xss-lock.spec SRPM URL: https://sham1.xyz/files/rpm-review/xss-lock/xss-lock-0.3.0^20140302git1e158fb20108-1.fc40.src.rpm Description: xss-lock hooks up your favorite locker to the MIT screen saver extension for X and also to systemd's login manager. Fedora Account System Username: sham1 More details: This review is for unretiring the package after it was retired in the rawhide branch due to being orphaned. changelog file for %autochangelog: https://sham1.xyz/files/rpm-review/xss-lock/changelog
I will take this review.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - I just want to make sure you know what you're getting into. I count 1 deprecation warning from glib2 when building, 4 open pull requests, and 18 open issues on bitbucket. Since upstream appears to be inactive, you're putting yourself on the hook to address any of those issues that affect Fedora users. Are you sure you want to sign up for that? - What is the rationale for the python3-docutils BR? It doesn't seem to be used in the build. - Note the rpmlint warnings below: strange-permission and mixed-use-of-spaces-and-tabs ===== MUST items ===== C/C++: [-]: Provides: bundled(gnulib) in place as required. [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License". 16 files have unknown license. Detailed output of licensecheck in /home/jamesjer/2240906-xss-lock/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 6636 bytes in 5 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: xss-lock-0.3.0^20140302git1e158fb20108-1.fc40.x86_64.rpm xss-lock-debuginfo-0.3.0^20140302git1e158fb20108-1.fc40.x86_64.rpm xss-lock-debugsource-0.3.0^20140302git1e158fb20108-1.fc40.x86_64.rpm xss-lock-0.3.0^20140302git1e158fb20108-1.fc40.src.rpm ================================================ rpmlint session starts ================================================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmptefhi3n0')] checks: 31, packages: 4 xss-lock.src: W: strange-permission xss-lock.spec 600 xss-lock.spec:30: W: mixed-use-of-spaces-and-tabs (spaces: line 30, tab: line 19) ================= 4 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 0.2 s ================= Rpmlint (debuginfo) ------------------- Checking: xss-lock-debuginfo-0.3.0^20140302git1e158fb20108-1.fc40.x86_64.rpm ================================================ rpmlint session starts ================================================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp6u31bi9_')] checks: 31, packages: 1 ================= 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.1 s ================= Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3 3 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.3 s Source checksums ---------------- https://bitbucket.org/raymonad/xss-lock/get/1e158fb20108058dbd62bd51d8e8c003c0a48717.tar.gz#/xss-lock-1e158fb20108.tar.gz : CHECKSUM(SHA256) this package : 19c9e55fd14346e79a1cfaa400cb51ef467d9e3f482fb28a38ba2bbc2c972d91 CHECKSUM(SHA256) upstream package : 19c9e55fd14346e79a1cfaa400cb51ef467d9e3f482fb28a38ba2bbc2c972d91 Requires -------- xss-lock (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libxcb-screensaver.so.0()(64bit) libxcb-util.so.1()(64bit) libxcb.so.1()(64bit) rtld(GNU_HASH) xcb-util xss-lock-debuginfo (rpmlib, GLIBC filtered): xss-lock-debugsource (rpmlib, GLIBC filtered): Provides -------- xss-lock: xss-lock xss-lock(x86-64) xss-lock-debuginfo: debuginfo(build-id) xss-lock-debuginfo xss-lock-debuginfo(x86-64) xss-lock-debugsource: xss-lock-debugsource xss-lock-debugsource(x86-64) Diff spec file in url and in SRPM --------------------------------- --- /home/jamesjer/2240906-xss-lock/srpm/xss-lock.spec 2023-09-29 15:28:59.038620718 -0600 +++ /home/jamesjer/2240906-xss-lock/srpm-unpacked/xss-lock.spec 2023-09-26 18:00:00.000000000 -0600 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.3.5) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + # Rationale for choosing a post release: # @@ -68,3 +78,4 @@ %changelog -%autochangelog +* Wed Sep 27 2023 John Doe <packager> - 0.3.0^20140302git1e158fb20108-1 +- Uncommitted changes Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2240906 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, C/C++, Shell-api Disabled plugins: fonts, Haskell, Python, R, Perl, Ocaml, PHP, Ruby, SugarActivity, Java Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
> - I just want to make sure you know what you're getting into. I count 1 > deprecation warning from glib2 when building, 4 open pull requests, and 18 > open issues on bitbucket. Since upstream appears to be inactive, you're > putting yourself on the hook to address any of those issues that affect > Fedora users. Are you sure you want to sign up for that? I understand what I'm getting myself into here. I'll probably start a fork for the project at some point, but before that I'd like to get the current project version up to Fedora again just so it can be used at all. > - What is the rationale for the python3-docutils BR? It doesn't seem to be > used in the build. Honestly? No idea. It must have just been left there from the previous maintainer. Removed. > - Note the rpmlint warnings below: strange-permission and > mixed-use-of-spaces-and-tabs Tabs were fixed. As for the permissions problem in the SRMP, I have no idea how that happened. Seems that `fedpkg mockbuild` was being a tad screwy. Anyway, fixed. Spec URL: https://sham1.xyz/files/rpm-review/xss-lock/xss-lock.spec SRPM URL: https://sham1.xyz/files/rpm-review/xss-lock/xss-lock-0.3.0^20140302git1e158fb20108-1.fc39.src.rpm
(In reply to Jani Juhani Sinervo from comment #3) > Honestly? No idea. It must have just been left there from the previous > maintainer. Removed. Okay, that looks good, except the python3-docutils is still in the spec file at the URL in comment 3. Fix that before you import. This package is APPROVED.
Hm, turns out that python3-docutils was actually a necessary thing for generating the man-page. Oh well, sometimes that happens, dunno why I didn't figure that out sooner.
Oops, sorry for leading you astray then. I honestly didn't see it invoked in the build log...