Bug 2241049 - Review Request: rust-gix-pathspec - Library for dealing with magical pathspecs used by gix
Summary: Review Request: rust-gix-pathspec - Library for dealing with magical pathspec...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-09-27 20:08 UTC by blinxen
Modified: 2023-09-27 22:49 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-09-27 22:49:43 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description blinxen 2023-09-27 20:08:11 UTC
Spec URL: https://blinxen.fedorapeople.org/rust-gix-pathspec/rust-gix-pathspec.spec
SRPM URL: https://blinxen.fedorapeople.org/rust-gix-pathspec/rust-gix-pathspec-0.2.0-1.fc40.src.rpm

Description:
A crate of the gitoxide project dealing magical pathspecs.

Fedora Account System Username: blinxen

Comment 1 blinxen 2023-09-27 20:08:14 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=106801026

Comment 2 Fabio Valentini 2023-09-27 22:19:19 UTC
Can you file an upstream issue to get the "tests" directory excluded from published crates
(since they add false positive bash dependencies, and we can't run them anyway)?

Adding a setting like `package.exclude = ["/tests/"]` should do it (both for this package and for upstream).

Other than that, package is looking good to me.

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
! test suite is run and all unit tests pass (tests disabled with explanation)
! latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

Upstream released 0.3.0 in the meantime, please update as soon as that's possible.

Also look for my comment on top in case you missed it :)

Comment 3 blinxen 2023-09-27 22:28:42 UTC
> Can you file an upstream issue to get the "tests" directory excluded from published crates

Do you mean for all `gix` crates or just this one?

Comment 4 Fedora Admin user for bugzilla script actions 2023-09-27 22:29:38 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-gix-pathspec

Comment 5 Fedora Update System 2023-09-27 22:47:06 UTC
FEDORA-2023-87a9db2754 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-87a9db2754

Comment 6 Fedora Update System 2023-09-27 22:49:43 UTC
FEDORA-2023-87a9db2754 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.