spec: https://download.copr.fedorainfracloud.org/results/fed500/tinygrad/fedora-rawhide-x86_64/06483744-tinygrad/tinygrad.spec srpm: https://download.copr.fedorainfracloud.org/results/fed500/tinygrad/fedora-rawhide-x86_64/06483744-tinygrad/tinygrad-0.7.0-1.fc40.src.rpm description: tinygrad: For something between PyTorch and karpathy/micrograd. Maintained by tiny corp. This may not be the best deep learning framework, but it is a deep learning framework. Due to its extreme simplicity, it aims to be the easiest framework to add new accelerators to, with support for both inference and training. If XLA is CISC, tinygrad is RISC. fas: fed500 Reproducible: Always
koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=106996204
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues ====== - This is a python library, not an application, so it MUST be named with a python{,3} prefix https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_library_naming - Bonus points: consider using 'pytest -k' rather than multiple pytest invocations ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License", "*No copyright* Apache License 2.0", "Apache License 2.0". 311 files have unknown license. Detailed output of licensecheck in /home/rpmbuild/review/2241790-tinygrad/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [!]: Package is named according to the Package Naming Guidelines. [?]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 35717 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [!]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: tinygrad-0.7.0-1.fc40.noarch.rpm tinygrad-0.7.0-1.fc40.src.rpm ====================================== rpmlint session starts ====================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpb037dbmx')] checks: 31, packages: 2 tinygrad.noarch: W: name-repeated-in-summary tinygrad tinygrad.src: W: name-repeated-in-summary tinygrad ======= 2 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 0.6 s ======= Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 tinygrad.noarch: W: name-repeated-in-summary tinygrad 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.1 s Source checksums ---------------- https://github.com/tinygrad/tinygrad/archive/v0.7.0/tinygrad-0.7.0.tar.gz : CHECKSUM(SHA256) this package : 03858ecd78484825a91180c19a62081ba1760864f46d7796cde81ea60e07c65d CHECKSUM(SHA256) upstream package : 03858ecd78484825a91180c19a62081ba1760864f46d7796cde81ea60e07c65d Requires -------- tinygrad (rpmlib, GLIBC filtered): python(abi) python3.12dist(networkx) python3.12dist(numpy) python3.12dist(pillow) python3.12dist(pyopencl) python3.12dist(pyyaml) python3.12dist(requests) python3.12dist(tqdm) Provides -------- tinygrad: python3.12dist(tinygrad) python3dist(tinygrad) tinygrad Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2241790 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Python Disabled plugins: Haskell, fonts, SugarActivity, PHP, Ocaml, Java, C/C++, R, Perl Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Thanks. Updated. Put all files in pytest section rather than use a loop. spec: https://download.copr.fedorainfracloud.org/results/fed500/tinygrad/fedora-rawhide-x86_64/06508094-python-tinygrad/python-tinygrad.spec srpm: https://download.copr.fedorainfracloud.org/results/fed500/tinygrad/fedora-rawhide-x86_64/06508094-python-tinygrad/python-tinygrad-0.7.0-1.fc40.src.rpm
Quick review after the applied changes, no further issues found, package APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-tinygrad
FEDORA-2023-aa0f5e9744 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-aa0f5e9744
FEDORA-2023-65402db03f has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-65402db03f
Thanks.
FEDORA-2023-9f2707bc1a has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-9f2707bc1a
FEDORA-2023-aa0f5e9744 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-aa0f5e9744 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-aa0f5e9744 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-9f2707bc1a has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-9f2707bc1a \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-9f2707bc1a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-65402db03f has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-65402db03f \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-65402db03f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-9f2707bc1a has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-65402db03f has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-aa0f5e9744 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.