Bug 2241830 - Review Request: VulkanMemoryAllocator - Easy to integrate Vulkan memory allocation library
Summary: Review Request: VulkanMemoryAllocator - Easy to integrate Vulkan memory alloc...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Onuralp Sezer
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-10-02 21:54 UTC by Jeremy Newton
Modified: 2023-10-07 17:39 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-10-07 17:39:53 UTC
Type: ---
Embargoed:
thunderbirdtr: fedora-review+


Attachments (Terms of Use)

Description Jeremy Newton 2023-10-02 21:54:08 UTC
Spec URL: https://mystro256.fedorapeople.org/VulkanMemoryAllocator.spec
SRPM URL: https://mystro256.fedorapeople.org/VulkanMemoryAllocator-3.0.1-1.fc40.src.rpm
Description:
The Vulkan Memory Allocator (VMA) library provides a simple and easy to
integrate API to help you allocate memory for Vulkan buffer and image storage.
Fedora Account System Username: mystro256
COPR Build: https://copr.fedorainfracloud.org/coprs/mystro256/playground/build/6484445/

Comment 1 Onuralp Sezer 2023-10-02 22:09:17 UTC
I am taking the review.

Comment 2 Onuralp Sezer 2023-10-02 22:14:22 UTC
First of could you please split "doc/html" into -docs to reduce size of devel package. 

Also you can add "%autosetup -p1" in case any patch comes in it can accept automatically.

Comment 3 Jeremy Newton 2023-10-03 14:25:38 UTC
Sure, docs are small, but they can grow later.

I used -doc as per the packaging guidelines.

See:
Spec URL: https://mystro256.fedorapeople.org/VulkanMemoryAllocator.spec
SRPM URL: https://mystro256.fedorapeople.org/VulkanMemoryAllocator-3.0.1-2.fc40.src.rpm
COPR Build: https://copr.fedorainfracloud.org/coprs/mystro256/playground/build/6486717/

It's worth noting that all the upstream fixes can't be cherry-picked, as 3.0.x branch back in 2022, so I used sed for now.

Comment 4 Onuralp Sezer 2023-10-05 13:21:00 UTC
* Package follows Fedora packaging guidelines
* Package builds and installs
* Package licensing looks correct
* No serious issues in rpmlint

Everything looks good

PACKAGE APPROVED.

Comment 5 Fedora Admin user for bugzilla script actions 2023-10-06 15:36:34 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/VulkanMemoryAllocator

Comment 6 Jeremy Newton 2023-10-07 17:39:53 UTC
Thanks!


Note You need to log in before you can comment on or make changes to this bug.