Bug 2241989 - Review Request: golang-fortio-assert - Minimalistic replacement for stretchr/testify/assert
Summary: Review Request: golang-fortio-assert - Minimalistic replacement for stretchr/...
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1998778 2241991 2241994
TreeView+ depends on / blocked
 
Reported: 2023-10-03 18:36 UTC by Pavel Solovev
Modified: 2025-05-03 09:47 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Pavel Solovev 2023-10-03 18:36:44 UTC
Spec URL: https://solopasha.fedorapeople.org/for-review/golang-fortio-assert.spec
SRPM URL: https://solopasha.fedorapeople.org/for-review/golang-fortio-assert-1.2.0-1.fc40.src.rpm

Description:
Minimalistic replacement for
https://pkg.go.dev/github.com/stretchr/testify/assert.

Fedora Account System Username: solopasha

Comment 1 Pavel Solovev 2023-10-03 18:36:47 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=107025627

Comment 2 Mikel Olasagasti Uranga 2024-03-06 19:53:33 UTC
spec has been created with go2rpm-1.9.0 and although it's correct, if you can use the go2rpm-1.11.0 template it will be better for the future. This is the diff, there are just some minimal changes:

> --- golang-fortio-assert.spec.1	2023-10-03 20:36:41.000000000 +0200
> +++ golang-fortio-assert.spec	2024-03-06 20:50:45.774730132 +0100
> @@ -1,4 +1,4 @@
> -# Generated by go2rpm 1.9.0
> +# Generated by go2rpm 1.10.0
>  %bcond_without check
>  %global debug_package %{nil}
>  
> @@ -7,8 +7,7 @@
>  %global forgeurl        https://github.com/fortio/assert
>  Version:                1.2.0
>  
> -%gometa -f
>
> +%gometa -L -f
>  
>  %global common_description %{expand:
>  Minimalistic replacement for
> @@ -17,7 +16,7 @@
>  %global golicenses      LICENSE
>  %global godocs          README.md
>  
> -Name:           %{goname}
> +Name:           golang-fortio-assert
>  Release:        %autorelease
>  Summary:        Minimalistic replacement for stretchr/testify/assert
>  
> @@ -30,7 +29,7 @@
>  %gopkg
>  
>  %prep
> -%goprep
> +%goprep -A
>  %autopatch -p1
>  
>  %generate_buildrequires

Please, update this and the other specs to the new template if possible.


I am not going to go through the whole fedora-review template, as this package uses go2rpm.

- [x] The specfile is sane.
- [x] License is correct
- [x] Builds successfully in mock
- [x] Package is installable (checked by fedora-review)
- [x] No relevant rpmlint errors
- [x] %check section passes
- [x] The latest version is packaged
- [x] `%goipath` is set correctly
- [-] Binaries don't conflict with binaries already in the distribution
- [x] The package complies with the Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add package to release-monitoring.org
- [ ] Give go-sig privileges on package
- [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket.

Comment 3 Package Review 2025-05-03 09:47:19 UTC
Package was never imported.
The ticket status is being reset, since creating the repository will require a fresh approval.
Let us know if you're still interested in this package.


Note You need to log in before you can comment on or make changes to this bug.