Spec URL: https://farchord.fedorapeople.org/reviews/kf6-kcolorscheme/kf6-kcolorscheme.spec SRPM URL: https://farchord.fedorapeople.org/reviews/kf6-kcolorscheme/kf6-kcolorscheme-5.240.0^20231001.103550.783d488-1.fc39.src.rpm Description: Classes to read and interact with KColorScheme. Fedora Account System Username: farchord
Copr build: https://copr.fedorainfracloud.org/coprs/build/6489887 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2242136-kf6-kcolorscheme/fedora-rawhide-x86_64/06489887-kf6-kcolorscheme/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://farchord.fedorapeople.org/reviews/kf6-kcolorscheme/kf6-kcolorscheme.spec SRPM URL: https://farchord.fedorapeople.org/reviews/kf6-kcolorscheme/kf6-kcolorscheme-5.240.0^20231001.103550.783d488-1.fc39.src.rpm Updated build requirements
Created attachment 1992117 [details] The .spec file difference from Copr build 6489887 to 6490542
Copr build: https://copr.fedorainfracloud.org/coprs/build/6490542 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2242136-kf6-kcolorscheme/fedora-rawhide-x86_64/06490542-kf6-kcolorscheme/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://farchord.fedorapeople.org/reviews/kf6-kcolorscheme/kf6-kcolorscheme.spec SRPM URL: https://farchord.fedorapeople.org/reviews/kf6-kcolorscheme/kf6-kcolorscheme-5.240.0^20231001.103550.783d488-1.fc39.src.rpm Fixed a mistake with requirements
Created attachment 1992155 [details] The .spec file difference from Copr build 6490542 to 6490805
Copr build: https://copr.fedorainfracloud.org/coprs/build/6490805 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2242136-kf6-kcolorscheme/fedora-rawhide-x86_64/06490805-kf6-kcolorscheme/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
'Requires: kf6-filesystem' is missing (I presume that is necessary). With that fixed, this package is approved. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [-]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [?]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [?]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: kf6-kcolorscheme-5.240.0^20231001.103550.783d488-1.fc40.x86_64.rpm kf6-kcolorscheme-devel-5.240.0^20231001.103550.783d488-1.fc40.x86_64.rpm kf6-kcolorscheme-debuginfo-5.240.0^20231001.103550.783d488-1.fc40.x86_64.rpm kf6-kcolorscheme-debugsource-5.240.0^20231001.103550.783d488-1.fc40.x86_64.rpm kf6-kcolorscheme-5.240.0^20231001.103550.783d488-1.fc40.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpb6sjlz2b')] checks: 31, packages: 5 kf6-kcolorscheme-devel.x86_64: W: no-documentation kf6-kcolorscheme.src: W: invalid-license LicenseRef-KDE-Accepted-LGPL kf6-kcolorscheme.x86_64: W: invalid-license LicenseRef-KDE-Accepted-LGPL kf6-kcolorscheme-debuginfo.x86_64: W: invalid-license LicenseRef-KDE-Accepted-LGPL kf6-kcolorscheme-debugsource.x86_64: W: invalid-license LicenseRef-KDE-Accepted-LGPL kf6-kcolorscheme-devel.x86_64: W: invalid-license LicenseRef-KDE-Accepted-LGPL 5 packages and 0 specfiles checked; 0 errors, 6 warnings, 0 badness; has taken 0.3 s Rpmlint (debuginfo) ------------------- Checking: kf6-kcolorscheme-debuginfo-5.240.0^20231001.103550.783d488-1.fc40.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpy_5k214f')] checks: 31, packages: 1 kf6-kcolorscheme-debuginfo.x86_64: W: invalid-license LicenseRef-KDE-Accepted-LGPL 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.1 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 4 kf6-kcolorscheme-devel.x86_64: W: no-documentation kf6-kcolorscheme-debuginfo.x86_64: W: invalid-license LicenseRef-KDE-Accepted-LGPL kf6-kcolorscheme.x86_64: W: invalid-license LicenseRef-KDE-Accepted-LGPL kf6-kcolorscheme-devel.x86_64: W: invalid-license LicenseRef-KDE-Accepted-LGPL kf6-kcolorscheme-debugsource.x86_64: W: invalid-license LicenseRef-KDE-Accepted-LGPL 4 packages and 0 specfiles checked; 0 errors, 5 warnings, 0 badness; has taken 0.3 s Source checksums ---------------- https://invent.kde.org/frameworks/kcolorscheme/-/archive/783d4884024d90b41be45f7c23eee2d0a4c730e3/kcolorscheme-783d488.tar.gz : CHECKSUM(SHA256) this package : ecd986bb62d5891a1ecf7737a52c5c5ab5261128bc5d2a7167b8d492408fdee7 CHECKSUM(SHA256) upstream package : ecd986bb62d5891a1ecf7737a52c5c5ab5261128bc5d2a7167b8d492408fdee7 Requires -------- kf6-kcolorscheme (rpmlib, GLIBC filtered): ld-linux-x86-64.so.2()(64bit) libKF6ConfigCore.so.6()(64bit) libKF6ConfigGui.so.6()(64bit) libKF6GuiAddons.so.6()(64bit) libKF6I18n.so.6()(64bit) libQt6Core.so.6()(64bit) libQt6Core.so.6(Qt_6)(64bit) libQt6Core.so.6(Qt_6.5)(64bit) libQt6Gui.so.6()(64bit) libQt6Gui.so.6(Qt_6)(64bit) libc.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.7)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) kf6-kcolorscheme-devel (rpmlib, GLIBC filtered): cmake-filesystem(x86-64) kf6-kcolorscheme(x86-64) libKF6ColorScheme.so.6()(64bit) kf6-kcolorscheme-debuginfo (rpmlib, GLIBC filtered): kf6-kcolorscheme-debugsource (rpmlib, GLIBC filtered): Provides -------- kf6-kcolorscheme: kf6-kcolorscheme kf6-kcolorscheme(x86-64) libKF6ColorScheme.so.6()(64bit) kf6-kcolorscheme-devel: cmake(KF6ColorScheme) cmake(kf6colorscheme) kf6-kcolorscheme-devel kf6-kcolorscheme-devel(x86-64) kf6-kcolorscheme-debuginfo: debuginfo(build-id) kf6-kcolorscheme-debuginfo kf6-kcolorscheme-debuginfo(x86-64) libKF6ColorScheme.so.5.240.0-5.240.0^20231001.103550.783d488-1.fc40.x86_64.debug()(64bit) kf6-kcolorscheme-debugsource: kf6-kcolorscheme-debugsource kf6-kcolorscheme-debugsource(x86-64) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name kf6-kcolorscheme --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: fonts, R, PHP, Ocaml, SugarActivity, Java, Haskell, Python, Perl Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Spec URL: https://farchord.fedorapeople.org/reviews/kf6-kcolorscheme/kf6-kcolorscheme.spec SRPM URL: https://farchord.fedorapeople.org/reviews/kf6-kcolorscheme/kf6-kcolorscheme-5.240.0^20231001.103550.783d488-1.fc39.src.rpm Forgot to add kf6-filesystem to install at runtime
Thank you for the review, Rajeesh! https://pagure.io/releng/fedora-scm-requests/issue/56820
The Pagure repository was created at https://src.fedoraproject.org/rpms/kf6-kcolorscheme