Spec URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-microsoft-dev-tunnels.spec SRPM URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-microsoft-dev-tunnels-0.0.21-1.fc38.src.rpm Description: Dev tunnels allows developers to securely expose local web services to the Internet, control who has access, and easily & debug your web applications from anywhere. Fedora Account System Username: mikelo2
> %global golicenses LICENSE ts/src/connections/LICENSE\\\ > ts/src/contracts/LICENSE ts/src/management/LICENSE ts/* aren't needed I think
Spec URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-microsoft-dev-tunnels.spec SRPM URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-microsoft-dev-tunnels-0.0.21-1.fc38.src.rpm > ts/* aren't needed I think Correct, forgot to remove them.
Created attachment 1992104 [details] The .spec file difference from Copr build 6490157 to 6490241
some tests fail - requires network and authentication https://github.com/microsoft/dev-tunnels/blob/7dec0656c8791637f1ee92d2fb78320a80ffaa30/go/tunnels/manager_test.go#L29 --- FAIL: TestTunnelCreateDelete (0.00s) manager_test.go:53: error sending create tunnel request: error sending request: Post "https://global.rel.tunnels.api.visualstudio.com/api/v1/tunnels": dial tcp: lookup global.rel.tunnels.api.visualstudio.com: Temporary failure in name resolution --- FAIL: TestListTunnels (0.00s) manager_test.go:92: error sending create tunnel request: error sending request: Post "https://global.rel.tunnels.api.visualstudio.com/api/v1/tunnels": dial tcp: lookup global.rel.tunnels.api.visualstudio.com: Temporary failure in name resolution --- FAIL: TestTunnelCreateUpdateDelete (0.00s) manager_test.go:207: error sending create tunnel request: error sending request: Post "https://global.rel.tunnels.api.visualstudio.com/api/v1/tunnels": dial tcp: lookup global.rel.tunnels.api.visualstudio.com: Temporary failure in name resolution --- FAIL: TestTunnelCreateUpdateTwiceDelete (0.00s) manager_test.go:258: error sending create tunnel request: error sending request: Post "https://global.rel.tunnels.api.visualstudio.com/api/v1/tunnels": dial tcp: lookup global.rel.tunnels.api.visualstudio.com: Temporary failure in name resolution --- FAIL: TestTunnelCreateGetDelete (0.00s) manager_test.go:322: error sending create tunnel request: error sending request: Post "https://global.rel.tunnels.api.visualstudio.com/api/v1/tunnels": dial tcp: lookup global.rel.tunnels.api.visualstudio.com: Temporary failure in name resolution --- FAIL: TestTunnelAddPort (0.00s) manager_test.go:373: error sending create tunnel request: error sending request: Post "https://global.rel.tunnels.api.visualstudio.com/api/v1/tunnels?includePorts=true": dial tcp: lookup global.rel.tunnels.api.visualstudio.com: Temporary failure in name resolution --- FAIL: TestTunnelDeletePort (0.00s) manager_test.go:437: error sending create tunnel request: error sending request: Post "https://global.rel.tunnels.api.visualstudio.com/api/v1/tunnels?includePorts=true": dial tcp: lookup global.rel.tunnels.api.visualstudio.com: Temporary failure in name resolution --- FAIL: TestTunnelUpdatePort (0.00s) manager_test.go:520: error sending create tunnel request: error sending request: Post "https://global.rel.tunnels.api.visualstudio.com/api/v1/tunnels?includePorts=true&tokenScopes=manage": dial tcp: lookup global.rel.tunnels.api.visualstudio.com: Temporary failure in name resolution --- FAIL: TestTunnelListPorts (0.00s) manager_test.go:620: error sending create tunnel request: error sending request: Post "https://global.rel.tunnels.api.visualstudio.com/api/v1/tunnels?includePorts=true": dial tcp: lookup global.rel.tunnels.api.visualstudio.com: Temporary failure in name resolution --- FAIL: TestTunnelEndpoints (0.00s) manager_test.go:709: error sending create tunnel request: error sending request: Post "https://global.rel.tunnels.api.visualstudio.com/api/v1/tunnels?tokenScopes=manage&tokenScopes=manage%!A(MISSING)ports&tokenScopes=host": dial tcp: lookup global.rel.tunnels.api.visualstudio.com: Temporary failure in name resolution
Spec URL: https://mikel.olasagasti.info/tmp/fedora//tmp/golang-github-microsoft-dev-tunnels.spec SRPM URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-microsoft-dev-tunnels-0.0.21-1.fc38.src.rpm Forgot to skipped those tests, should be OK now.
Created attachment 1992105 [details] The .spec file difference from Copr build 6490241 to 6490276
Golang Package Review ============== This package was generated using go2rpm, which simplifies the review. Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated - [x] The specfile is sane. - [x] The latest version is packaged or packaging an earlier version is justified. - [x] The License tag reflects the package contents and uses the correct identifiers. - [x] The package builds successfully in mock. - [x] Package is installable (checked by fedora-review --mock-options="--enablerepo=local"). - [x] There are no relevant rpmlint errors. - [x] The package runs tests in %check. - [x] `%goipath` is set correctly. - [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names) - [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default) - [x] The package complies with the Golang and general Packaging Guidelines. Package approved! On import, don't forget to do the following: - [ ] Add the package to release-monitoring.org - [ ] Give go-sig privileges (at least commit) on the package - [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket. Thanks!
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-microsoft-dev-tunnels
FEDORA-2023-398d8a6622 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-398d8a6622
FEDORA-2023-398d8a6622 has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.