Bug 2242199 - Review Request: golang-github-apache-thrift - Thrift Go Software Library
Summary: Review Request: golang-github-apache-thrift - Thrift Go Software Library
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Major Hayden 🤠
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 2237569 (view as bug list)
Depends On:
Blocks: 2240437
TreeView+ depends on / blocked
 
Reported: 2023-10-04 22:28 UTC by W. Michael Petullo
Modified: 2023-11-07 20:27 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-11-07 20:27:51 UTC
Type: ---
Embargoed:
mhayden: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 6490729 to 6492778 (1001 bytes, patch)
2023-10-05 13:49 UTC, Fedora Review Service
no flags Details | Diff

Description W. Michael Petullo 2023-10-04 22:28:27 UTC
Spec URL: https://www.flyn.org/SRPMS/golang-github-apache-thrift.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-github-apache-thrift-0.14.1-7.fc39.src.rpm
Description: Thrift Go Software Library
Fedora Account System Username: mikep

Comment 1 W. Michael Petullo 2023-10-04 22:29:53 UTC
I would like to maintain this package and thus bring it out of retirement. I made no changes to the last version prior to its retirement.

Comment 2 Aaron Rainbolt 2023-10-04 23:15:05 UTC
This is not an official review, and is very far from thorough. I just wanted to get some skills doing reviews and thought I could help out.

* This package is still using an old-style license abbreviation in the License field. This should be updated. "ASL 2.0" -> "Apache-2.0"

* There's a possible redundancy in the spec file:

> Version:      0.14.1
> %global tag   0.14.1

I think you can drop "%global tag" - it has the exact same value as the Version field, and according to https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/, "You first specify either a Version, tag or commit in the header." So I think Version will work in lieu of "%global tag".

Comment 3 Dominik 'Rathann' Mierzejewski 2023-10-05 13:26:16 UTC
(In reply to Aaron Rainbolt from comment #2)
> This is not an official review, and is very far from thorough. I just wanted
> to get some skills doing reviews and thought I could help out.
> 
> * This package is still using an old-style license abbreviation in the
> License field. This should be updated. "ASL 2.0" -> "Apache-2.0"

That is a MUST currently. Also, the submitter should do a full license review
of the source and check if the field is correct and if there are any
differently-licensed sources included as well. If yes, it must be reflected
in the License: field.

Comment 4 Dominik 'Rathann' Mierzejewski 2023-10-05 13:37:37 UTC
(In reply to W. Michael Petullo from comment #1)
> I would like to maintain this package and thus bring it out of retirement. I
> made no changes to the last version prior to its retirement.

That will not do, please package the latest version (0.19.0).

Comment 5 W. Michael Petullo 2023-10-05 13:44:28 UTC
Spec URL: https://www.flyn.org/SRPMS/golang-github-apache-thrift.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-github-apache-thrift-0.19.0-1.fc39.src.rpm

- Update to 0.19.0
- Use SPDX license nomenclature
- Remove tag, which is not used in this release

Comment 6 Fedora Review Service 2023-10-05 13:49:54 UTC
Created attachment 1992257 [details]
The .spec file difference from Copr build 6490729 to 6492778

Comment 7 Major Hayden 🤠 2023-11-02 21:13:49 UTC
*** Bug 2237569 has been marked as a duplicate of this bug. ***

Comment 8 Major Hayden 🤠 2023-11-02 21:17:40 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======

No issues found here. It might be nice to use %autorelease and %autochangelog when updating to the next version. 😉

PACKAGE APPROVED! ✅


===== MUST items =====

C/C++:
[-]: Provides: bundled(gnulib) in place as required.
     Note: Sources not installed
[-]: Package does not contain kernel modules.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
     Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: There is no build directory. Running licensecheck on vanilla
     upstream sources. Licenses found: "Unknown or generated", "*No
     copyright* Apache License 2.0", "Apache License 2.0", "FSF All
     Permissive License", "FSF Unlimited License (with License Retention)",
     "*No copyright* MIT License Apache License 2.0", "BSD 2-Clause
     License", "GNU Lesser General Public License, Version 2.1", "MIT
     License", "Boost Software License 1.0", "FSF All Permissive License
     Apache License 2.0". 339 files have unknown license. Detailed output
     of licensecheck in /var/lib/copr-rpmbuild/results/golang-github-
     apache-thrift/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
     Note: Especially check following dirs for bundled code: /var/lib/copr-
     rpmbuild/results/golang-github-apache-thrift/upstream-
     unpacked/Source0/thrift-0.19.0/lib/py/src/ext, /var/lib/copr-
     rpmbuild/results/golang-github-apache-thrift/upstream-
     unpacked/Source0/thrift-0.19.0/lib/php/src/ext, /var/lib/copr-
     rpmbuild/results/golang-github-apache-thrift/upstream-
     unpacked/Source0/thrift-0.19.0/lib/erl/include, /var/lib/copr-
     rpmbuild/results/golang-github-apache-thrift/upstream-
     unpacked/Source0/thrift-0.19.0/lib/rb/ext
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 14344 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[!]: Reviewer should test that the package builds in mock.
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang-
     github-apache-thrift-devel , compat-golang-apache-thrift-devel
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.

Comment 9 W. Michael Petullo 2023-11-03 00:25:44 UTC
https://pagure.io/releng/issue/11759


Note You need to log in before you can comment on or make changes to this bug.