Spec URL: https://blinxen.fedorapeople.org/rust-gix/rust-gix.spec SRPM URL: https://blinxen.fedorapeople.org/rust-gix/rust-gix-0.53.1-1.fc40.src.rpm Description: Interact with git repositories just like git would. Fedora Account System Username: blinxen
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=107099800
Package looks good to me, with one exception: The changes in the manually written patch are a bit confusing to me, and look like there's been a mistake. 1. Removing "max-performance-safe" from the "default" features should not be necessary? The "max-performance" feature is dropped, but not "max-performance-safe" (maybe this happened by mistaking the names?), so "max-performance-safe" should remain part of the "default" feature set. 2. Additionally, I think "max-performance" feature could be kept as well. I assume that you dropped it because "gix-features/zlib-ng" is not available? I would keep "max-performance" feature and just remove the "gix-features/zlib-ng" feature from it, which should work just as well.
> maybe this happened by mistaking the names? Yeah, was removed by mistake :D > I would keep "max-performance" feature and just remove the "gix-features/zlib-ng" feature from it, which should work just as well I re-added the feature and removed "gix-features/zlib-ng". Links to the updated files: Spec URL: https://blinxen.fedorapeople.org/rust-gix/rust-gix.spec SRPM URL: https://blinxen.fedorapeople.org/rust-gix/rust-gix-0.53.1-1.fc40.src.rpm
Thanks for the update, looks good to me! === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass ! latest version of the crate is packaged (with explanation) - license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora - license files are included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-gix
FEDORA-2023-967f22e530 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-967f22e530
FEDORA-2023-967f22e530 has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.