Bug 2242672 - Review Request: kf6-kconfigwidgets - KDE Frameworks 6 Tier 3 addon for creating configuration dialogs
Summary: Review Request: kf6-kconfigwidgets - KDE Frameworks 6 Tier 3 addon for creati...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kf6-reviews
TreeView+ depends on / blocked
 
Reported: 2023-10-07 23:14 UTC by Steve Cossette
Modified: 2023-10-10 16:23 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-10-08 21:14:30 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Steve Cossette 2023-10-07 23:14:02 UTC
Spec URL: https://farchord.fedorapeople.org/reviews/kf6-kconfigwidgets/kf6-kconfigwidgets.spec
SRPM URL: https://farchord.fedorapeople.org/reviews/kf6-kconfigwidgets/kf6-kconfigwidgets-5.240.0^20231003.053220.dd41bb4-1.fc39.src.rpm
Description: KConfigWidgets provides easy-to-use classes to create configuration dialogs, as well as a set of widgets which uses KConfig to store their settings.
Fedora Account System Username: farchord

Comment 1 Neal Gompa 2023-10-08 20:25:04 UTC
Review notes:

* Package follows Fedora Packaging Guidelines
* Package builds and installs
* Package licensing is correctly handled
* No serious issues from rpmlint

Note, apparently "%{_datadir}/locale/tok" is an un-owned directory. Adding "%dir %{_datadir}/locale/tok" to the base package would fix this.

PACKAGE APPROVED.

Comment 2 Steve Cossette 2023-10-08 21:12:11 UTC
Thank you for the review, Neal

https://pagure.io/releng/fedora-scm-requests/issue/56872

Comment 3 Fedora Admin user for bugzilla script actions 2023-10-08 21:12:23 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/kf6-kconfigwidgets


Note You need to log in before you can comment on or make changes to this bug.