Bug 2242733 - Review Request: kf6-kpackage - KDE Frameworks 6 Tier 2 library to load and install packages as plugins
Summary: Review Request: kf6-kpackage - KDE Frameworks 6 Tier 2 library to load and in...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL: https://invent.kde.org/frameworks/%{f...
Whiteboard:
Depends On:
Blocks: kf6-reviews
TreeView+ depends on / blocked
 
Reported: 2023-10-08 14:30 UTC by Steve Cossette
Modified: 2023-10-10 16:23 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-10-08 21:14:49 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Steve Cossette 2023-10-08 14:30:01 UTC
Spec URL: https://farchord.fedorapeople.org/reviews/kf6-kpackage/kf6-kpackage.spec
SRPM URL: https://farchord.fedorapeople.org/reviews/kf6-kpackage/kf6-kpackage-5.240.0^20231003.152541.40b9c7e-1.fc39.src.rpm
Description: KDE Frameworks 6 Tier 2 library to load and install non-binary packages as if they were plugins.
Fedora Account Services Username: farchord

Comment 1 Fedora Review Service 2023-10-08 14:41:02 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6506149
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2242733-kf6-kpackage/fedora-rawhide-x86_64/06506149-kf6-kpackage/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Neal Gompa 2023-10-08 20:06:45 UTC
Review notes:

* Package follows Fedora Packaging Guidelines
* Package builds and installs
* Package licensing is correctly handled
* No serious issues from rpmlint

Note: Please add "Requires: kf6-filesystem" to the base package on import.

PACKAGE APPROVED.

Comment 3 Steve Cossette 2023-10-08 21:13:48 UTC
Thank you for the review, Neal

https://pagure.io/releng/fedora-scm-requests/issue/56874

Comment 4 Fedora Admin user for bugzilla script actions 2023-10-08 21:13:55 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/kf6-kpackage


Note You need to log in before you can comment on or make changes to this bug.