Spec URL: https://decathorpe.fedorapeople.org/rust-async-signal.spec SRPM URL: https://decathorpe.fedorapeople.org/rust-async-signal-0.2.3-1.fc39.src.rpm Description: Async signal handling. Fedora Account System Username: decathorpe
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=107242908
Copr build: https://copr.fedorainfracloud.org/coprs/build/6506511 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2242779-rust-async-signal/fedora-rawhide-x86_64/06506511-rust-async-signal/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://decathorpe.fedorapeople.org/rust-async-signal.spec SRPM URL: https://decathorpe.fedorapeople.org/rust-async-signal-0.2.4-1.fc39.src.rpm Updated to version 0.2.4.
Created attachment 1994510 [details] The .spec file difference from Copr build 6506511 to 6544988
Copr build: https://copr.fedorainfracloud.org/coprs/build/6544988 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2242779-rust-async-signal/fedora-rawhide-x86_64/06544988-rust-async-signal/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (Apache-2.0 OR MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === I haven't reviewed a Rust crate before, so I copied the template you use for them. Let me know if I should be doing the full checklist from the guidelines instead.
Thanks for the review! This is fine, assuming you checked everything in the checklist.
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-async-signal
Imported and built: https://bodhi.fedoraproject.org/updates/FEDORA-2023-b58d6444da