Spec URL: https://jjames.fedorapeople.org/ocaml-ptime/ocaml-ptime.spec SRPM URL: https://jjames.fedorapeople.org/ocaml-ptime/ocaml-ptime-1.1.0-1.fc40.src.rpm Fedora Account System Username: jjames Description: Ptime provides platform-independent POSIX time support in pure OCaml. It provides a type to represent a well-defined range of POSIX timestamps with picosecond precision, conversion with date-time values, conversion with RFC 3339 timestamps (https://datatracker.ietf.org/doc/html/rfc3339) and pretty printing to a human-readable, locale-independent representation. The additional Ptime_clock library provides access to a system POSIX clock and to the system's current time zone offset. Ptime is not a calendar library.
Copr build: https://copr.fedorainfracloud.org/coprs/build/6509461 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2242903-ocaml-ptime/fedora-rawhide-x86_64/06509461-ocaml-ptime/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ ===== MUST items ===== C/C++: [-]: Provides: bundled(gnulib) in place as required. [-]: Package does not contain kernel modules. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. The "unversioned so-files" are OCaml objects. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ x]: License field in the package spec file matches the actual license. Note: Cannot run licensecheck: Command 'licensecheck -r /var/lib/mock/fedora- rawhide-x86_64/root/builddir/build/BUILD/ptime-1.1.0' returned non- zero exit status 255. I checked the license of the sources manually, and it's ISC. [x]: License file installed when any subpackage combination is installed. [-]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [-]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 4770 bytes in 2 files. [x]: Packages must not store files under /srv, /opt or /usr/local Ocaml: [x]: This should never happen ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. Did not test. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. Upstream doesn't seem to publish signatures. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [-]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: ocaml-ptime-1.1.0-1.fc40.x86_64.rpm ocaml-ptime-devel-1.1.0-1.fc40.x86_64.rpm ocaml-ptime-debuginfo-1.1.0-1.fc40.x86_64.rpm ocaml-ptime-debugsource-1.1.0-1.fc40.x86_64.rpm ocaml-ptime-1.1.0-1.fc40.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpimim2d6_')] checks: 31, packages: 5 ocaml-ptime-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/ocaml/ptime/clock/os/libptime_clock_stubs.a ocaml-ptime-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/ocaml/ptime/clock/os/ptime_clock.a ocaml-ptime-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/ocaml/ptime/ptime.a ocaml-ptime-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/ocaml/ptime/top/ptime_top.a ocaml-ptime.x86_64: E: shared-library-without-dependency-information /usr/lib64/ocaml/ptime/top/ptime_top.cmxs ocaml-ptime.x86_64: W: library-not-linked-against-libc /usr/lib64/ocaml/ptime/ptime.cmxs ^^ This is fine, just OCaml objects. ocaml-ptime-devel.x86_64: W: no-documentation There is documentation inside the ptime.mli file. ocaml-ptime.x86_64: W: devel-file-in-non-devel-package /usr/lib64/ocaml/ptime/ptime_top_init.ml This probably should go into the -devel subpackage? Or be removed during the %install? Rpmlint (debuginfo) ------------------- Checking: ocaml-ptime-debuginfo-1.1.0-1.fc40.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpmf_3ehlz')] checks: 31, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.1 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 4 ocaml-ptime.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/ptime/clock/os/ptime_clock.cmxs caml_state (/usr/lib64/ocaml/ptime/clock/os/ptime_clock.cmxs) ocaml-ptime.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/ptime/clock/os/ptime_clock.cmxs caml_c_call (/usr/lib64/ocaml/ptime/clock/os/ptime_clock.cmxs) ocaml-ptime.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/ptime/clock/os/ptime_clock.cmxs caml_alloc (/usr/lib64/ocaml/ptime/clock/os/ptime_clock.cmxs) ocaml-ptime.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/ptime/clock/os/ptime_clock.cmxs caml_copy_int64 (/usr/lib64/ocaml/ptime/clock/os/ptime_clock.cmxs) ocaml-ptime.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/ptime/clock/os/ptime_clock.cmxs caml_modify (/usr/lib64/ocaml/ptime/clock/os/ptime_clock.cmxs) ocaml-ptime.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/ptime/clock/os/ptime_clock.cmxs caml_bad_caml_state (/usr/lib64/ocaml/ptime/clock/os/ptime_clock.cmxs) ocaml-ptime.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/ptime/clock/os/ptime_clock.cmxs caml_copy_string (/usr/lib64/ocaml/ptime/clock/os/ptime_clock.cmxs) ocaml-ptime.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/ptime/clock/os/ptime_clock.cmxs caml_raise_sys_error (/usr/lib64/ocaml/ptime/clock/os/ptime_clock.cmxs) ocaml-ptime.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/ptime/ptime.cmxs camlStdlib__Format.anon_fn$5bformat.ml$3a1425$2c27$2d$2d33$5d_5342_closure (/usr/lib64/ocaml/ptime/ptime.cmxs) ocaml-ptime.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/ptime/ptime.cmxs caml_exn_Division_by_zero (/usr/lib64/ocaml/ptime/ptime.cmxs) ocaml-ptime.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/ptime/ptime.cmxs caml_modf_float (/usr/lib64/ocaml/ptime/ptime.cmxs) ocaml-ptime.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/ptime/ptime.cmxs caml_obj_dup (/usr/lib64/ocaml/ptime/ptime.cmxs) ocaml-ptime.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/ptime/ptime.cmxs caml_int64_ops (/usr/lib64/ocaml/ptime/ptime.cmxs) ocaml-ptime.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/ptime/ptime.cmxs caml_ml_array_bound_error (/usr/lib64/ocaml/ptime/ptime.cmxs) ocaml-ptime.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/ptime/ptime.cmxs camlStdlib__Format.pp_print_int_1776 (/usr/lib64/ocaml/ptime/ptime.cmxs) ocaml-ptime.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/ptime/ptime.cmxs camlStdlib__Bytes.sub_332 (/usr/lib64/ocaml/ptime/ptime.cmxs) ocaml-ptime.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/ptime/ptime.cmxs camlCamlinternalFormat.bufput_acc_6599 (/usr/lib64/ocaml/ptime/ptime.cmxs) ocaml-ptime.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/ptime/ptime.cmxs camlStdlib__Format.sprintf_5506 (/usr/lib64/ocaml/ptime/ptime.cmxs) ocaml-ptime.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/ptime/ptime.cmxs caml_call_gc (/usr/lib64/ocaml/ptime/ptime.cmxs) ocaml-ptime.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/ptime/ptime.cmxs caml_call_realloc_stack (/usr/lib64/ocaml/ptime/ptime.cmxs) ocaml-ptime.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/ptime/ptime.cmxs caml_int64_of_float_unboxed (/usr/lib64/ocaml/ptime/ptime.cmxs) ocaml-ptime.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/ptime/ptime.cmxs camlStdlib__Printf.bprintf_132 (/usr/lib64/ocaml/ptime/ptime.cmxs) ocaml-ptime.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/ptime/ptime.cmxs caml_c_call (/usr/lib64/ocaml/ptime/ptime.cmxs) ocaml-ptime.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/ptime/ptime.cmxs caml_int64_to_float_unboxed (/usr/lib64/ocaml/ptime/ptime.cmxs) ocaml-ptime.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/ptime/ptime.cmxs camlStdlib__Format.asprintf_5556 (/usr/lib64/ocaml/ptime/ptime.cmxs) ocaml-ptime.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/ptime/ptime.cmxs camlStdlib.invalid_arg_337 (/usr/lib64/ocaml/ptime/ptime.cmxs) ocaml-ptime.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/ptime/ptime.cmxs camlStdlib__Format.kfprintf_5271 (/usr/lib64/ocaml/ptime/ptime.cmxs) ocaml-ptime.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/ptime/ptime.cmxs camlStdlib__Buffer.create_122 (/usr/lib64/ocaml/ptime/ptime.cmxs) ocaml-ptime.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/ptime/ptime.cmxs caml_fresh_oo_id (/usr/lib64/ocaml/ptime/ptime.cmxs) ocaml-ptime.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/ptime/ptime.cmxs camlStdlib.$40_dps_647 (/usr/lib64/ocaml/ptime/ptime.cmxs) ocaml-ptime.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/ptime/ptime.cmxs caml_initialize (/usr/lib64/ocaml/ptime/ptime.cmxs) ocaml-ptime.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/ptime/ptime.cmxs caml_reraise_exn (/usr/lib64/ocaml/ptime/ptime.cmxs) ocaml-ptime.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/ptime/ptime.cmxs camlCamlinternalFormat.make_printf_5097 (/usr/lib64/ocaml/ptime/ptime.cmxs) ocaml-ptime.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/ptime/ptime.cmxs caml_raise_exn (/usr/lib64/ocaml/ptime/ptime.cmxs) ocaml-ptime.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/stublibs/dllptime_clock_stubs.so caml_state (/usr/lib64/ocaml/stublibs/dllptime_clock_stubs.so) ocaml-ptime.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/stublibs/dllptime_clock_stubs.so caml_alloc (/usr/lib64/ocaml/stublibs/dllptime_clock_stubs.so) ocaml-ptime.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/stublibs/dllptime_clock_stubs.so caml_copy_int64 (/usr/lib64/ocaml/stublibs/dllptime_clock_stubs.so) ocaml-ptime.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/stublibs/dllptime_clock_stubs.so caml_modify (/usr/lib64/ocaml/stublibs/dllptime_clock_stubs.so) ocaml-ptime.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/stublibs/dllptime_clock_stubs.so caml_bad_caml_state (/usr/lib64/ocaml/stublibs/dllptime_clock_stubs.so) ocaml-ptime.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/stublibs/dllptime_clock_stubs.so caml_copy_string (/usr/lib64/ocaml/stublibs/dllptime_clock_stubs.so) ocaml-ptime.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/stublibs/dllptime_clock_stubs.so caml_raise_sys_error (/usr/lib64/ocaml/stublibs/dllptime_clock_stubs.so) These seem to be internal OCaml symbols which should be resolved when the final program gets built. ocaml-ptime-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/ocaml/ptime/clock/os/libptime_clock_stubs.a ocaml-ptime-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/ocaml/ptime/clock/os/ptime_clock.a ocaml-ptime-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/ocaml/ptime/ptime.a ocaml-ptime-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/ocaml/ptime/top/ptime_top.a ocaml-ptime.x86_64: E: shared-library-without-dependency-information /usr/lib64/ocaml/ptime/top/ptime_top.cmxs ocaml-ptime.x86_64: W: library-not-linked-against-libc /usr/lib64/ocaml/ptime/ptime.cmxs These are OCaml objects. ocaml-ptime-devel.x86_64: W: no-documentation Fine, see note above. ocaml-ptime.x86_64: W: devel-file-in-non-devel-package /usr/lib64/ocaml/ptime/ptime_top_init.ml Probably should be put in -devel or removed. Unversioned so-files -------------------- ocaml-ptime: /usr/lib64/ocaml/stublibs/dllptime_clock_stubs.so Source checksums ---------------- https://erratique.ch/software/ptime/releases/ptime-1.1.0.tbz : CHECKSUM(SHA256) this package : cbf5b15454fb27105e2c334023e1e11d8f939d7178870f5cbe8ed26df7013eb1 CHECKSUM(SHA256) upstream package : cbf5b15454fb27105e2c334023e1e11d8f939d7178870f5cbe8ed26df7013eb1 Requires -------- ocaml-ptime (rpmlib, GLIBC filtered): ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libm.so.6()(64bit) ocaml(CamlinternalFormatBasics) ocaml(CamlinternalLazy) ocaml(Ptime) ocaml(Stdlib) ocaml(Stdlib__Array) ocaml(Stdlib__Buffer) ocaml(Stdlib__Char) ocaml(Stdlib__Digest) ocaml(Stdlib__Domain) ocaml(Stdlib__Either) ocaml(Stdlib__Format) ocaml(Stdlib__Hashtbl) ocaml(Stdlib__Int32) ocaml(Stdlib__Int64) ocaml(Stdlib__Lazy) ocaml(Stdlib__Lexing) ocaml(Stdlib__Map) ocaml(Stdlib__Obj) ocaml(Stdlib__Printf) ocaml(Stdlib__Seq) ocaml(Stdlib__Set) ocaml(Stdlib__String) ocaml(Stdlib__Sys) ocaml(Stdlib__Uchar) rtld(GNU_HASH) ocaml-ptime-devel (rpmlib, GLIBC filtered): ocaml(CamlinternalFormatBasics) ocaml(CamlinternalLazy) ocaml(Ptime) ocaml(Stdlib) ocaml(Stdlib__Array) ocaml(Stdlib__Buffer) ocaml(Stdlib__Char) ocaml(Stdlib__Digest) ocaml(Stdlib__Domain) ocaml(Stdlib__Either) ocaml(Stdlib__Format) ocaml(Stdlib__Hashtbl) ocaml(Stdlib__Int32) ocaml(Stdlib__Int64) ocaml(Stdlib__Lazy) ocaml(Stdlib__Lexing) ocaml(Stdlib__Map) ocaml(Stdlib__Obj) ocaml(Stdlib__Printf) ocaml(Stdlib__Seq) ocaml(Stdlib__Set) ocaml(Stdlib__String) ocaml(Stdlib__Sys) ocaml(Stdlib__Uchar) ocaml-ptime(x86-64) ocamlx(CamlinternalFormat) ocamlx(Ptime) ocamlx(Stdlib) ocamlx(Stdlib__Buffer) ocamlx(Stdlib__Bytes) ocamlx(Stdlib__Format) ocamlx(Stdlib__Int64) ocamlx(Stdlib__Printf) ocamlx(Toploop) ocaml-ptime-debuginfo (rpmlib, GLIBC filtered): ocaml-ptime-debugsource (rpmlib, GLIBC filtered): Provides -------- ocaml-ptime: ocaml(Ptime) ocaml(Ptime_clock) ocaml(Ptime_top) ocaml-ptime ocaml-ptime(x86-64) ocaml-ptime-devel: ocaml(Ptime) ocaml(Ptime_clock) ocaml(Ptime_top) ocaml-ptime-devel ocaml-ptime-devel(x86-64) ocamlx(Ptime) ocamlx(Ptime_clock) ocamlx(Ptime_top) ocaml-ptime-debuginfo: debuginfo(build-id) ocaml-ptime-debuginfo ocaml-ptime-debuginfo(x86-64) ocaml-ptime-debugsource: ocaml-ptime-debugsource ocaml-ptime-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2242903 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++, Ocaml Disabled plugins: R, PHP, Python, fonts, Java, Perl, SugarActivity, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
There are one or two *.ml files in the ocaml-ptime package that might be moved into -devel or deleted in %install. However the package is essentially fine, so: *********** Reviewed and approved by rjones ***********
Thank you for the review, Rich! (In reply to Richard W.M. Jones from comment #2) > ocaml-ptime.x86_64: W: devel-file-in-non-devel-package > /usr/lib64/ocaml/ptime/ptime_top_init.ml > > This probably should go into the -devel subpackage? Or be removed > during the %install? Actually, files with names of the form <module>_top_init.ml have to go into the main package for the top level to work. Maybe using the top level should be considered a "devel" sort of thing to do. I'm not sure. But you don't need any other devel files for the top level to work, so I figured these should go into the main package. (And note that the *_top_init.ml files are typically not compiled.) If you look at the ocaml package, the ocaml_files.py file has a function named "is_devel_file", used to determine whether files should go into the main package or the devel package. I put an explicit exemption in there for *_top_init.ml files for this reason.
The Pagure repository was created at https://src.fedoraproject.org/rpms/ocaml-ptime
FEDORA-2023-258f8e7407 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-258f8e7407
FEDORA-2023-258f8e7407 has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
(In reply to Jerry James from comment #4) > (In reply to Richard W.M. Jones from comment #2) > > This probably should go into the -devel subpackage? Or be removed > > during the %install? > > Actually, files with names of the form <module>_top_init.ml have to go into > the main package for the top level to work. Maybe using the top level > should be considered a "devel" sort of thing to do. I'm not sure. But you > don't need any other devel files for the top level to work, so I figured > these should go into the main package. (And note that the *_top_init.ml > files are typically not compiled.) If you look at the ocaml package, the > ocaml_files.py file has a function named "is_devel_file", used to determine > whether files should go into the main package or the devel package. I put > an explicit exemption in there for *_top_init.ml files for this reason. Oh I see, yes that's fine.