Bug 2243037 - Review Request: kf6-qqc2-desktop-style - QtQuickControls2 style for consistency between QWidget and QML apps
Summary: Review Request: kf6-qqc2-desktop-style - QtQuickControls2 style for consisten...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL: https://invent.kde.org/frameworks/%{f...
Whiteboard:
Depends On: 2242958
Blocks: kf6-reviews
TreeView+ depends on / blocked
 
Reported: 2023-10-10 11:05 UTC by Steve Cossette
Modified: 2023-10-10 16:55 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-10-10 16:55:05 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 6513175 to 6513211 (324 bytes, patch)
2023-10-10 11:27 UTC, Fedora Review Service
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Gitlab fedora/legal fedora-license-data issues 374 0 None opened License review: LicenseRef-KFQF-Accepted-GPL 2023-10-10 11:22:06 UTC

Description Steve Cossette 2023-10-10 11:05:13 UTC
Spec URL: https://farchord.fedorapeople.org/reviews/kf6-qqc2-desktop-style/kf6-qqc2-desktop-style.spec
SRPM URL: https://farchord.fedorapeople.org/reviews/kf6-qqc2-desktop-style/kf6-qqc2-desktop-style-5.240.0^20231010.095318.b5f1e25-1.fc39.src.rpm
Description: This is a style for QtQuickControls 2 that uses QWidget's QStyle for painting, making possible to achieve an higher degree of consistency between QWidget-based and QML-based apps.
Fedora Account System Username: farchord

Comment 1 Fedora Review Service 2023-10-10 11:09:37 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6513175
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2243037-kf6-qqc2-desktop-style/fedora-rawhide-x86_64/06513175-kf6-qqc2-desktop-style/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fedora Review Service 2023-10-10 11:27:22 UTC
Created attachment 1993251 [details]
The .spec file difference from Copr build 6513175 to 6513211

Comment 4 Fedora Review Service 2023-10-10 11:27:24 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6513211
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2243037-kf6-qqc2-desktop-style/fedora-rawhide-x86_64/06513211-kf6-qqc2-desktop-style/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Neal Gompa 2023-10-10 16:11:54 UTC
[fedora-review-service-build]

Comment 6 Fedora Review Service 2023-10-10 16:25:55 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6514182
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2243037-kf6-qqc2-desktop-style/fedora-rawhide-x86_64/06514182-kf6-qqc2-desktop-style/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 7 Neal Gompa 2023-10-10 16:29:43 UTC
Review notes:

* Package follows Fedora Packaging Guidelines
* Package builds and installs
* Package licensing is correctly handled
* No serious issues from rpmlint

PACKAGE APPROVED.

Comment 8 Steve Cossette 2023-10-10 16:53:21 UTC
Thank you for the review, Neal

https://pagure.io/releng/fedora-scm-requests/issue/56938

Comment 9 Fedora Admin user for bugzilla script actions 2023-10-10 16:53:32 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/kf6-qqc2-desktop-style


Note You need to log in before you can comment on or make changes to this bug.