Description of problem:
Client is trying to do a FFU 16.2 to 17.1.
During undercloud leapp upgrade it fails with:
2023-10-10 16:48:51.931 DEBUG    PID: 321278 leapp.workflow.FactsCollection.vdo_conversion_scanner: External command has started: ['/usr/libexec/vdoprepareforlvm', '--check', '/dev/vda']
2023-10-10 16:48:51.945 DEBUG    PID: 321286 leapp.workflow.FactsCollection.vdo_conversion_scanner: External command has finished: ['/usr/libexec/vdoprepareforlvm', '--check', '/dev/vda']
2023-10-10 16:48:51.952 DEBUG    PID: 321278 leapp.workflow.FactsCollection.vdo_conversion_scanner: Process Process-221:
2023-10-10 16:48:51.955 DEBUG    PID: 321278 leapp.workflow.FactsCollection.vdo_conversion_scanner: Traceback (most recent call last):
2023-10-10 16:48:51.956 DEBUG    PID: 321278 leapp.workflow.FactsCollection.vdo_conversion_scanner:   File "/usr/lib64/python3.6/multiprocessing/process.py", line 258, in _bootstrap
2023-10-10 16:48:51.957 DEBUG    PID: 321278 leapp.workflow.FactsCollection.vdo_conversion_scanner:     self.run()
2023-10-10 16:48:51.958 DEBUG    PID: 321278 leapp.workflow.FactsCollection.vdo_conversion_scanner:   File "/usr/lib64/python3.6/multiprocessing/process.py", line 93, in run
2023-10-10 16:48:51.959 DEBUG    PID: 321278 leapp.workflow.FactsCollection.vdo_conversion_scanner:     self._target(*self._args, **self._kwargs)
2023-10-10 16:48:51.960 DEBUG    PID: 321278 leapp.workflow.FactsCollection.vdo_conversion_scanner:   File "/usr/lib/python3.6/site-packages/leapp/repository/actor_definition.py", line 72, in _do_run
2023-10-10 16:48:51.961 DEBUG    PID: 321278 leapp.workflow.FactsCollection.vdo_conversion_scanner:     actor_instance.run(*args, **kwargs)
2023-10-10 16:48:51.962 DEBUG    PID: 321278 leapp.workflow.FactsCollection.vdo_conversion_scanner:   File "/usr/lib/python3.6/site-packages/leapp/actors/__init__.py", line 289, in run
2023-10-10 16:48:51.963 DEBUG    PID: 321278 leapp.workflow.FactsCollection.vdo_conversion_scanner:     self.process(*args)
2023-10-10 16:48:51.964 DEBUG    PID: 321278 leapp.workflow.FactsCollection.vdo_conversion_scanner:   File "/etc/leapp/repos.d/system_upgrade/el8toel9/actors/vdoconversionscanner/actor.py", line 68, in process
2023-10-10 16:48:51.965 DEBUG    PID: 321278 leapp.workflow.FactsCollection.vdo_conversion_scanner:     self.produce(vdoconversionscanner.get_info(storage_info))
2023-10-10 16:48:51.966 DEBUG    PID: 321278 leapp.workflow.FactsCollection.vdo_conversion_scanner:   File "/etc/leapp/repos.d/system_upgrade/el8toel9/actors/vdoconversionscanner/libraries/vdoconversionscanner.py", line 90, in get_info
2023-10-10 16:48:51.967 DEBUG    PID: 321278 leapp.workflow.FactsCollection.vdo_conversion_scanner:     result = _check_vdo_pre_conversion(device)
2023-10-10 16:48:51.968 DEBUG    PID: 321278 leapp.workflow.FactsCollection.vdo_conversion_scanner:   File "/etc/leapp/repos.d/system_upgrade/el8toel9/actors/vdoconversionscanner/libraries/vdoconversionscanner.py", line 30, in _check_vdo_pre_conversion
2023-10-10 16:48:51.969 DEBUG    PID: 321278 leapp.workflow.FactsCollection.vdo_conversion_scanner:     result = run(command, checked=False)
2023-10-10 16:48:51.970 DEBUG    PID: 321278 leapp.workflow.FactsCollection.vdo_conversion_scanner:   File "/usr/lib/python3.6/site-packages/leapp/libraries/stdlib/__init__.py", line 181, in run
2023-10-10 16:48:51.971 DEBUG    PID: 321278 leapp.workflow.FactsCollection.vdo_conversion_scanner:     stdin=stdin, env=env, encoding=encoding)
2023-10-10 16:48:51.972 DEBUG    PID: 321278 leapp.workflow.FactsCollection.vdo_conversion_scanner:   File "/usr/lib/python3.6/site-packages/leapp/libraries/stdlib/call.py", line 217, in _call
2023-10-10 16:48:51.973 DEBUG    PID: 321278 leapp.workflow.FactsCollection.vdo_conversion_scanner:     os.execvpe(command[0], command, env=environ)
2023-10-10 16:48:51.974 DEBUG    PID: 321278 leapp.workflow.FactsCollection.vdo_conversion_scanner:   File "/usr/lib64/python3.6/os.py", line 568, in execvpe
2023-10-10 16:48:51.975 DEBUG    PID: 321278 leapp.workflow.FactsCollection.vdo_conversion_scanner:     _execvpe(file, args, env)
2023-10-10 16:48:51.976 DEBUG    PID: 321278 leapp.workflow.FactsCollection.vdo_conversion_scanner:   File "/usr/lib64/python3.6/os.py", line 583, in _execvpe
2023-10-10 16:48:51.977 DEBUG    PID: 321278 leapp.workflow.FactsCollection.vdo_conversion_scanner:     exec_func(file, *argrest)
2023-10-10 16:48:51.978 DEBUG    PID: 321278 leapp.workflow.FactsCollection.vdo_conversion_scanner: FileNotFoundError: [Errno 2] No such file or directory: '/usr/libexec/vdoprepareforlvm'


His undercloud has lvm.
vdo package is installed but not used/configured.

But the service is running:
● vdo.service -Unit ypbind.service could not be found.
Unit yppasswdd.service could not be found.
Unit ypserv.service could not be found.
Unit ypxfrd.service could not be found.
 VDO volume services
   Loaded: loaded (/usr/lib/systemd/system/vdo.service; enabled; vendor preset: enabled)
   Active: active (exited) since Tue 2023-10-03 17:16:57 UTC; 6 days ago
 Main PID: 1077 (code=exited, status=0/SUCCESS)
    Tasks: 0 (limit: 204312)
   Memory: 0B
   CGroup: /system.slice/vdo.service

I think the detection for vdo is not working as expected here.



Version-Release number of selected component (if applicable):
leapp-0.15.0-1.el8_4.0.3.noarch                             Tue Oct 10 14:24:19 2023
leapp-deps-0.15.0-1.el8_4.0.3.noarch                        Tue Oct 10 14:24:19 2023
leapp-repository-openstack-0.0.12-1.el8ost.noarch           Tue Oct 10 14:24:20 2023
leapp-upgrade-el8toel9-0.17.0-1.el8_4.0.7.noarch            Tue Oct 10 14:24:20 2023
leapp-upgrade-el8toel9-deps-0.17.0-1.el8_4.0.7.noarch       Tue Oct 10 14:24:19 2023
python3-leapp-0.15.0-1.el8_4.0.3.noarch                     Tue Oct 10 14:24:19 2023


How reproducible:
100%

Steps to Reproduce:
1. Try an undercloud 
2.
3.

Actual results:
Leapp upgrade fails.

Expected results:
Leap upgrade succeed.

Additional info: