Bug 2243423 - Review Request: kf6-knotifyconfig - KDE Frameworks 6 Tier 3 module for KNotify configuration
Summary: Review Request: kf6-knotifyconfig - KDE Frameworks 6 Tier 3 module for KNotif...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL: https://invent.kde.org/frameworks/%{f...
Whiteboard:
Depends On:
Blocks: kf6-reviews
TreeView+ depends on / blocked
 
Reported: 2023-10-11 23:29 UTC by Steve Cossette
Modified: 2023-10-12 00:42 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-10-12 00:42:04 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Steve Cossette 2023-10-11 23:29:15 UTC
Spec URL: https://farchord.fedorapeople.org/reviews/kf6-knotifyconfig/kf6-knotifyconfig.spec
SRPM URL: https://farchord.fedorapeople.org/reviews/kf6-knotifyconfig/kf6-knotifyconfig-5.240.0^20231011.024103.4cfd447-1.fc39.src.rpm
Description: KDE Frameworks 6 Tier 3 module for KNotify configuration.
Fedora Account System Username: farchord

Comment 1 Fedora Review Service 2023-10-11 23:32:58 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6518014
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2243423-kf6-knotifyconfig/fedora-rawhide-x86_64/06518014-kf6-knotifyconfig/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Neal Gompa 2023-10-12 00:02:50 UTC
Review notes:

* Package follows Fedora Packaging Guidelines
* Package builds and installs
* Package licensing is correctly handled
* No serious issues from rpmlint

This needs "Requires: kf6-filesystem" on the base package added, please do so on import.

PACKAGE APPROVED.

Comment 3 Steve Cossette 2023-10-12 00:31:39 UTC
Thank you for the review, Neal

https://pagure.io/releng/fedora-scm-requests/issue/56970

Comment 4 Fedora Admin user for bugzilla script actions 2023-10-12 00:31:50 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/kf6-knotifyconfig


Note You need to log in before you can comment on or make changes to this bug.