Bug 2243676 - Review Request: kf6-krunner - KDE Frameworks 6 Tier 3 solution with parallelized query system
Summary: Review Request: kf6-krunner - KDE Frameworks 6 Tier 3 solution with paralleli...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL: https://invent.kde.org/frameworks/%{f...
Whiteboard:
Depends On:
Blocks: kf6-reviews
TreeView+ depends on / blocked
 
Reported: 2023-10-12 14:07 UTC by Steve Cossette
Modified: 2023-10-12 15:37 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-10-12 15:37:43 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Steve Cossette 2023-10-12 14:07:33 UTC
Spec URL: https://farchord.fedorapeople.org/reviews/kf6-krunner/kf6-krunner.spec
SRPM URL: https://farchord.fedorapeople.org/reviews/kf6-krunner/kf6-krunner-5.240.0^20231011.163529.94c7b49-1.fc39.src.rpm
Description: KRunner provides a parallelized query system extendable via plugins.
Fedora Account Services Username: farchord

Comment 1 Steve Cossette 2023-10-12 14:14:15 UTC
For this one, the original kf5 package seems to require kf5-plasma-devel on the devel subpackage which seemed strange to me as it's not required to build. So this might not properly work on installation until kf6-plasma is added (Which is incoming). Will (maybe?) need to readd that then.

Comment 2 Fedora Review Service 2023-10-12 14:21:26 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6520033
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2243676-kf6-krunner/fedora-rawhide-x86_64/06520033-kf6-krunner/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Neal Gompa 2023-10-12 15:12:33 UTC
kf5-plasma was dropped from kf5-krunner a year ago, that's why it's unused in kf5-krunner: https://invent.kde.org/frameworks/krunner/-/merge_requests/83
So nothing is wrong with kf6-krunner. :)

Anyway...

Review notes:

* Package follows Fedora Packaging Guidelines
* Package builds and installs
* Package licensing is correctly handled
* No serious issues from rpmlint

PACKAGE APPROVED.

Comment 4 Steve Cossette 2023-10-12 15:22:18 UTC
Thank you for the review, Neal

https://pagure.io/releng/fedora-scm-requests/issue/56982

Comment 5 Fedora Admin user for bugzilla script actions 2023-10-12 15:22:29 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/kf6-krunner


Note You need to log in before you can comment on or make changes to this bug.