Spec URL: http://www.timj.co.uk/linux/specs/php-pear-Console-Color.spec SRPM URL: http://www.timj.co.uk/linux/srpms/php-pear-Console-Color-1.0.1-1.src.rpm Description: The Console_Color class makes it easy to use ANSI color codes when writing CLI-based applications in PHP.
==== REVIEW CHECKLIST ==== - rpmlint output clean - package named according to package naming guidelines - spec file name matches %{name} - package meets packaging guidelines - licensed with open source compatible license - license field matches actual license - source package does not include license text - spec written in American english - spec file is legible - sources match upstream 0ed565fb5b3f3ed2d604053d9e1adce6 Console_Color-1.0.1.tgz - package successfully compiles and builds on FC-6 x86_64 - all build dependencies listed in BR - no locales - no shared libraries - package is not relocatable X package does not own all directories it creates - directories it does not create are pulled in from other packages - no duplicates in %files - file permissions set properly - contains proper %clean section - macro usage consistent - contains code - no large documentation - %doc does not affect runtime - no header files or static libraries - no pkgconfig files - no library files with suffixes - no need for devel subpackage - no libtool archives - not a GUI app - package does not own files or directories owned by other non-pear packages ==== MUST FIX ==== - This package must own the Console directory ==== SHOULD FIX ==== - Consider adding a PHP License text file to %doc
oops, I just realized the Console directory is owned by php-pear, so this package is correct and should *not* own this directory. Ignore the MUST FIX item above. APPROVED
Yes, I specifically avoided owning the Console directory for the reason you cite. Upstream doesn't have a License file but http://pear.php.net/bugs/bug.php?id=9948 is an upstream bug about this. Thanks for your time in doing this review. It will be imported ASAP.
Built in devel (job #26375) and FC-6 (#26443).
Package Change Request ====================== Package Name: php-pear-Console-Color New Branches: el6 Owners: remi
Git done (by process-git-requests).