Spec URL: https://mattia.fedorapeople.org/jsonschema-path/python-jsonschema-path.spec SRPM URL: https://mattia.fedorapeople.org/jsonschema-path/python-jsonschema-path-0.3.1-1.fc40.src.rpm Description: A python library which provides traverse JSON resources like paths and access resources on demand with separate dereferencing accessor layer. Fedora Account System Username: mattia This is a re-review request for renaming the existent python-jsonschema-spec package to the new name, following upstream change. See https://docs.fedoraproject.org/en-US/package-maintainers/Package_Renaming_Process/
I will take this review.
This package is APPROVED. Please take a look at the 2 minor issues below before you check in. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues ====== - Regarding the Obsoletes and Provides, those in the python3 subpackage are correct, but those in the main package are useless. First, there is no binary package named python-jsonschema-spec, so there is nothing to obsolete. Second, this spec file does not generate a main package, so there is no package for the Obsoletes and Provides to go into. I don't think they hurt anything, but they don't help anything either. - Note the strange-permission warning from rpmlint. Make sure the spec file has correct permissions before you check in. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0". 41 files have unknown license. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 3187 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Binary eggs must be removed in %prep [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: python3-jsonschema-path-0.3.1-1.fc40.noarch.rpm python-jsonschema-path-0.3.1-1.fc40.src.rpm ================================================ rpmlint session starts ================================================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpuahnrdkl')] checks: 31, packages: 2 python-jsonschema-path.src: W: strange-permission python-jsonschema-path.spec 600 ================= 2 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.5 s ================= Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/p1c2u/jsonschema-path/archive/0.3.1/jsonschema-path-0.3.1.tar.gz : CHECKSUM(SHA256) this package : 1a852314243ac7d9ba25055f2b105e2b3f30538692e61d2686a1ca3278832bff CHECKSUM(SHA256) upstream package : 1a852314243ac7d9ba25055f2b105e2b3f30538692e61d2686a1ca3278832bff Requires -------- python3-jsonschema-path (rpmlib, GLIBC filtered): (python3.12dist(pathable) < 0.5~~ with python3.12dist(pathable) >= 0.4.1) (python3.12dist(referencing) < 0.31~~ with python3.12dist(referencing) >= 0.28) (python3.12dist(requests) < 3~~ with python3.12dist(requests) >= 2.28.1) python(abi) python3.12dist(pyyaml) Provides -------- python3-jsonschema-path: python-jsonschema-path python3-jsonschema-path python3-jsonschema-spec python3.12-jsonschema-path python3.12dist(jsonschema-path) python3dist(jsonschema-path) Diff spec file in url and in SRPM --------------------------------- --- /home/jamesjer/2244182-python-jsonschema-path/srpm/python-jsonschema-path.spec 2023-10-19 09:38:14.766513641 -0600 +++ /home/jamesjer/2244182-python-jsonschema-path/srpm-unpacked/python-jsonschema-path.spec 2023-10-13 18:00:00.000000000 -0600 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.3.5) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + %global srcname jsonschema-path %global modname jsonschema_path @@ -79,3 +89,4 @@ %changelog -%autochangelog +* Sat Oct 14 2023 Mattia Verga <mattia.verga> - 0.3.1-1 +- Initial release, rename of python-jsonschema-spec Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2244182 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Shell-api, Generic Disabled plugins: fonts, SugarActivity, PHP, C/C++, Perl, Ruby, Haskell, R, Java, Ocaml Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
> - Note the strange-permission warning from rpmlint. Make sure the spec file > has correct permissions before you check in. Drive-by comment: This is a (harmless) artifact of rpmautospec processing. It writes the spec file to a temporary directory with 0x700 permissions, which are inherited by the written file as 0x600. This should be fixed in the future: https://pagure.io/fedora-infra/rpmautospec/issue/301
Ah, good to know. Thanks, Fabio.
While self reviewing the submission by myself, I was also have been hit by a doubt: for Python packages renames I don't think we should use Provides in the new package. Here I'm using `Provides: python3-jsonschema-spec = %{version}`, but whoever installs python3-jsonschema-path will not be able to use `import jsonschema-spec`. So I think I just have to use the `Obsoletes` without `Provides`, right?
Good point. You are right. Please omit the Provides.
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-jsonschema-path
FEDORA-2023-d8477fadad has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-d8477fadad
FEDORA-2023-d8477fadad has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.