Bug 224424 - NFS mishandles dentries during create style operations
NFS mishandles dentries during create style operations
Status: CLOSED ERRATA
Product: Red Hat Enterprise Linux 4
Classification: Red Hat
Component: kernel (Show other bugs)
4.0
All Linux
medium Severity medium
: ---
: ---
Assigned To: Peter Staubach
Brian Brock
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-25 11:55 EST by Peter Staubach
Modified: 2007-11-30 17:07 EST (History)
2 users (show)

See Also:
Fixed In Version: RHBA-2007-0791
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-11-15 11:18:42 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
Proposed patch (520 bytes, patch)
2007-01-25 12:05 EST, Peter Staubach
no flags Details | Diff

  None (edit)
Description Peter Staubach 2007-01-25 11:55:49 EST
Description of problem:

The NFS client can double drop dentries if an error occurs during the
create process.

This problem was discovered by doing code inspection while working
on another bug, 128616 for RHEL-3.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:
Comment 1 Peter Staubach 2007-01-25 12:04:43 EST
The problem is that the NFS client calls a routine called nfs_instantiate()
to instantiate dentries.  This routine will d_drop() the dentry if it can
not instantiate the dentry.  The problem is that the NFS client also needs
to d_drop() the dentry is any other errors occur during the process of
creating a new file, directory, special device, or symbolic link too.

This d_drop() support should only live in one place to avoid the possibility
of calling it incorrectly.
Comment 2 Peter Staubach 2007-01-25 12:05:53 EST
Created attachment 146583 [details]
Proposed patch
Comment 3 RHEL Product and Program Management 2007-01-25 12:11:56 EST
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.
Comment 4 RHEL Product and Program Management 2007-05-22 13:02:07 EDT
This request was evaluated by Red Hat Kernel Team for inclusion in a Red
Hat Enterprise Linux maintenance release, and has moved to bugzilla 
status POST.
Comment 5 Jason Baron 2007-06-25 16:26:24 EDT
committed in stream U6 build 55.12. A test kernel with this patch is available
from http://people.redhat.com/~jbaron/rhel4/
Comment 8 errata-xmlrpc 2007-11-15 11:18:42 EST
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2007-0791.html

Note You need to log in before you can comment on or make changes to this bug.