Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
For bugs related to Red Hat Enterprise Linux 4 product line. The current stable release is 4.9. For Red Hat Enterprise Linux 6 and above, please visit Red Hat JIRA https://issues.redhat.com/secure/CreateIssue!default.jspa?pid=12332745 to report new issues.

Bug 224424

Summary: NFS mishandles dentries during create style operations
Product: Red Hat Enterprise Linux 4 Reporter: Peter Staubach <staubach>
Component: kernelAssignee: Peter Staubach <staubach>
Status: CLOSED ERRATA QA Contact: Brian Brock <bbrock>
Severity: medium Docs Contact:
Priority: medium    
Version: 4.0CC: jlayton, steved
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: RHBA-2007-0791 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-11-15 16:18:42 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Proposed patch none

Description Peter Staubach 2007-01-25 16:55:49 UTC 
Description of problem:

The NFS client can double drop dentries if an error occurs during the
create process.

This problem was discovered by doing code inspection while working
on another bug, 128616 for RHEL-3.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:
Comment 1 Peter Staubach 2007-01-25 17:04:43 UTC 
The problem is that the NFS client calls a routine called nfs_instantiate()
to instantiate dentries.  This routine will d_drop() the dentry if it can
not instantiate the dentry.  The problem is that the NFS client also needs
to d_drop() the dentry is any other errors occur during the process of
creating a new file, directory, special device, or symbolic link too.

This d_drop() support should only live in one place to avoid the possibility
of calling it incorrectly.
Comment 2 Peter Staubach 2007-01-25 17:05:53 UTC 
Created attachment 146583 [details]
Proposed patch
Comment 3 RHEL Program Management 2007-01-25 17:11:56 UTC 
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.
Comment 4 RHEL Program Management 2007-05-22 17:02:07 UTC 
This request was evaluated by Red Hat Kernel Team for inclusion in a Red
Hat Enterprise Linux maintenance release, and has moved to bugzilla 
status POST.
Comment 5 Jason Baron 2007-06-25 20:26:24 UTC 
committed in stream U6 build 55.12. A test kernel with this patch is available
from http://people.redhat.com/~jbaron/rhel4/
Comment 8 errata-xmlrpc 2007-11-15 16:18:42 UTC 
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2007-0791.html