Spec URL: https://farchord.fedorapeople.org/reviews/kosmindoormap/kosmindoormap.spec SRPM URL: https://farchord.fedorapeople.org/reviews/kosmindoormap/kosmindoormap-23.08.2-1.fc39.src.rpm Description: A library and QML component for rendering multi-level OSM indoor maps of for example a (large) train station. Fedora Account System Username: farchord
Copr build: https://copr.fedorainfracloud.org/coprs/build/6528104 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2244302-kosmindoormap/fedora-rawhide-x86_64/06528104-kosmindoormap/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
[fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/6528206 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2244302-kosmindoormap/fedora-rawhide-x86_64/06528206-kosmindoormap/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://farchord.fedorapeople.org/reviews/kosmindoormap/kosmindoormap.spec SRPM URL: https://farchord.fedorapeople.org/reviews/kosmindoormap/kosmindoormap-23.08.2-1.fc39.src.rpm Put some files in the wrong subpackage
Spec URL: https://farchord.fedorapeople.org/reviews/kosmindoormap/kosmindoormap.spec SRPM URL: https://farchord.fedorapeople.org/reviews/kosmindoormap/kosmindoormap-23.08.2-1.fc39.src.rpm Updated %files and spacing
Looked at it locally... Review notes: * Package follows Fedora Packaging Guidelines * Package builds and installs * Package licensing is correctly handled * No serious issues from rpmlint PACKAGE APPROVED.
Thank you for the review, Neal https://pagure.io/releng/fedora-scm-requests/issue/57231
The Pagure repository was created at https://src.fedoraproject.org/rpms/kosmindoormap