Bug 2244365

Description of problem:

We can create multiple neutron ports using the following API:
- https://docs.openstack.org/api-ref/network/v2/index.html?expanded=bulk-create-ports-detail#bulk-create-ports

When one of the ports fails to be created, other ports won't be created as well.
In the following example, "10.0.0.100" is correct IP address while "10.0.1.100" is wrong IP address.
"10.0.1.100" is outside of the subnet and the port creation of this IP address should fail.

~~~
$ token=`openstack token issue -c id -f value`
$ curl -i https://192.168.24.2:13696/v2.0/ports -X POST -H "Content-Type: text/html; charset=UTF-8" -H "X-Auth-Token: $token" -d \
'{
    "ports": [
        {
            "name": "sample_port_1",
            "network_id": "078c5aef-0112-42bf-979e-812560a36846",
            "fixed_ips": [{"ip_address": "10.0.0.100"}] <==============(*) collect IP address
        },
        {
            "name": "sample_port_1",
            "network_id": "078c5aef-0112-42bf-979e-812560a36846",
            "fixed_ips": [{"ip_address": "10.0.1.100"}] <==============(*) wrong IP address. This port will fail to be created.
        }
    ]
}'
HTTP/1.1 400 Bad Request
content-type: application/json
content-length: 166
x-openstack-request-id: req-7693bc70-4745-40e2-91dd-6d4b22d3d548
date: Mon, 16 Oct 2023 05:41:02 GMT

{"NeutronError": {"type": "InvalidIpForNetwork", "message": "IP address 10.0.1.100 is not a valid IP for any of the subnets on the specified network.", "detail": ""}}

  ===> Because 10.0.1.100 is outside of the subnet, bulk port creation fails with 400 error.


(undercloud) [stack@undercloud-0 ~]$ openstack port list |grep -e 10.0.0.100 -e 10.0.1.100 |wc -l 
0

  ===> If one of the ports fails to be created, other ports is not created as well.
~~~


However, only ipamallocations entry is created in the neutron database.

~~~
(undercloud) [stack@undercloud-0 ~]$ sudo podman exec -u root mysql mysql -B ovs_neutron -u root -e "select * from ipamallocations where ip_address = '10.0.0.100'\G;"
*************************** 1. row ***************************
    ip_address: 10.0.0.100
        status: ALLOCATED
ipam_subnet_id: bfa51848-0c4a-4cc6-80a3-3cf1960f0773
~~~


Because the ipamallocations entry exists, subsequent port creation with the IP address will fail.

~~~
(undercloud) [stack@undercloud-0 ~]$ openstack port create --network 078c5aef-0112-42bf-979e-812560a36846 --fixed-ip ip-address=10.0.0.100 test_port
ConflictException: 409: Client Error for url: https://192.168.24.2:13696/v2.0/ports, IP address 10.0.0.100 already allocated in subnet 18844f4f-7d83-4467-88c2-1b7385ac34b5
~~~

Because the port associated with the IP address doesn't exist, we cannot delete the port.
I think we have no choice other than modifying the ipamallocations table manually.
As a workaround, would it be valid and safe to modify the ipamallocations manually?

Because `openstack overcloud node provision` command calls the same API to create a bulk of ports, we can hit the same issue on `openstack overcloud node provision`.


Version-Release number of selected component (if applicable):
RHOSP 17.1

How reproducible:
Steps to Reproduce:
1. Get Keystone token
2. Call the API to create bulk of ports.
   In this API call, one of the create ports should fail while other ports should succeed.
3. The API call fails.
4. No ports are created, but wrong ipamallocations entries are created in the neutron DB.


Actual results:
Wrong ipamallocations entries are created

Expected results:
Wrong ipamallocations entries are not created


Additional information:
The following Launchpad bug says "if one port fails in the driver call, the port is deleted. In this port deletion, the IPAM reservation is deleted too."
https://bugs.launchpad.net/neutron/+bug/1965807
However, actually the IPAM reservation is not deleted.
Is the change of the above Launchpad bug related to this issue?