Spec URL: https://solopasha.fedorapeople.org/reviews/xdg-desktop-portal-hyprland/xdg-desktop-portal-hyprland.spec SRPM URL: https://solopasha.fedorapeople.org/reviews/xdg-desktop-portal-hyprland/xdg-desktop-portal-hyprland-1.2.2-1.fc39.src.rpm Description: xdg-desktop-portal backend for hyprland.
Spec URL: https://solopasha.fedorapeople.org/reviews/xdg-desktop-portal-hyprland/xdg-desktop-portal-hyprland.spec SRPM URL: https://solopasha.fedorapeople.org/reviews/xdg-desktop-portal-hyprland/xdg-desktop-portal-hyprland-1.2.4-1.fc39.src.rpm Update to 1.2.4
Copr build: https://copr.fedorainfracloud.org/coprs/build/6603237 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2244378-xdg-desktop-portal-hyprland/fedora-rawhide-x86_64/06603237-xdg-desktop-portal-hyprland/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://solopasha.fedorapeople.org/reviews/xdg-desktop-portal-hyprland/xdg-desktop-portal-hyprland.spec SRPM URL: https://solopasha.fedorapeople.org/reviews/xdg-desktop-portal-hyprland/xdg-desktop-portal-hyprland-1.2.4-1.fc39.src.rpm Requires: dbus-common
Created attachment 1997656 [details] The .spec file difference from Copr build 6603237 to 6608036
Copr build: https://copr.fedorainfracloud.org/coprs/build/6608036 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2244378-xdg-desktop-portal-hyprland/fedora-rawhide-x86_64/06608036-xdg-desktop-portal-hyprland/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I will take this review.
Sorry, got distracted with a fedora-review bug: bug 2248571. We just need to fix the license field. See below. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - While the BSD-3-Clause license covers most of this distribution, the file protocols/wlr-foreign-toplevel-management-unstable-v1.xml contains a HPND-sell-variant license declaration. Furthermore, in Fedora <= 39, sdbus-cpp is bundled, so its license must be reflected in the License tag as well. That appears to be LGPL-2.1-or-later WITH Qt-LGPL-exception-1.1. The sdbus-cpp package seems to have gotten this wrong. ===== MUST items ===== C/C++: [-]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-Clause License", "*No copyright* BSD 3-Clause License", "NTP License (legal disclaimer) Historical Permission Notice and Disclaimer - sell variant". 50 files have unknown license. [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [!]: Package contains no bundled libraries without FPC exception. sdbus-cpp is bundled on Fedora <= 39. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 584 bytes in 2 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. There is no %check script. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: xdg-desktop-portal-hyprland-1.2.4-1.fc40.x86_64.rpm xdg-desktop-portal-hyprland-debuginfo-1.2.4-1.fc40.x86_64.rpm xdg-desktop-portal-hyprland-debugsource-1.2.4-1.fc40.x86_64.rpm xdg-desktop-portal-hyprland-1.2.4-1.fc40.src.rpm ================================================ rpmlint session starts ================================================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpfdcxz84w')] checks: 31, packages: 4 xdg-desktop-portal-hyprland.src: W: summary-not-capitalized xdg-desktop-portal backend for hyprland xdg-desktop-portal-hyprland.x86_64: W: summary-not-capitalized xdg-desktop-portal backend for hyprland xdg-desktop-portal-hyprland.x86_64: W: no-manual-page-for-binary hyprland-share-picker ================= 4 packages and 0 specfiles checked; 0 errors, 3 warnings, 0 badness; has taken 0.3 s ================= Rpmlint (debuginfo) ------------------- Checking: xdg-desktop-portal-hyprland-debuginfo-1.2.4-1.fc40.x86_64.rpm ================================================ rpmlint session starts ================================================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp64nc9ijf')] checks: 31, packages: 1 ================= 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.1 s ================= Rpmlint (installed packages) ---------------------------- /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3 xdg-desktop-portal-hyprland.x86_64: W: summary-not-capitalized xdg-desktop-portal backend for hyprland xdg-desktop-portal-hyprland.x86_64: W: no-manual-page-for-binary hyprland-share-picker 3 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 0.6 s Source checksums ---------------- https://github.com/Kistler-Group/sdbus-cpp/archive/v1.3.0/sdbus-1.3.0.tar.gz : CHECKSUM(SHA256) this package : d44f59abdd64d8f1ca3af7db58bc6518cb081fc9ff16285c3d75a68f5c073d10 CHECKSUM(SHA256) upstream package : d44f59abdd64d8f1ca3af7db58bc6518cb081fc9ff16285c3d75a68f5c073d10 https://github.com/hyprwm/xdg-desktop-portal-hyprland/archive/v1.2.4/xdg-desktop-portal-hyprland-1.2.4.tar.gz : CHECKSUM(SHA256) this package : dfb1026f9355e78dad8b01e8637b569dc3ae5d5d570e1ac47f016b695ce98f9f CHECKSUM(SHA256) upstream package : dfb1026f9355e78dad8b01e8637b569dc3ae5d5d570e1ac47f016b695ce98f9f Requires -------- xdg-desktop-portal-hyprland (rpmlib, GLIBC filtered): /bin/sh dbus dbus-common grim libQt6Core.so.6()(64bit) libQt6Core.so.6(Qt_6)(64bit) libQt6Core.so.6(Qt_6.6)(64bit) libQt6Gui.so.6()(64bit) libQt6Gui.so.6(Qt_6)(64bit) libQt6Widgets.so.6()(64bit) libQt6Widgets.so.6(Qt_6)(64bit) libc.so.6()(64bit) libdrm.so.2()(64bit) libgbm.so.1()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgcc_s.so.1(GCC_4.3.0)(64bit) libpipewire-0.3.so.0()(64bit) libsdbus-c++.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libwayland-client.so.0()(64bit) qt6-qtwayland rtld(GNU_HASH) slurp xdg-desktop-portal xdg-desktop-portal-hyprland-debuginfo (rpmlib, GLIBC filtered): xdg-desktop-portal-hyprland-debugsource (rpmlib, GLIBC filtered): Provides -------- xdg-desktop-portal-hyprland: xdg-desktop-portal-hyprland xdg-desktop-portal-hyprland(x86-64) xdg-desktop-portal-hyprland-debuginfo: debuginfo(build-id) xdg-desktop-portal-hyprland-debuginfo xdg-desktop-portal-hyprland-debuginfo(x86-64) xdg-desktop-portal-hyprland-debugsource: xdg-desktop-portal-hyprland-debugsource xdg-desktop-portal-hyprland-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2244378 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: Java, Python, Ocaml, SugarActivity, Haskell, R, Perl, fonts, PHP, Ruby Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Spec URL: https://solopasha.fedorapeople.org/reviews/xdg-desktop-portal-hyprland/xdg-desktop-portal-hyprland.spec SRPM URL: https://solopasha.fedorapeople.org/reviews/xdg-desktop-portal-hyprland/xdg-desktop-portal-hyprland-1.2.4-1.fc39.src.rpm Thank you for spotting those
Looks good. This package is APPROVED.
Thank you for the review!
The Pagure repository was created at https://src.fedoraproject.org/rpms/xdg-desktop-portal-hyprland
FEDORA-2023-18ad1b5c2b has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-18ad1b5c2b
FEDORA-2023-18ad1b5c2b has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.