Spec URL: https://download.copr.fedorainfracloud.org/results/gui1ty/extract-msg/fedora-rawhide-x86_64/06529735-extract-msg/extract-msg.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/gui1ty/extract-msg/fedora-rawhide-x86_64/06529735-extract-msg/extract-msg-0.45.0-1.fc40.src.rpm Description: The python package extract_msg automates the extraction of key email data (from, to, cc, date, subject, body) and the email’s attachments. Fedora Account System Username: gui1ty Copr Build: https://copr.fedorainfracloud.org/coprs/gui1ty/extract-msg/build/6529735/
If testing locally please use the Copr repo for building and/or installing since it contains various dependencies which are still pending review. https://copr.fedorainfracloud.org/coprs/gui1ty/extract-msg/
Maxwell's Python Package Review Template ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated - [!] The License tag reflects the package contents and uses the correct identifiers. - [!] The license text is included and marked with %license. NOTE: Files in the project include GPLv3+ headers, but the metadata and LICENSE claims LGPLv3. Can you clarify this with upstream? - [x] The package builds successfully in mock. - [x] The package is installable (checked by fedora-review). - [x] There are no relevant rpmlint errors. - [x] The package runs tests in %check. - [x] The latest version is packaged or packaging an earlier version is justified. - [!] The packager considers avoiding confusing `%foo_name` macros. (Not a blocker) - [!] Libraries: The package name has a `python3-` prefix and uses the canonical project name NOTE: The SRPM should be named python-rtfde and the binary package should be named python3-rftde. - [x] The pyproject macros are used. - [x] The package complies with the Python and general Packaging Guidelines. Other Notes =========== - You should add `%global distprefix %{nil}` so the forge macros don't add .20231015git66780b8 to the disttag. This is not a git snapshot; upstream just doesn't tag releases. - It'd be better to use the `%{...}` syntax when referencing the `%forge*` macros in the specfile. - The doc subpackage should not require the python3-... subpackage. Thanks!
Oops, I meant to leave that last comment on the RTFDE review...
In rawhide python-olefile has been updated to 0.47. That dependency was pinned to version 0.46 in extract-msg. Now olefile is no longer pinned extract-msg once again builds in rawhide: Spec URL: https://download.copr.fedorainfracloud.org/results/gui1ty/extract-msg/fedora-rawhide-x86_64/06737361-extract-msg/extract-msg.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/gui1ty/extract-msg/fedora-rawhide-x86_64/06737361-extract-msg/extract-msg-0.45.0-3.fc40.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/6737576 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2244408-extract-msg/fedora-rawhide-x86_64/06737576-extract-msg/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I'm closing this review requests in favor of maintaining extract-msg and its dependencies in Copr [1]. In the end extract-msg is just a niche package. I would have liked to make it available in Fedora proper, but my time is limited. What's in Copr now is usable. So, I decided to leave that in place and stop pursuing an import into Fedora repositories. Thanks for your time! [1] https://copr.fedorainfracloud.org/coprs/gui1ty/extract-msg/