Spec URL: https://solopasha.fedorapeople.org/reviews/hyprpicker/hyprpicker.spec SRPM URL: https://solopasha.fedorapeople.org/reviews/hyprpicker/hyprpicker-0.1.1-1.fc39.src.rpm Description: A wlroots-compatible Wayland color picker. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=107694098
Copr build: https://copr.fedorainfracloud.org/coprs/build/6542114 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2244782-hyprpicker/fedora-rawhide-x86_64/06542114-hyprpicker/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://solopasha.fedorapeople.org/reviews/hyprpicker/hyprpicker.spec SRPM URL: https://solopasha.fedorapeople.org/reviews/hyprpicker/hyprpicker-0.2.0-1.fc39.src.rpm Update to 0.2.0 Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=108330552
Created attachment 1996221 [details] The .spec file difference from Copr build 6542114 to 6582218
Copr build: https://copr.fedorainfracloud.org/coprs/build/6582218 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2244782-hyprpicker/fedora-rawhide-x86_64/06582218-hyprpicker/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
There are a lot of warnings when running make protocols, is there something wrong with the configuration? Package wlroots was not found in the pkg-config search path. Perhaps you should add the directory containing `wlroots.pc' to the PKG_CONFIG_PATH environment variable Package 'wlroots', required by 'virtual:world', not found /usr/bin/wayland-scanner private-code \ protocols/wlr-layer-shell-unstable-v1.xml wlr-layer-shell-unstable-v1-protocol.c Package wlroots was not found in the pkg-config search path. Perhaps you should add the directory containing `wlroots.pc' to the PKG_CONFIG_PATH environment variable Package 'wlroots', required by 'virtual:world', not found Package wlroots was not found in the pkg-config search path. Perhaps you should add the directory containing `wlroots.pc' to the PKG_CONFIG_PATH environment variable Package 'wlroots', required by 'virtual:world', not found /usr/bin/wayland-scanner client-header \ protocols/wlr-layer-shell-unstable-v1.xml wlr-layer-shell-unstable-v1-protocol.h Package wlroots was not found in the pkg-config search path. Perhaps you should add the directory containing `wlroots.pc' to the PKG_CONFIG_PATH environment variable Package 'wlroots', required by 'virtual:world', not found Package wlroots was not found in the pkg-config search path. Perhaps you should add the directory containing `wlroots.pc' to the PKG_CONFIG_PATH environment variable Package 'wlroots', required by 'virtual:world', not found gcc -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Werror=implicit-function-declaration -Werror=implicit-int -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -I. -DWLR_USE_UNSTABLE -std=c99 -c -o wlr-layer-shell-unstable-v1-protocol.o wlr-layer-shell-unstable-v1-protocol.c Package wlroots was not found in the pkg-config search path. Perhaps you should add the directory containing `wlroots.pc' to the PKG_CONFIG_PATH environment variable Package 'wlroots', required by 'virtual:world', not found Package wlroots was not found in the pkg-config search path. Perhaps you should add the directory containing `wlroots.pc' to the PKG_CONFIG_PATH environment variable Package 'wlroots', required by 'virtual:world', not found /usr/bin/wayland-scanner private-code \ protocols/wlr-screencopy-unstable-v1.xml wlr-screencopy-unstable-v1-protocol.c Package wlroots was not found in the pkg-config search path. Perhaps you should add the directory containing `wlroots.pc' to the PKG_CONFIG_PATH environment variable Package 'wlroots', required by 'virtual:world', not found Package wlroots was not found in the pkg-config search path. Perhaps you should add the directory containing `wlroots.pc' to the PKG_CONFIG_PATH environment variable Package 'wlroots', required by 'virtual:world', not found /usr/bin/wayland-scanner client-header \ protocols/wlr-screencopy-unstable-v1.xml wlr-screencopy-unstable-v1-protocol.h Package wlroots was not found in the pkg-config search path. Perhaps you should add the directory containing `wlroots.pc' to the PKG_CONFIG_PATH environment variable Package 'wlroots', required by 'virtual:world', not found Package wlroots was not found in the pkg-config search path. Perhaps you should add the directory containing `wlroots.pc' to the PKG_CONFIG_PATH environment variable Package 'wlroots', required by 'virtual:world', not found gcc -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Werror=implicit-function-declaration -Werror=implicit-int -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -I. -DWLR_USE_UNSTABLE -std=c99 -c -o wlr-screencopy-unstable-v1-protocol.o wlr-screencopy-unstable-v1-protocol.c Package wlroots was not found in the pkg-config search path. Perhaps you should add the directory containing `wlroots.pc' to the PKG_CONFIG_PATH environment variable Package 'wlroots', required by 'virtual:world', not found Package wlroots was not found in the pkg-config search path. Perhaps you should add the directory containing `wlroots.pc' to the PKG_CONFIG_PATH environment variable Package 'wlroots', required by 'virtual:world', not found Package wlroots was not found in the pkg-config search path. Perhaps you should add the directory containing `wlroots.pc' to the PKG_CONFIG_PATH environment variable Package 'wlroots', required by 'virtual:world', not found /usr/bin/wayland-scanner private-code \ //usr/share/wayland-protocols/stable/xdg-shell/xdg-shell.xml xdg-shell-protocol.c Package wlroots was not found in the pkg-config search path. Perhaps you should add the directory containing `wlroots.pc' to the PKG_CONFIG_PATH environment variable Package 'wlroots', required by 'virtual:world', not found Package wlroots was not found in the pkg-config search path. Perhaps you should add the directory containing `wlroots.pc' to the PKG_CONFIG_PATH environment variable Package 'wlroots', required by 'virtual:world', not found Package wlroots was not found in the pkg-config search path. Perhaps you should add the directory containing `wlroots.pc' to the PKG_CONFIG_PATH environment variable Package 'wlroots', required by 'virtual:world', not found /usr/bin/wayland-scanner client-header \ //usr/share/wayland-protocols/stable/xdg-shell/xdg-shell.xml xdg-shell-protocol.h Package wlroots was not found in the pkg-config search path. Perhaps you should add the directory containing `wlroots.pc' to the PKG_CONFIG_PATH environment variable Package 'wlroots', required by 'virtual:world', not found Package wlroots was not found in the pkg-config search path. Perhaps you should add the directory containing `wlroots.pc' to the PKG_CONFIG_PATH environment variable Package 'wlroots', required by 'virtual:world', not found gcc -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Werror=implicit-function-declaration -Werror=implicit-int -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -I. -DWLR_USE_UNSTABLE -std=c99 -c -o xdg-shell-protocol.o xdg-shell-protocol.c Package wlroots was not found in the pkg-config search path. Perhaps you should add the directory containing `wlroots.pc' to the PKG_CONFIG_PATH environment variable Package 'wlroots', required by 'virtual:world', not found
Is this important? bash: line 1: git: command not found bash: line 1: git: command not found
> There are a lot of warnings when running make protocols, is there something wrong with the configuration? https://github.com/hyprwm/hyprpicker/blob/b6130e3901ed5c6d423f168705929e555608d870/Makefile#L9-L11 has it, but wlroots is not used anywhere. > Is this important? > bash: line 1: git: command not found > bash: line 1: git: command not found https://github.com/hyprwm/hyprpicker/blob/b6130e3901ed5c6d423f168705929e555608d870/CMakeLists.txt#L12C16-L34 These variables are also not used in the codebase.
Package approved. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-Clause License", "Historical Permission Notice and Disclaimer - sell variant and/or NTP License (legal disclaimer)". 28 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/hyprpicker/review- hyprpicker/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 853 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: Uses parallel make %{?_smp_mflags} macro. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: hyprpicker-0.2.0-1.fc41.x86_64.rpm hyprpicker-debuginfo-0.2.0-1.fc41.x86_64.rpm hyprpicker-debugsource-0.2.0-1.fc41.x86_64.rpm hyprpicker-0.2.0-1.fc41.src.rpm ============================================================================================================== rpmlint session starts ============================================================================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpdswq3m93')] checks: 32, packages: 4 hyprpicker.src: E: spelling-error ('wlroots', 'Summary(en_US) wlroots -> roots') hyprpicker.src: E: spelling-error ('wlroots', '%description -l en_US wlroots -> roots') hyprpicker.x86_64: E: spelling-error ('wlroots', 'Summary(en_US) wlroots -> roots') hyprpicker.x86_64: E: spelling-error ('wlroots', '%description -l en_US wlroots -> roots') hyprpicker.x86_64: W: no-manual-page-for-binary hyprpicker ======================================================================== 4 packages and 0 specfiles checked; 4 errors, 1 warnings, 16 filtered, 4 badness; has taken 0.6 s =========================================================================
Thank you for the review
The Pagure repository was created at https://src.fedoraproject.org/rpms/hyprpicker
FEDORA-2024-285467ec1f (hyprpicker-0.2.0-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-285467ec1f
FEDORA-2024-285467ec1f (hyprpicker-0.2.0-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.