Bug 2244872 - Review Request: rust-nucleo - Plug and play high performance fuzzy matcher
Summary: Review Request: rust-nucleo - Plug and play high performance fuzzy matcher
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-10-18 16:56 UTC by blinxen
Modified: 2023-10-19 16:49 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-10-19 16:49:12 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description blinxen 2023-10-18 16:56:41 UTC
Spec URL: https://blinxen.fedorapeople.org/rust-nucleo/rust-nucleo.spec
SRPM URL: https://blinxen.fedorapeople.org/rust-nucleo/rust-nucleo-0.2.1-1.fc40.src.rpm

Description:
Plug and play high performance fuzzy matcher.

Fedora Account System Username: blinxen

Comment 1 blinxen 2023-10-18 16:56:44 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=107716663

Comment 2 Fedora Review Service 2023-10-18 16:57:34 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6544270
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2244872-rust-nucleo/srpm-builds/06544270/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fabio Valentini 2023-10-19 14:19:56 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MPL-2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

You might want to prevent some files from getting installed (tarpulin.toml, typos.toml).

PS: There's a typo in the first file name - it should be tarpaulin.toml, not tarpulin.toml: https://github.com/xd009642/tarpaulin
Upstream might want to fix this (and could exclude these two files from published crates in the process) :)

Comment 4 Fedora Admin user for bugzilla script actions 2023-10-19 16:33:44 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-nucleo

Comment 5 Fedora Update System 2023-10-19 16:48:53 UTC
FEDORA-2023-94cb88840b has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-94cb88840b

Comment 6 Fedora Update System 2023-10-19 16:49:12 UTC
FEDORA-2023-94cb88840b has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.