Spec URL: https://dcavalca.fedorapeople.org/review/openhmd/openhmd.spec SRPM URL: https://dcavalca.fedorapeople.org/review/openhmd/openhmd-0.3.0^20230112gite64708b-1.fc40.src.rpm Description: OpenHMD aims to provide a Free and Open Source API and drivers for immersive technology, such as head mounted displays with built in head tracking. Fedora Account System Username: dcavalca
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=107752084
Copr build: https://copr.fedorainfracloud.org/coprs/build/6546413 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2244983-openhmd/fedora-rawhide-x86_64/06546413-openhmd/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Need to ask upstream to include the MIT license text for the bundled nxjson in src/ext_deps Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [?]: Provides: bundled(gnulib) in place as required. Note: Sources not installed => probably a false positive [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Boost Software License 1.0", "Boost Software License 1.0", "*No copyright* The Unlicense", "MIT License". 18 files have unknown license. Detailed output of licensecheck in /home/michel/src/fedora/reviews/2244983-openhmd/licensecheck.txt => ext_deps has miniz under Unlicense and nxjson under MIT and the MIT license text is missing (the Unlicense one is appended at the bottom of miniz.c so that's fine) [!]: License file installed when any subpackage combination is installed. => see above, MIT license text missing [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 4732 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in openhmd- examples => examples should probably require -devel ? [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: openhmd-0.3.0^20230112gite64708b-1.fc40.x86_64.rpm openhmd-devel-0.3.0^20230112gite64708b-1.fc40.x86_64.rpm openhmd-doc-0.3.0^20230112gite64708b-1.fc40.noarch.rpm openhmd-examples-0.3.0^20230112gite64708b-1.fc40.x86_64.rpm openhmd-debuginfo-0.3.0^20230112gite64708b-1.fc40.x86_64.rpm openhmd-debugsource-0.3.0^20230112gite64708b-1.fc40.x86_64.rpm openhmd-0.3.0^20230112gite64708b-1.fc40.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmprm1g9v4t')] checks: 31, packages: 7 openhmd-examples.x86_64: W: no-manual-page-for-binary openhmd_opengl_example openhmd-examples.x86_64: W: no-manual-page-for-binary openhmd_simple_example openhmd-devel.x86_64: W: no-documentation openhmd-examples.x86_64: W: no-documentation 7 packages and 0 specfiles checked; 0 errors, 4 warnings, 0 badness; has taken 0.9 s Rpmlint (debuginfo) ------------------- Checking: openhmd-debuginfo-0.3.0^20230112gite64708b-1.fc40.x86_64.rpm openhmd-examples-debuginfo-0.3.0^20230112gite64708b-1.fc40.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp1e8k3eqr')] checks: 31, packages: 2 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.3 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 7 openhmd-examples.x86_64: W: no-manual-page-for-binary openhmd_opengl_example openhmd-examples.x86_64: W: no-manual-page-for-binary openhmd_simple_example openhmd-devel.x86_64: W: no-documentation openhmd-examples.x86_64: W: no-documentation 7 packages and 0 specfiles checked; 0 errors, 4 warnings, 48 filtered, 0 badness; has taken 1.8 s Source checksums ---------------- https://github.com/OpenHMD/OpenHMD/archive/e64708b8213c52a6b0bbd7ad77e0ab910b5af6b8/OpenHMD-e64708b8213c52a6b0bbd7ad77e0ab910b5af6b8.tar.gz : CHECKSUM(SHA256) this package : 06001cb5e08333794175edeea3761d720faf14fda76d47bc8aa1384060d0364d CHECKSUM(SHA256) upstream package : 06001cb5e08333794175edeea3761d720faf14fda76d47bc8aa1384060d0364d Requires -------- openhmd (rpmlib, GLIBC filtered): libc.so.6()(64bit) libhidapi-libusb.so.0()(64bit) libm.so.6()(64bit) rtld(GNU_HASH) openhmd-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libopenhmd.so.0()(64bit) openhmd(x86-64) pkgconfig(hidapi-libusb) openhmd-doc (rpmlib, GLIBC filtered): openhmd-examples (rpmlib, GLIBC filtered): libGL.so.1()(64bit) libGLEW.so.2.2()(64bit) libSDL2-2.0.so.0()(64bit) libc.so.6()(64bit) libopenhmd.so.0()(64bit) rtld(GNU_HASH) openhmd-debuginfo (rpmlib, GLIBC filtered): openhmd-debugsource (rpmlib, GLIBC filtered): Provides -------- openhmd: libopenhmd.so.0()(64bit) openhmd openhmd(x86-64) openhmd-devel: openhmd-devel openhmd-devel(x86-64) pkgconfig(openhmd) openhmd-doc: openhmd-doc openhmd-examples: openhmd-examples openhmd-examples(x86-64) openhmd-debuginfo: debuginfo(build-id) libopenhmd.so.0.1.0-0.3.0^20230112gite64708b-1.fc40.x86_64.debug()(64bit) openhmd-debuginfo openhmd-debuginfo(x86-64) openhmd-debugsource: openhmd-debugsource openhmd-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2244983 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: PHP, Java, Python, fonts, SugarActivity, R, Ocaml, Perl, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Spec URL: https://dcavalca.fedorapeople.org/review/openhmd/openhmd.spec SRPM URL: https://dcavalca.fedorapeople.org/review/openhmd/openhmd-0.3.0^20230112gite64708b-1.fc40.src.rpm Changelog: - add provides and license texts for bundled dependencies
Created attachment 2005682 [details] The .spec file difference from Copr build 6546413 to 6812700
Copr build: https://copr.fedorainfracloud.org/coprs/build/6812700 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2244983-openhmd/fedora-rawhide-x86_64/06812700-openhmd/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
LGTM, APPROVED. Please file an issue upstream with the suggested MIT license text
The Pagure repository was created at https://src.fedoraproject.org/rpms/openhmd
FEDORA-2023-a0b6dd7a2e has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-a0b6dd7a2e
FEDORA-2023-a0b6dd7a2e has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-ea5d024e57 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-ea5d024e57
FEDORA-2023-2da7ee8b5b has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-2da7ee8b5b
FEDORA-2023-ea5d024e57 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-ea5d024e57 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-ea5d024e57 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-2da7ee8b5b has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-2da7ee8b5b \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-2da7ee8b5b See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-ea5d024e57 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-2da7ee8b5b has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.