Bug 2245451 - Review Request: rust-logos - Create ridiculously fast Lexers
Summary: Review Request: rust-logos - Create ridiculously fast Lexers
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/logos
Whiteboard:
Depends On: 2245445 2245450
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-10-21 15:33 UTC by Seth Maurice-Brant
Modified: 2023-11-07 20:22 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-11-07 20:22:27 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 6577370 to 6610152 (1.48 KB, patch)
2023-11-07 18:56 UTC, Fedora Review Service
no flags Details | Diff

Description Seth Maurice-Brant 2023-10-21 15:33:11 UTC
Spec URL: https://gitlab.com/fedora-pkgs/rust-logos/-/raw/main/rust-logos.spec
SRPM URL: https://gitlab.com/fedora-pkgs/rust-logos/-/raw/main/rust-logos-0.13.0-1.fc39.src.rpm
Description: Create ridiculously fast Lexers
Fedora Account System Username: saluki

Comment 1 Fedora Review Service 2023-10-23 13:05:06 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6557796
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2245451-rust-logos/srpm-builds/06557796/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Seth Maurice-Brant 2023-10-28 10:52:49 UTC
Updated to fix some licensing issues. Build will still fail due to dependencies, those requests are depended upon by this one.

Spec: https://gitlab.com/fedora-pkgs/rust-logos/-/raw/main/rust-logos.spec
SRPM:https://gitlab.com/fedora-pkgs/rust-logos/-/raw/main/rust-logos-0.13.0-2.fc40.src.rpm

Comment 3 Fedora Review Service 2023-10-29 01:34:08 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6577370
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2245451-rust-logos/fedora-rawhide-x86_64/06577370-rust-logos/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Seth Maurice-Brant 2023-11-02 13:18:06 UTC
Issues resolved. Build will still fail due to missing depends.

Comment 5 Fabio Valentini 2023-11-07 18:33:07 UTC
This package doesn't compile - looks like the doctests cannot be compiled due to README.md from the root of the git repository being referenced:

> error: couldn't read src/../../README.md: No such file or directory (os error 2)
>    --> src/lib.rs:410:24
>     |
> 410 |     external_doc_test!(include_str!("../../README.md"));
>     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>     |
>     = note: this error originates in the macro `include_str` (in Nightly builds, run with -Z macro-backtrace for more info)
> error: aborting due to previous error
> error: doctest failed, to rerun pass `--doc`

You can work around that by replacing `%cargo_test` with `%cargo_test -- --lib`.

Comment 6 Seth Maurice-Brant 2023-11-07 18:50:24 UTC
Ah, I must have missed that error as I originally submitted this thinking builds were failing due to missing depends (now fixed), sorry about that one.

I can confirm the following is building correctly:

SRPM: https://gitlab.com/fedora-pkgs/rust-logos/-/raw/main/rust-logos-0.13.0-5.fc40.src.rpm
Spec: https://gitlab.com/fedora-pkgs/rust-logos/-/raw/main/rust-logos.spec-

Comment 7 Fedora Review Service 2023-11-07 18:56:17 UTC
Created attachment 1997692 [details]
The .spec file difference from Copr build 6577370 to 6610152

Comment 8 Fedora Review Service 2023-11-07 18:56:20 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6610152
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2245451-rust-logos/fedora-rawhide-x86_64/06610152-rust-logos/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 9 Fabio Valentini 2023-11-07 19:30:56 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass (there are no un-skipped tests)
- latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license files are included with %license in %files (manually included from upstream project on GitHub)
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 10 Fedora Admin user for bugzilla script actions 2023-11-07 20:06:36 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-logos

Comment 11 Fedora Update System 2023-11-07 20:21:08 UTC
FEDORA-2023-37aefd77f8 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-37aefd77f8

Comment 12 Fedora Update System 2023-11-07 20:22:27 UTC
FEDORA-2023-37aefd77f8 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.