Spec URL: https://download.copr.fedorainfracloud.org/results/sagitter/ForTesting/fedora-rawhide-x86_64/06552011-python-aioquic/python-aioquic.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/sagitter/ForTesting/fedora-rawhide-x86_64/06552011-python-aioquic/python-aioquic-0.9.21-1.fc40.src.rpm Fedora Account System Username: sagitter
Copr build: https://copr.fedorainfracloud.org/coprs/build/6557804 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2245469-python-aioquic/srpm-builds/06557804/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
[fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/6596162 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2245469-python-aioquic/fedora-rawhide-x86_64/06596162-python-aioquic/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [-]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD 3-Clause License", "Unknown or generated", "*No copyright* BSD 3-Clause License". 96 files have unknown license. Detailed output of licensecheck in /home/fedora/2245469-python- aioquic/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 3949 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-aioquic [ ]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-aioquic-0.9.21-1.fc40.aarch64.rpm python-aioquic-debugsource-0.9.21-1.fc40.aarch64.rpm python-aioquic-0.9.21-1.fc40.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpm5sj42w3')] checks: 31, packages: 3 python-aioquic.src: W: summary-not-capitalized aioquic is a library for the QUIC network protocol in Python python3-aioquic.aarch64: W: summary-not-capitalized aioquic is a library for the QUIC network protocol in Python python3-aioquic.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/aioquic/_buffer.c python3-aioquic.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/aioquic/_crypto.c python-aioquic.src: E: description-line-too-long aioquic is regularly tested for interoperability against other QUIC implementations. python3-aioquic.aarch64: E: description-line-too-long aioquic is regularly tested for interoperability against other QUIC implementations. 3 packages and 0 specfiles checked; 2 errors, 4 warnings, 2 badness; has taken 0.4 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 2 python3-aioquic.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/aioquic/_buffer.abi3.so PyExc_ValueError (/usr/lib64/python3.12/site-packages/aioquic/_buffer.abi3.so) python3-aioquic.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/aioquic/_buffer.abi3.so _Py_FalseStruct (/usr/lib64/python3.12/site-packages/aioquic/_buffer.abi3.so) python3-aioquic.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/aioquic/_buffer.abi3.so _Py_NoneStruct (/usr/lib64/python3.12/site-packages/aioquic/_buffer.abi3.so) python3-aioquic.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/aioquic/_buffer.abi3.so _Py_TrueStruct (/usr/lib64/python3.12/site-packages/aioquic/_buffer.abi3.so) python3-aioquic.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/aioquic/_buffer.abi3.so PyLong_FromUnsignedLongLong (/usr/lib64/python3.12/site-packages/aioquic/_buffer.abi3.so) python3-aioquic.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/aioquic/_buffer.abi3.so PyBytes_FromStringAndSize (/usr/lib64/python3.12/site-packages/aioquic/_buffer.abi3.so) python3-aioquic.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/aioquic/_buffer.abi3.so _Py_Dealloc (/usr/lib64/python3.12/site-packages/aioquic/_buffer.abi3.so) python3-aioquic.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/aioquic/_buffer.abi3.so PyType_GetSlot (/usr/lib64/python3.12/site-packages/aioquic/_buffer.abi3.so) python3-aioquic.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/aioquic/_buffer.abi3.so PyErr_SetString (/usr/lib64/python3.12/site-packages/aioquic/_buffer.abi3.so) python3-aioquic.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/aioquic/_buffer.abi3.so PyLong_FromSsize_t (/usr/lib64/python3.12/site-packages/aioquic/_buffer.abi3.so) python3-aioquic.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/aioquic/_buffer.abi3.so PyErr_NewException (/usr/lib64/python3.12/site-packages/aioquic/_buffer.abi3.so) python3-aioquic.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/aioquic/_buffer.abi3.so PyModule_Create2 (/usr/lib64/python3.12/site-packages/aioquic/_buffer.abi3.so) python3-aioquic.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/aioquic/_buffer.abi3.so _PyArg_ParseTuple_SizeT (/usr/lib64/python3.12/site-packages/aioquic/_buffer.abi3.so) python3-aioquic.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/aioquic/_buffer.abi3.so _PyArg_ParseTupleAndKeywords_SizeT(/usr/lib64/python3.12/site-packages/aioquic/_buffer.abi3.so) python3-aioquic.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/aioquic/_buffer.abi3.so PyLong_FromUnsignedLong (/usr/lib64/python3.12/site-packages/aioquic/_buffer.abi3.so) python3-aioquic.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/aioquic/_buffer.abi3.so PyModule_AddObject (/usr/lib64/python3.12/site-packages/aioquic/_buffer.abi3.so) python3-aioquic.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/aioquic/_buffer.abi3.so PyType_FromSpec (/usr/lib64/python3.12/site-packages/aioquic/_buffer.abi3.so) python3-aioquic.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/aioquic/_crypto.abi3.so PyExc_ValueError (/usr/lib64/python3.12/site-packages/aioquic/_crypto.abi3.so) python3-aioquic.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/aioquic/_crypto.abi3.so PyModule_AddObject (/usr/lib64/python3.12/site-packages/aioquic/_crypto.abi3.so) python3-aioquic.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/aioquic/_crypto.abi3.so _PyArg_ParseTuple_SizeT (/usr/lib64/python3.12/site-packages/aioquic/_crypto.abi3.so) python3-aioquic.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/aioquic/_crypto.abi3.so PyErr_Format (/usr/lib64/python3.12/site-packages/aioquic/_crypto.abi3.so) python3-aioquic.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/aioquic/_crypto.abi3.so PyType_FromSpec (/usr/lib64/python3.12/site-packages/aioquic/_crypto.abi3.so) python3-aioquic.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/aioquic/_crypto.abi3.so PyErr_NewException (/usr/lib64/python3.12/site-packages/aioquic/_crypto.abi3.so) python3-aioquic.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/aioquic/_crypto.abi3.so PyType_GetSlot (/usr/lib64/python3.12/site-packages/aioquic/_crypto.abi3.so) python3-aioquic.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/aioquic/_crypto.abi3.so PyBytes_FromStringAndSize (/usr/lib64/python3.12/site-packages/aioquic/_crypto.abi3.so) python3-aioquic.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/aioquic/_crypto.abi3.so _Py_Dealloc (/usr/lib64/python3.12/site-packages/aioquic/_crypto.abi3.so) python3-aioquic.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/aioquic/_crypto.abi3.so PyModule_Create2 (/usr/lib64/python3.12/site-packages/aioquic/_crypto.abi3.so) python3-aioquic.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/aioquic/_crypto.abi3.so PyErr_SetString (/usr/lib64/python3.12/site-packages/aioquic/_crypto.abi3.so) python3-aioquic.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/aioquic/_crypto.abi3.so _Py_BuildValue_SizeT (/usr/lib64/python3.12/site-packages/aioquic/_crypto.abi3.so) python3-aioquic.aarch64: W: summary-not-capitalized aioquic is a library for the QUIC network protocol in Python python3-aioquic.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/aioquic/_buffer.c python3-aioquic.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/aioquic/_crypto.c python3-aioquic.aarch64: E: description-line-too-long aioquic is regularly tested for interoperability against other QUIC implementations. 2 packages and 0 specfiles checked; 1 errors, 32 warnings, 1 badness; has taken 0.3 s Unversioned so-files -------------------- python3-aioquic: /usr/lib64/python3.12/site-packages/aioquic/_buffer.abi3.so python3-aioquic: /usr/lib64/python3.12/site-packages/aioquic/_crypto.abi3.so Source checksums ---------------- https://files.pythonhosted.org/packages/source/a/aioquic/aioquic-0.9.21.tar.gz : CHECKSUM(SHA256) this package : 79c7ec06318e785627665ca4e8723adf347b7225b7d006e332d2575a1f516ef5 CHECKSUM(SHA256) upstream package : 79c7ec06318e785627665ca4e8723adf347b7225b7d006e332d2575a1f516ef5 Requires -------- python3-aioquic (rpmlib, GLIBC filtered): (python3.12dist(pylsqpack) < 0.4~~ with python3.12dist(pylsqpack) >= 0.3.3) ld-linux-aarch64.so.1()(64bit) libc.so.6()(64bit) libcrypto.so.3()(64bit) libcrypto.so.3(OPENSSL_3.0.0)(64bit) python(abi) python3.12dist(certifi) python3.12dist(pyopenssl) rtld(GNU_HASH) python-aioquic-debugsource (rpmlib, GLIBC filtered): Provides -------- python3-aioquic: python-aioquic python3-aioquic python3-aioquic(aarch-64) python3.12-aioquic python3.12dist(aioquic) python3dist(aioquic) python-aioquic-debugsource: python-aioquic-debugsource python-aioquic-debugsource(aarch-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2245469 Buildroot used: fedora-rawhide-aarch64 Active plugins: C/C++, Shell-api, Generic, Python Disabled plugins: fonts, Haskell, Ocaml, SugarActivity, PHP, R, Java, Perl Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) can omit %license LICENSE when using pyproject as it is included aioquic-0.9.21.dist-info b) please update to latest release c) Can documentation and examples be packaged? d) Can a check section be added with %check %pyproject_check_import e) Can any of the tests be run?
Spec URL: https://download.copr.fedorainfracloud.org/results/sagitter/ForTesting/fedora-rawhide-x86_64/06600577-python-aioquic/python-aioquic.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/sagitter/ForTesting/fedora-rawhide-x86_64/06600577-python-aioquic/python-aioquic-0.9.22-1.fc40.src.rpm - Update to latest release - Fix warnings - Fix "undefined symbols" - Add check section - Fix LICENSE locations
Created attachment 1997429 [details] The .spec file difference from Copr build 6596162 to 6603238
Copr build: https://copr.fedorainfracloud.org/coprs/build/6603238 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2245469-python-aioquic/fedora-rawhide-x86_64/06603238-python-aioquic/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Comments: a) Warning in multiple files that upstream should be notified of: DeprecationWarning: datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.now(datetime.UTC). b) There is an error about missing https://pypi.org/project/embed/ which is not packaged in Fedora python-aioquic.spec: E: specfile-error Package python3-embed was not found in the pkg-config search path. python-aioquic.spec: E: specfile-error Perhaps you should add the directory containing `python3-embed.pc' python-aioquic.spec: E: specfile-error to the PKG_CONFIG_PATH environment variable python-aioquic.spec: E: specfile-error Package 'python3-embed', required by 'virtual:world', not found Unclear why this is obtained c) Other minor warnings python-aioquic.src: W: summary-not-capitalized aioquic is a library for the QUIC network protocol in Python. python3-aioquic.x86_64: W: summary-not-capitalized aioquic is a library for the QUIC network protocol in Python. python-aioquic.src: W: summary-ended-with-dot aioquic is a library for the QUIC network protocol in Python. python3-aioquic.x86_64: W: summary-ended-with-dot aioquic is a library for the QUIC network protocol in Python. Perhaps use A library for the QUIC network protocol in Python
python3-embed.pc is included in python3-devel Those warnings 'summary-not-capitalized' are minor issues, i will fix them.
Thanks. python3-embed.pc seems to be an review tool error. Approved. Please make other warning fixes on import.
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-aioquic
(In reply to Benson Muite from comment #10) > Thanks. python3-embed.pc seems to be an review tool error. Approved. Please > make other warning fixes on import. Sure. Thank you.
Package is now in repositories, closing review.