Bug 2245601 - qpid-dispatch fails to build with Python 3.13: implicit declaration of function ‘getpid’ / ‘gettimeofday’
Summary: qpid-dispatch fails to build with Python 3.13: implicit declaration of functi...
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: qpid-dispatch
Version: 40
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Irina Boverman
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTHON3.13
TreeView+ depends on / blocked
 
Reported: 2023-10-23 09:21 UTC by Karolina Surma
Modified: 2024-02-15 23:00 UTC (History)
5 users (show)

Fixed In Version: qpid-dispatch-1.19.0-7.fc40
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-11-28 21:24:25 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Karolina Surma 2023-10-23 09:21:20 UTC
qpid-dispatch fails to build with Python 3.13.0a1.

This report is automated and not very verbose, but we'll try to get back here with details.


/builddir/build/BUILD/qpid-dispatch-1.19.0/src/dispatch.c:82:5: error: implicit declaration of function ‘gettimeofday’ [-Wimplicit-function-declaration]
   82 |     gettimeofday(&time, NULL);
      |     ^~~~~~~~~~~~
<snip>
/builddir/build/BUILD/qpid-dispatch-1.19.0/src/dispatch.c:412:26: error: implicit declaration of function ‘getpid’; did you mean ‘getpt’? [-Wimplicit-function-declaration]
  412 |     const pid_t my_pid = getpid();
      |                          ^~~~~~
      |                          getpt


From https://docs.python.org/3.13/whatsnew/3.13.html:

- Python.h no longer includes the <unistd.h> standard header file. If needed, it should now be included explicitly. For example, it provides the functions: read(), write(), close(), isatty(), lseek(), getpid(), getcwd(), sysconf() and getpagesize(). As a consequence, _POSIX_SEMAPHORES and _POSIX_THREADS macros are no longer defined by Python.h. The HAVE_UNISTD_H and HAVE_PTHREAD_H macros defined by Python.h can be used to decide if <unistd.h> and <pthread.h> header files can be included. (Contributed by Victor Stinner in gh-108765.)

- Python.h no longer includes these standard header files: <time.h>, <sys/select.h> and <sys/time.h>. If needed, they should now be included explicitly. For example, <time.h> provides the clock() and gmtime() functions, <sys/select.h> provides the select() function, and <sys/time.h> provides the futimes(), gettimeofday() and setitimer() functions. (Contributed by Victor Stinner in gh-108765.)


For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.13/fedora-rawhide-x86_64/06551232-qpid-dispatch/

For all our attempts to build qpid-dispatch with Python 3.13, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.13/package/qpid-dispatch/

Testing and mass rebuild of packages is happening in copr.
You can follow these instructions to test locally in mock if your package builds with Python 3.13:
https://copr.fedorainfracloud.org/coprs/g/python/python3.13/

Let us know here if you have any questions.

Python 3.13 is planned to be included in Fedora 41.
To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.13.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires),
so if this package is required a lot, it's important for us to get it fixed soon.

We'd appreciate help from the people who know this package best,
but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Karolina Surma 2023-11-29 08:20:42 UTC
Thank you for patching the package! However, the patch has uncovered another place where this is missing:

/builddir/build/BUILD/qpid-dispatch-1.19.0/src/log.c: In function ‘qd_vlog_impl’:
/builddir/build/BUILD/qpid-dispatch-1.19.0/src/log.c:442:5: error: implicit declaration of function ‘gettimeofday’ [-Wimplicit-function-declaration]
  442 |     gettimeofday(&entry->time, NULL);
      |     ^~~~~~~~~~~~

You can test the package locally in mock with Python 3.13 copr repository using the instructions in https://copr.fedorainfracloud.org/coprs/g/python/python3.13/ or ping me - I'll be happy to verify whether the fix is sufficient.

Comment 2 Aoife Moloney 2024-02-15 23:00:16 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 40 development cycle.
Changing version to 40.


Note You need to log in before you can comment on or make changes to this bug.