Bug 2245754 - Review Request: golang-github-ipinfo-2 - Go library for IPinfo API
Summary: Review Request: golang-github-ipinfo-2 - Go library for IPinfo API
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Pavel Solovev
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2189995
TreeView+ depends on / blocked
 
Reported: 2023-10-23 22:31 UTC by Mikel Olasagasti Uranga
Modified: 2023-10-24 16:52 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-10-24 16:52:11 UTC
Type: ---
Embargoed:
daron439: fedora-review+


Attachments (Terms of Use)

Description Mikel Olasagasti Uranga 2023-10-23 22:31:41 UTC
Spec URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-ipinfo-2.spec
SRPM URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-ipinfo-2-2.10.0-1.fc38.src.rpm
Description: Go library for IPinfo API.
Fedora Account System Username: mikelo2

Comment 1 Fedora Review Service 2023-10-23 22:45:13 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6559326
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2245754-golang-github-ipinfo-2/fedora-rawhide-x86_64/06559326-golang-github-ipinfo-2/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Pavel Solovev 2023-10-24 16:29:48 UTC
Golang Package Review
==============

This package was generated using go2rpm, which simplifies the review.
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


- [x] The specfile is sane.
- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package complies with the Golang and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.

Thanks!

Comment 3 Fedora Admin user for bugzilla script actions 2023-10-24 16:40:42 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-ipinfo-2

Comment 4 Fedora Update System 2023-10-24 16:50:58 UTC
FEDORA-2023-07cdcddbd1 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-07cdcddbd1

Comment 5 Fedora Update System 2023-10-24 16:52:11 UTC
FEDORA-2023-07cdcddbd1 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.