Bug 2245809 - python-cups fails to build with Python 3.13: error: implicit declaration of function ‘PyEval_CallObject’; 'isaplha', 'isdigit'
Summary: python-cups fails to build with Python 3.13: error: implicit declaration of f...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-cups
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Zdenek Dohnal
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTHON3.13
TreeView+ depends on / blocked
 
Reported: 2023-10-24 08:06 UTC by Karolina Surma
Modified: 2024-04-18 07:39 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-04-17 15:23:13 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Karolina Surma 2023-10-24 08:06:18 UTC
python-cups fails to build with Python 3.13.0a1.

cupsconnection.c:377:12: error: implicit declaration of function ‘PyEval_CallObject’; did you mean ‘PyObject_CallObject’? [-Werror=implicit-function-declaration]
  377 |   result = PyEval_CallObject (tls->cups_password_callback, args);
      |            ^~~~~~~~~~~~~~~~~
      |            PyObject_CallObject

cupsconnection.c:145:9: error: implicit declaration of function ‘isalpha’ [-Werror=implicit-function-declaration]
  145 |     if (isalpha (*s) || isdigit (*s) || *s == '-')
      |         ^~~~~~~

According to https://docs.python.org/3.13/whatsnew/3.13.html:
- Remove PyEval_CallObject(), PyEval_CallObjectWithKeywords(): use PyObject_CallNoArgs() or PyObject_Call() instead.
Warning: PyObject_Call() positional arguments must be a tuple and must not be NULL,
keyword arguments must be a dict or NULL, whereas removed functions checked arguments type and accepted NULL positional and keyword arguments.
To replace PyEval_CallObjectWithKeywords(func, NULL, kwargs) with PyObject_Call(),
pass an empty tuple as positional arguments using PyTuple_New(0).
- Python.h no longer includes the <ctype.h> standard header file. If needed, it should now be included explicitly. For example, it provides isalpha() and tolower() functions which are locale dependent. Python provides locale independent functions, like Py_ISALPHA() and Py_TOLOWER(). (Contributed by Victor Stinner in gh-108765.)


https://docs.python.org/3.13/whatsnew/3.13.html

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.13/fedora-rawhide-x86_64/06546772-python-cups/

For all our attempts to build python-cups with Python 3.13, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.13/package/python-cups/

Testing and mass rebuild of packages is happening in copr.
You can follow these instructions to test locally in mock if your package builds with Python 3.13:
https://copr.fedorainfracloud.org/coprs/g/python/python3.13/

Let us know here if you have any questions.

Python 3.13 is planned to be included in Fedora 41.
To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.13.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires),
so if this package is required a lot, it's important for us to get it fixed soon.

We'd appreciate help from the people who know this package best,
but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Zdenek Dohnal 2024-01-09 07:31:22 UTC
Hi Karolina,

I have this on my list, but currently I'm trying to solve things for F40. If you can provide any help/tips, it would be appreciated.


Zdenek

Comment 2 Aoife Moloney 2024-02-15 23:00:59 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 40 development cycle.
Changing version to 40.

Comment 3 Zdenek Dohnal 2024-04-17 15:23:13 UTC
Fixed in https://koji.fedoraproject.org/koji/taskinfo?taskID=116511571 - looks like something else now provides <ctype.h>, so I didn't need to add it at the moment.

Comment 4 Miro Hrončok 2024-04-17 17:45:21 UTC
Python itself added the <ctype.h> include back to avoid breakage. Anyway, the code that uses it should really add it, this might happen again.

Comment 5 Zdenek Dohnal 2024-04-18 07:39:21 UTC
I've pushed it upstream for now, so version after 2.0.4 will have the ctype.h header used.


Note You need to log in before you can comment on or make changes to this bug.