Bug 2245815 - jsonnet fails to build with Python 3.13: error: implicit declaration of function ‘PyEval_CallObject’; did you mean ‘PyObject_CallObject’?
Summary: jsonnet fails to build with Python 3.13: error: implicit declaration of func...
Keywords:
Status: CLOSED WORKSFORME
Alias: None
Product: Fedora
Classification: Fedora
Component: jsonnet
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Pat Riehecky
QA Contact:
URL:
Whiteboard:
: 2291547 (view as bug list)
Depends On:
Blocks: PYTHON3.13 F41FTBFS F41FailsToInstall
TreeView+ depends on / blocked
 
Reported: 2023-10-24 08:13 UTC by Karolina Surma
Modified: 2024-06-21 00:11 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-06-21 00:11:05 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github google jsonnet issues 1032 0 None open deprecated declarations in bindings 2024-06-20 18:19:02 UTC

Description Karolina Surma 2023-10-24 08:13:43 UTC
jsonnet fails to build with Python 3.13.0a1.

python/_jsonnet.c:189:14: error: implicit declaration of function ‘PyEval_CallObject’; did you mean ‘PyObject_CallObject’? [-Werror=implicit-function-declaration]
    189 |     result = PyEval_CallObject(ctx->callback, arglist);
        |              ^~~~~~~~~~~~~~~~~
        |              PyObject_CallObject

According to https://docs.python.org/3.13/whatsnew/3.13.html:

Remove PyEval_CallObject(), PyEval_CallObjectWithKeywords(): use PyObject_CallNoArgs() or PyObject_Call() instead.
Warning: PyObject_Call() positional arguments must be a tuple and must not be NULL,
keyword arguments must be a dict or NULL, whereas removed functions checked arguments type and accepted NULL positional and keyword arguments.
To replace PyEval_CallObjectWithKeywords(func, NULL, kwargs) with PyObject_Call(),
pass an empty tuple as positional arguments using PyTuple_New(0).

https://docs.python.org/3.13/whatsnew/3.13.html

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.13/fedora-rawhide-x86_64/06546795-jsonnet/

For all our attempts to build jsonnet with Python 3.13, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.13/package/jsonnet/

Testing and mass rebuild of packages is happening in copr.
You can follow these instructions to test locally in mock if your package builds with Python 3.13:
https://copr.fedorainfracloud.org/coprs/g/python/python3.13/

Let us know here if you have any questions.

Python 3.13 is planned to be included in Fedora 41.
To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.13.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires),
so if this package is required a lot, it's important for us to get it fixed soon.

We'd appreciate help from the people who know this package best,
but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Pat Riehecky 2023-10-31 13:54:53 UTC
Back in 2022 I opened up https://github.com/google/jsonnet/issues/1032

I fear I'm not able to generate a patch for this in the near term...

Comment 2 Aoife Moloney 2024-02-15 23:01:04 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 40 development cycle.
Changing version to 40.

Comment 3 Karolina Surma 2024-06-12 14:55:59 UTC
*** Bug 2291547 has been marked as a duplicate of this bug. ***

Comment 4 Fedora Fails To Install 2024-06-19 19:56:44 UTC
Hello,

Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py
If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/

This package fails to install and maintainers are advised to take one of the following actions:

 - Fix this bug and close this bugzilla once the update makes it to the repository.
   (The same script that posted this comment will eventually close this bugzilla
   when the fixed package reaches the repository, so you don't have to worry about it.)

or

 - Move this bug to ASSIGNED if you plan on fixing this, but simply haven't done so yet.

or

 - Orphan the package if you no longer plan to maintain it.


If you do not take one of these actions, the process at https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs will continue.
This package may be orphaned in 7+ weeks.
This is the first reminder (step 3) from the policy.

Don't hesitate to ask for help on https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/ if you are unsure how to fix this bug.

Comment 5 Pat Riehecky 2024-06-20 18:19:22 UTC
I fear I lack the required skill to generate the necessary patches.

Comment 6 Miro Hrončok 2024-06-20 19:28:31 UTC
In this file:

https://github.com/google/jsonnet/blob/v0.20.0/python/_jsonnet.c

Replace both occurrences of:

   result = PyEval_CallObject(ctx->callback, arglist);

With:

   result = PyObject_Call(ctx->callback, arglist, NULL);


See the documentation at https://docs.python.org/3.13/c-api/call.html#c.PyObject_Call

That should do it, but I have not tested it.

Comment 7 Pat Riehecky 2024-06-20 20:25:01 UTC
Thanks Miro!

Based on the documentation you linked I've published : https://github.com/google/jsonnet/pull/1159/files

Comment 8 Fedora Fails To Install 2024-06-21 00:11:05 UTC
Hello,

Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py
If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/

All subpackages of a package against which this bug was filled are now installable or removed from Fedora 41.

Thanks for taking care of it!


Note You need to log in before you can comment on or make changes to this bug.