Bug 2245822 - python-gammu fails to build with Python 3.13: Missing <ctype.h> declaration
Summary: python-gammu fails to build with Python 3.13: Missing <ctype.h> declaration
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: python-gammu
Version: 40
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Sergio Basto
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTHON3.13
TreeView+ depends on / blocked
 
Reported: 2023-10-24 08:32 UTC by Karolina Surma
Modified: 2024-06-18 21:54 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-06-18 21:54:34 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Karolina Surma 2023-10-24 08:32:17 UTC
python-gammu fails to build with Python 3.13.0a1.

gammu/src/convertors/base.c:59:29: error: implicit declaration of function ‘isdigit’ [-Werror=implicit-function-declaration]
   59 |                         if (isdigit((int)s[0])) {
      |                             ^~~~~~~
gammu/src/convertors/base.c:34:1: note: include ‘<ctype.h>’ or provide a declaration of ‘isdigit’

According to https://docs.python.org/3.13/whatsnew/3.13.html:

Python.h no longer includes the <ctype.h> standard header file.
If needed, it should now be included explicitly.
For example, it provides isalpha() and tolower() functions which are locale dependent.
Python provides locale independent functions, like Py_ISALPHA() and Py_TOLOWER().
(Contributed by Victor Stinner in gh-108765.)


https://docs.python.org/3.13/whatsnew/3.13.html

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.13/fedora-rawhide-x86_64/06546783-python-gammu/

For all our attempts to build python-gammu with Python 3.13, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.13/package/python-gammu/

Testing and mass rebuild of packages is happening in copr.
You can follow these instructions to test locally in mock if your package builds with Python 3.13:
https://copr.fedorainfracloud.org/coprs/g/python/python3.13/

Let us know here if you have any questions.

Python 3.13 is planned to be included in Fedora 41.
To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.13.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires),
so if this package is required a lot, it's important for us to get it fixed soon.

We'd appreciate help from the people who know this package best,
but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Sergio Basto 2023-10-24 21:56:32 UTC
can you send me a fix ? please

Comment 2 Miro Hrončok 2023-10-25 06:08:04 UTC
Add:

#include <ctype.h>

to gammu/src/convertors/base.c

Comment 3 Aoife Moloney 2024-02-15 23:01:11 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 40 development cycle.
Changing version to 40.

Comment 4 Sergio Basto 2024-06-18 21:54:34 UTC
It built on F40 and in Rebuilt for Python 3.13 , without any modification 

closing as not a bug , since no modifications was required


Note You need to log in before you can comment on or make changes to this bug.