Bug 2245860 - py-spidev fails to build with Python 3.13: Missing <unistd.h> declaration
Summary: py-spidev fails to build with Python 3.13: Missing <unistd.h> declaration
Keywords:
Status: CLOSED COMPLETED
Alias: None
Product: Fedora
Classification: Fedora
Component: py-spidev
Version: 40
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Peter Robinson
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTHON3.13
TreeView+ depends on / blocked
 
Reported: 2023-10-24 11:37 UTC by Karolina Surma
Modified: 2024-09-04 16:12 UTC (History)
3 users (show)

Fixed In Version: py-spidev-3.4-18.fc41
Clone Of:
Environment:
Last Closed: 2024-09-04 16:12:36 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Karolina Surma 2023-10-24 11:37:53 UTC
py-spidev fails to build with Python 3.13.0a1.

spidev_module.c:139:34: error: implicit declaration of function ‘close’; did you mean ‘clone’? [-Werror=implicit-function-declaration]
  139 |         if ((self->fd != -1) && (close(self->fd) == -1)) {
      |                                  ^~~~~
      |                                  clone
spidev_module.c: In function ‘SpiDev_writebytes’:
spidev_module.c:218:18: error: implicit declaration of function ‘write’; did you mean ‘fwrite’? [-Werror=implicit-function-declaration]
  218 |         status = write(self->fd, &buf[0], len);
      |                  ^~~~~
      |                  fwrite
spidev_module.c: In function ‘SpiDev_readbytes’:
spidev_module.c:255:18: error: implicit declaration of function ‘read’; did you mean ‘fread’? [-Werror=implicit-function-declaration]
  255 |         status = read(self->fd, &rxbuf[0], len);
      |                  ^~~~
      |                  fread

According to https://docs.python.org/3.13/whatsnew/3.13.html:

Python.h no longer includes the <unistd.h> standard header file.
If needed, it should now be included explicitly.
For example, it provides the functions: read(), write(), close(), isatty(), lseek(), getpid(), getcwd(), sysconf() and getpagesize().
As a consequence, _POSIX_SEMAPHORES and _POSIX_THREADS macros are no longer defined by Python.h.
The HAVE_UNISTD_H and HAVE_PTHREAD_H macros defined by Python.h can be used to decide if <unistd.h> and <pthread.h> header files can be included.
(Contributed by Victor Stinner in gh-108765.)


https://docs.python.org/3.13/whatsnew/3.13.html

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.13/fedora-rawhide-x86_64/06546838-py-spidev/

For all our attempts to build py-spidev with Python 3.13, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.13/package/py-spidev/

Testing and mass rebuild of packages is happening in copr.
You can follow these instructions to test locally in mock if your package builds with Python 3.13:
https://copr.fedorainfracloud.org/coprs/g/python/python3.13/

Let us know here if you have any questions.

Python 3.13 is planned to be included in Fedora 41.
To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.13.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires),
so if this package is required a lot, it's important for us to get it fixed soon.

We'd appreciate help from the people who know this package best,
but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Aoife Moloney 2024-02-15 23:01:23 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 40 development cycle.
Changing version to 40.


Note You need to log in before you can comment on or make changes to this bug.