This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=108237339

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6577376
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2246730-ntpd-rs/srpm-builds/06577376/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

There's some rpmlint issues

ntpd-rs.x86_64: W: tmpfile-not-in-filelist /var/lib/ntpd-rs
ntpd-rs.x86_64: W: tmpfile-not-in-filelist /var/lib/ntpd-rs-observe
ntpd-rs.x86_64: W: tmpfile-not-in-filelist /var/run/ntpd-rs
ntpd-rs.x86_64: W: post-without-tmpfile-creation /usr/lib/tmpfiles.d/ntpd-rs.conf


Can't find a proper description for tmpfile-not-in-filelist but it seems self-explanatory (the directories probably needed to be marked as %ghost).

For the last one, openSUSE has this documented: https://en.opensuse.org/openSUSE:Packaging_checks#postin-without-tmpfile-creation

Presumably the recommendation applies here

%post
...
%tmpfiles_create %{_tmpfilesdir}/ntpd-rs.conf
...

Sadly there is precious little documentation for either sysusers.d or tmpfiles.d - I tried reading the systemd macros and the inline docs for the "correct" macros to use ... it appears that both %sysusers_create_compat and %tmpfiles_create are deprecated, and replaced by %sysusers_create_package and %tmpfiles_create_package.

I will add macros for both to %pre (as shown in the inline systemd macro documentation), and created and ghost-owned the three runtime directories.

I'm getting errors from scriptlets now, will investigate.

Ok, made some more changes, and sysusers.d now creates the users, and tmpfiles.d creates the folders correctly.

Updated files behind the same URLs.

[fedora-review-service-build]

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6586305
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2246730-ntpd-rs/fedora-rawhide-x86_64/06586305-ntpd-rs/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

LGTM - the remaining rpmlint warnings likely are something that need to be addressed in rpmlint itself

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (Apache-2.0 OR MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Thank you for the review!

The Pagure repository was created at https://src.fedoraproject.org/rpms/ntpd-rs

I updated the package to the latest version and built for rawhide:
https://bodhi.fedoraproject.org/updates/FEDORA-2024-bc0d670ef2