Bug 2246785 - Review Request: rust-nu-cmd-base - Foundation tools to build Nushell commands
Summary: Review Request: rust-nu-cmd-base - Foundation tools to build Nushell commands
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Davide Cavalca
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-10-28 22:07 UTC by Michel Lind
Modified: 2024-01-12 03:23 UTC (History)
2 users (show)

Fixed In Version: rust-nu-cmd-base-0.86.0-1.fc40
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-01-12 03:23:23 UTC
Type: ---
Embargoed:
davide: fedora-review+


Attachments (Terms of Use)

Description Michel Lind 2023-10-28 22:07:11 UTC
Spec URL: https://salimma.fedorapeople.org/rust-nu-cmd-base.spec
SRPM URL: https://salimma.fedorapeople.org/rust-nu-cmd-base-0.86.0-1.fc38.src.rpm

Description:
The foundation tools to build Nushell commands.

Fedora Account System Username: salimma

Comment 1 Michel Lind 2023-10-28 22:07:50 UTC
Built in COPR: https://copr.fedorainfracloud.org/coprs/salimma/nu-wip/build/6576857/

Comment 2 Fedora Review Service 2023-10-29 01:35:38 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6577381
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2246785-rust-nu-cmd-base/srpm-builds/06577381/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Davide Cavalca 2023-10-30 03:40:15 UTC
Taking this review

Comment 4 Davide Cavalca 2023-10-30 03:43:32 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED (with requests for changes).

Comment 5 Fedora Admin user for bugzilla script actions 2023-11-01 02:35:05 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-nu-cmd-base

Comment 6 Michel Lind 2024-01-12 03:23:23 UTC
Apparently I forgot to tag this review request

https://bodhi.fedoraproject.org/updates/?packages=rust-nu-cmd-base


Note You need to log in before you can comment on or make changes to this bug.