Bug 2246872 - Review Request: setup-tool - allows configuring repositories and dnf and setting up setups
Summary: Review Request: setup-tool - allows configuring repositories and dnf and sett...
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-Legal
TreeView+ depends on / blocked
 
Reported: 2023-10-29 21:09 UTC by e.ohlms@burningpho3nix.xyz
Modified: 2023-12-23 04:34 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:


Attachments (Terms of Use)
version with third party notice (3.00 KB, patch)
2023-10-31 20:47 UTC, e.ohlms@burningpho3nix.xyz
no flags Details | Diff

Description e.ohlms@burningpho3nix.xyz 2023-10-29 21:09:25 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/burningpho3nix/Setup-Tool/fedora-39-x86_64/06554928-setup-tool/setup-tool-starter.spec

SRPM URL: https://download.copr.fedorainfracloud.org/results/burningpho3nix/Setup-Tool/fedora-39-x86_64/06554928-setup-tool/setup-tool-1.4.103c-1.src.rpm

Description: This program is made to simplify setting up additions to Fedora, like for example some repositories and dnf settings.

Fedora Account System Username: burningpho3nix

Comment 1 Benson Muite 2023-10-30 02:30:03 UTC
Initial comments:
a) Can you reference the source:
https://github.com/Setup-Tooling/Setup-Tool-for-Fedora
See https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_tags
b) Probably do not want to hard code versions in:
https://github.com/Setup-Tooling/Setup-Tool-for-Fedora/blob/stable/cli/setup-tool-cli.c
c) use desktop-file-install
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_files
d) Add compiler flags:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_compiler_flags
e) The tool may hide that one is installing packages from outside the main Fedora repositories.
This may be undesirable.
f) Replace
%license %{_datadir}/licenses/setup-tool/LICENSE
%doc %{_datadir}/doc/setup-tool/README.md
with
%license LICENSE
%doc README.md
They will be put in the correct locations
g) Use 
cp -p
or
install -p -D755
or
install -p -D644
to preserve timestamps.  The install command allows setting of permissions.
h) Use SPDX license identifier either MPL-2.0
https://docs.fedoraproject.org/en-US/legal/allowed-licenses/

Comment 2 Neal Gompa 2023-10-30 11:57:47 UTC
I don't think this package is permissible in Fedora. Requesting legal review.

Comment 3 e.ohlms@burningpho3nix.xyz 2023-10-30 13:19:46 UTC
(In reply to Benson Muite from comment #1)
> Initial comments:
> a) Can you reference the source:
> https://github.com/Setup-Tooling/Setup-Tool-for-Fedora
> See
> https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/
> #_git_tags
> b) Probably do not want to hard code versions in:
> https://github.com/Setup-Tooling/Setup-Tool-for-Fedora/blob/stable/cli/setup-
> tool-cli.c
> c) use desktop-file-install
> https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_files
> d) Add compiler flags:
> https://docs.fedoraproject.org/en-US/packaging-guidelines/#_compiler_flags
> e) The tool may hide that one is installing packages from outside the main
> Fedora repositories.
> This may be undesirable.
> f) Replace
> %license %{_datadir}/licenses/setup-tool/LICENSE
> %doc %{_datadir}/doc/setup-tool/README.md
> with
> %license LICENSE
> %doc README.md
> They will be put in the correct locations
> g) Use 
> cp -p
> or
> install -p -D755
> or
> install -p -D644
> to preserve timestamps.  The install command allows setting of permissions.
> h) Use SPDX license identifier either MPL-2.0
> https://docs.fedoraproject.org/en-US/legal/allowed-licenses/

I have done all of that and now get this build error:

(command run) rpmbuild -ba /home/burningpho3nix/rpmbuild/SPECS/Normal/setup-tool-starter.spec

setting SOURCE_DATE_EPOCH=1698624000
Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.4FsOtt
+ umask 022
+ cd /home/burningpho3nix/rpmbuild/BUILD
+ cd /home/burningpho3nix/rpmbuild/BUILD
+ rm -rf setup-tool-1.4.103c
+ /usr/lib/rpm/rpmuncompress -x /home/burningpho3nix/rpmbuild/SOURCES/1.4.103c.tar.gz
error: File /home/burningpho3nix/rpmbuild/SOURCES/1.4.103c.tar.gz: No such file or directory
error: Bad exit status from /var/tmp/rpm-tmp.4FsOtt (%prep)

RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.4FsOtt (%prep)


The hard coded Fedora versions where, because otherwise it tried to download version: 000000.
I actively rewrite those code snippets when Fedora versions are removed from the list of versions supported by the program.


The use of the names "Fedora", "RHEL" and "CentOS Stream" on Github is so that people can see the OS that the version of the program is for.

Comment 4 Fedora Review Service 2023-10-30 15:20:38 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6581902
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2246872-setup-tool/fedora-rawhide-x86_64/06581902-setup-tool/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 e.ohlms@burningpho3nix.xyz 2023-10-31 20:46:00 UTC
(In reply to Benson Muite from comment #1)
> [...]
> e) The tool may hide that one is installing packages from outside the main
> Fedora repositories.
> This may be undesirable.
> [...]

The next beta release will address that.

Comment 6 e.ohlms@burningpho3nix.xyz 2023-10-31 20:47:16 UTC
Created attachment 1996431 [details]
version with third party notice

Comment 7 Benson Muite 2023-11-14 06:16:49 UTC
May consider having this in RPM fusion:
https://rpmfusion.org/Contributors

Comment 8 e.ohlms@burningpho3nix.xyz 2023-12-22 09:34:57 UTC
(In reply to Fedora Review Service from comment #4)
> Copr build:
> https://copr.fedorainfracloud.org/coprs/build/6581902
> (succeeded)
> 
> Review template:
> https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-
> review-2246872-setup-tool/fedora-rawhide-x86_64/06581902-setup-tool/fedora-
> review/review.txt
> 
> Please take a look if any issues were found.
> 
> ---
> This comment was created by the fedora-review-service
> https://github.com/FrostyX/fedora-review-service
> 
> If you want to trigger a new Copr build, add a comment containing new
> Spec and SRPM URLs or [fedora-review-service-build] string.

https://download.copr.fedorainfracloud.org/results/burningpho3nix/Setup-Tool/fedora-39-x86_64/06732008-setup-tool/setup-tool-1.5.3c-1.src.rpm
https://download.copr.fedorainfracloud.org/results/burningpho3nix/Setup-Tool/fedora-39-x86_64/06732009-setup-tool-cli/setup-tool-cli-1.3.2c-1.src.rpm

Comment 9 Fedora Review Service 2023-12-23 04:34:05 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6784931
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2246872-setup-tool/fedora-rawhide-x86_64/06784931-setup-tool-cli/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.


Note You need to log in before you can comment on or make changes to this bug.