Spec URL: https://download.copr.fedorainfracloud.org/results/burningpho3nix/Setup-Tool/fedora-39-x86_64/06554928-setup-tool/setup-tool-starter.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/burningpho3nix/Setup-Tool/fedora-39-x86_64/06554928-setup-tool/setup-tool-1.4.103c-1.src.rpm Description: This program is made to simplify setting up additions to Fedora, like for example some repositories and dnf settings. Fedora Account System Username: burningpho3nix
Initial comments: a) Can you reference the source: https://github.com/Setup-Tooling/Setup-Tool-for-Fedora See https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_tags b) Probably do not want to hard code versions in: https://github.com/Setup-Tooling/Setup-Tool-for-Fedora/blob/stable/cli/setup-tool-cli.c c) use desktop-file-install https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_files d) Add compiler flags: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_compiler_flags e) The tool may hide that one is installing packages from outside the main Fedora repositories. This may be undesirable. f) Replace %license %{_datadir}/licenses/setup-tool/LICENSE %doc %{_datadir}/doc/setup-tool/README.md with %license LICENSE %doc README.md They will be put in the correct locations g) Use cp -p or install -p -D755 or install -p -D644 to preserve timestamps. The install command allows setting of permissions. h) Use SPDX license identifier either MPL-2.0 https://docs.fedoraproject.org/en-US/legal/allowed-licenses/
I don't think this package is permissible in Fedora. Requesting legal review.
(In reply to Benson Muite from comment #1) > Initial comments: > a) Can you reference the source: > https://github.com/Setup-Tooling/Setup-Tool-for-Fedora > See > https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ > #_git_tags > b) Probably do not want to hard code versions in: > https://github.com/Setup-Tooling/Setup-Tool-for-Fedora/blob/stable/cli/setup- > tool-cli.c > c) use desktop-file-install > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_files > d) Add compiler flags: > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_compiler_flags > e) The tool may hide that one is installing packages from outside the main > Fedora repositories. > This may be undesirable. > f) Replace > %license %{_datadir}/licenses/setup-tool/LICENSE > %doc %{_datadir}/doc/setup-tool/README.md > with > %license LICENSE > %doc README.md > They will be put in the correct locations > g) Use > cp -p > or > install -p -D755 > or > install -p -D644 > to preserve timestamps. The install command allows setting of permissions. > h) Use SPDX license identifier either MPL-2.0 > https://docs.fedoraproject.org/en-US/legal/allowed-licenses/ I have done all of that and now get this build error: (command run) rpmbuild -ba /home/burningpho3nix/rpmbuild/SPECS/Normal/setup-tool-starter.spec setting SOURCE_DATE_EPOCH=1698624000 Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.4FsOtt + umask 022 + cd /home/burningpho3nix/rpmbuild/BUILD + cd /home/burningpho3nix/rpmbuild/BUILD + rm -rf setup-tool-1.4.103c + /usr/lib/rpm/rpmuncompress -x /home/burningpho3nix/rpmbuild/SOURCES/1.4.103c.tar.gz error: File /home/burningpho3nix/rpmbuild/SOURCES/1.4.103c.tar.gz: No such file or directory error: Bad exit status from /var/tmp/rpm-tmp.4FsOtt (%prep) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.4FsOtt (%prep) The hard coded Fedora versions where, because otherwise it tried to download version: 000000. I actively rewrite those code snippets when Fedora versions are removed from the list of versions supported by the program. The use of the names "Fedora", "RHEL" and "CentOS Stream" on Github is so that people can see the OS that the version of the program is for.
Copr build: https://copr.fedorainfracloud.org/coprs/build/6581902 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2246872-setup-tool/fedora-rawhide-x86_64/06581902-setup-tool/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
(In reply to Benson Muite from comment #1) > [...] > e) The tool may hide that one is installing packages from outside the main > Fedora repositories. > This may be undesirable. > [...] The next beta release will address that.
Created attachment 1996431 [details] version with third party notice
May consider having this in RPM fusion: https://rpmfusion.org/Contributors
(In reply to Fedora Review Service from comment #4) > Copr build: > https://copr.fedorainfracloud.org/coprs/build/6581902 > (succeeded) > > Review template: > https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora- > review-2246872-setup-tool/fedora-rawhide-x86_64/06581902-setup-tool/fedora- > review/review.txt > > Please take a look if any issues were found. > > --- > This comment was created by the fedora-review-service > https://github.com/FrostyX/fedora-review-service > > If you want to trigger a new Copr build, add a comment containing new > Spec and SRPM URLs or [fedora-review-service-build] string. https://download.copr.fedorainfracloud.org/results/burningpho3nix/Setup-Tool/fedora-39-x86_64/06732008-setup-tool/setup-tool-1.5.3c-1.src.rpm https://download.copr.fedorainfracloud.org/results/burningpho3nix/Setup-Tool/fedora-39-x86_64/06732009-setup-tool-cli/setup-tool-cli-1.3.2c-1.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/6784931 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2246872-setup-tool/fedora-rawhide-x86_64/06784931-setup-tool-cli/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
A lot has changed. Can we reconsider this? https://gitlab.com/setup-tooling-project Spec URL libstp: https://download.copr.fedorainfracloud.org/results/burningpho3nix/Setup-Tool/fedora-40-x86_64/08014485-libstp/libstp.spec Spec URL setup-tool: https://download.copr.fedorainfracloud.org/results/burningpho3nix/Setup-Tool/fedora-40-x86_64/08026158-setup-tool-beta/setup-tool-starter-beta.spec Spec URL setup-tool-cli: https://download.copr.fedorainfracloud.org/results/burningpho3nix/Setup-Tool/fedora-40-x86_64/08026159-setup-tool-cli-beta/setup-tool-cli-beta.spec Spec URL st-community-scripts: https://download.copr.fedorainfracloud.org/results/burningpho3nix/Setup-Tool/fedora-40-x86_64/08026134-st-community-scripts/st-community-scripts.spec SRPM URL libstp: https://download.copr.fedorainfracloud.org/results/burningpho3nix/Setup-Tool/fedora-40-x86_64/08014485-libstp/libstp-1.1.0-1.src.rpm SRPM URL setup-tool: https://download.copr.fedorainfracloud.org/results/burningpho3nix/Setup-Tool/fedora-40-x86_64/08026158-setup-tool-beta/setup-tool-beta-1.7.0-rc8.src.rpm SRPM URL setup-tool-cli: https://download.copr.fedorainfracloud.org/results/burningpho3nix/Setup-Tool/fedora-40-x86_64/08026159-setup-tool-cli-beta/setup-tool-cli-beta-1.5.0-rc8.src.rpm SRPM URL st-community-scripts: https://download.copr.fedorainfracloud.org/results/burningpho3nix/Setup-Tool/fedora-40-x86_64/08026134-st-community-scripts/st-community-scripts-1.0.1-1.src.rpm Fedora Account System Username: burningpho3nix
Created attachment 2047263 [details] The .spec file difference from Copr build 6784931 to 8027980
Copr build: https://copr.fedorainfracloud.org/coprs/build/8027980 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2246872-setup-tool/fedora-rawhide-x86_64/08027980-setup-tool-cli-beta/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience.
This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.