See also bz2246092 and https://github.com/mesonbuild/meson/issues/12401


I wonder if the vendored meson here could be unbundled... ? They appear to "simply" use a git submodule without custom changes in it.

> They appear to "simply" use a git submodule without custom changes in it.

Oh, the submodule goes to https://github.com/numpy/meson which actually is a fork.

Patching the vendored meson and through backporting relevant upstream/main commits it's currently stuck at:

1. missing <ctype.h> declaration, added: https://github.com/numpy/numpy/pull/25036
2. removed ‘_Py_HashDouble’, reported upstream: https://github.com/numpy/numpy/issues/25035

At this point, numpy builds (without tests) with:

https://copr-dist-git.fedorainfracloud.org/cgit/@python/python3.13/numpy.git/plain/don-t-use-the-removed-importlib.patch?id=7452c637ffcf4dbfb1b00bbf1bd3c83c11d1a540

However, there are still some test failures:



=================================== FAILURES ===================================
____________________ TestLowlevelAPIAccess.test_loop_access ____________________

self = <numpy.core.tests.test_ufunc.TestLowlevelAPIAccess object at 0x7f6f21955a60>

    @pytest.mark.skipif(not hasattr(ct, "pythonapi"),
            reason="`ctypes.pythonapi` required for capsule unpacking.")
    def test_loop_access(self):
        # This is a basic test for the full strided loop access
>       data_t = ct.ARRAY(ct.c_char_p, 2)

self       = <numpy.core.tests.test_ufunc.TestLowlevelAPIAccess object at 0x7f6f21955a60>

../../../../BUILDROOT/numpy-1.26.0-2.fc40.x86_64/usr/lib64/python3.13/site-packages/numpy/core/tests/test_ufunc.py:2926: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
/usr/lib64/python3.13/ctypes/__init__.py:318: in ARRAY
    warnings._deprecated("ctypes.ARRAY", remove=(3, 15))
        len        = 2
        typ        = <class 'ctypes.c_char_p'>
        warnings   = <module 'warnings' from '/usr/lib64/python3.13/warnings.py'>
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

name = 'ctypes.ARRAY'
message = '{name!r} is deprecated and slated for removal in Python {remove}'

    def _deprecated(name, message=_DEPRECATED_MSG, *, remove, _version=sys.version_info):
        """Warn that *name* is deprecated or should be removed.
    
        RuntimeError is raised if *remove* specifies a major/minor tuple older than
        the current Python version or the same version but past the alpha.
    
        The *message* argument is formatted with *name* and *remove* as a Python
        version tuple (e.g. (3, 11)).
    
        """
        remove_formatted = f"{remove[0]}.{remove[1]}"
        if (_version[:2] > remove) or (_version[:2] == remove and _version[3] != "alpha"):
            msg = f"{name!r} was slated for removal after Python {remove_formatted} alpha"
            raise RuntimeError(msg)
        else:
            msg = message.format(name=name, remove=remove_formatted)
>           warn(msg, DeprecationWarning, stacklevel=3)
E           DeprecationWarning: 'ctypes.ARRAY' is deprecated and slated for removal in Python 3.15

_version   = sys.version_info(major=3, minor=13, micro=0, releaselevel='alpha', serial=1)
message    = '{name!r} is deprecated and slated for removal in Python {remove}'
msg        = "'ctypes.ARRAY' is deprecated and slated for removal in Python 3.15"
name       = 'ctypes.ARRAY'
remove     = (3, 15)
remove_formatted = '3.15'

/usr/lib64/python3.13/warnings.py:529: DeprecationWarning
_____________ test_deprecate_help_indentation[old_func4-old_func4] _____________

old_func = <function old_func4 at 0x7f6f1f7177e0>
new_func = <function old_func4 at 0x7f6f1f717880>

    @pytest.mark.skipif(sys.flags.optimize == 2, reason="-OO discards docstrings")
    @pytest.mark.parametrize('old_func, new_func', [
        (old_func4, new_func4),
        (old_func5, new_func5),
        (old_func6, new_func6),
    ])
    def test_deprecate_help_indentation(old_func, new_func):
        _compare_docs(old_func, new_func)
        # Ensure we don't mess up the indentation
        for knd, func in (('old', old_func), ('new', new_func)):
            for li, line in enumerate(func.__doc__.split('\n')):
                if li == 0:
                    assert line.startswith('    ') or not line.startswith(' '), knd
                elif line:
>                   assert line.startswith('    '), knd
E                   AssertionError: old
E                   assert False
E                    +  where False = <built-in method startswith of str object at 0x7f6f1a84ae70>('    ')
E                    +    where <built-in method startswith of str object at 0x7f6f1a84ae70> = 'Further info.'.startswith

func       = <function old_func4 at 0x7f6f1f7177e0>
knd        = 'old'
li         = 2
line       = 'Further info.'
new_func   = <function old_func4 at 0x7f6f1f717880>
old_func   = <function old_func4 at 0x7f6f1f7177e0>

../../../../BUILDROOT/numpy-1.26.0-2.fc40.x86_64/usr/lib64/python3.13/site-packages/numpy/lib/tests/test_utils.py:104: AssertionError
_____________ test_deprecate_help_indentation[old_func5-old_func5] _____________

old_func = <function old_func5 at 0x7f6f1f717920>
new_func = <function old_func5 at 0x7f6f1f7179c0>

    @pytest.mark.skipif(sys.flags.optimize == 2, reason="-OO discards docstrings")
    @pytest.mark.parametrize('old_func, new_func', [
        (old_func4, new_func4),
        (old_func5, new_func5),
        (old_func6, new_func6),
    ])
    def test_deprecate_help_indentation(old_func, new_func):
        _compare_docs(old_func, new_func)
        # Ensure we don't mess up the indentation
        for knd, func in (('old', old_func), ('new', new_func)):
            for li, line in enumerate(func.__doc__.split('\n')):
                if li == 0:
                    assert line.startswith('    ') or not line.startswith(' '), knd
                elif line:
>                   assert line.startswith('    '), knd
E                   AssertionError: old
E                   assert False
E                    +  where False = <built-in method startswith of str object at 0x7f6ef7d27530>('    ')
E                    +    where <built-in method startswith of str object at 0x7f6ef7d27530> = 'Bizarre indentation.'.startswith

func       = <function old_func5 at 0x7f6f1f717920>
knd        = 'old'
li         = 2
line       = 'Bizarre indentation.'
new_func   = <function old_func5 at 0x7f6f1f7179c0>
old_func   = <function old_func5 at 0x7f6f1f717920>

../../../../BUILDROOT/numpy-1.26.0-2.fc40.x86_64/usr/lib64/python3.13/site-packages/numpy/lib/tests/test_utils.py:104: AssertionError
_____________ test_deprecate_help_indentation[old_func6-old_func6] _____________

old_func = <function old_func6 at 0x7f6f1f717a60>
new_func = <function old_func6 at 0x7f6f1f717b00>

    @pytest.mark.skipif(sys.flags.optimize == 2, reason="-OO discards docstrings")
    @pytest.mark.parametrize('old_func, new_func', [
        (old_func4, new_func4),
        (old_func5, new_func5),
        (old_func6, new_func6),
    ])
    def test_deprecate_help_indentation(old_func, new_func):
        _compare_docs(old_func, new_func)
        # Ensure we don't mess up the indentation
        for knd, func in (('old', old_func), ('new', new_func)):
            for li, line in enumerate(func.__doc__.split('\n')):
                if li == 0:
                    assert line.startswith('    ') or not line.startswith(' '), knd
                elif line:
>                   assert line.startswith('    '), knd
E                   AssertionError: old
E                   assert False
E                    +  where False = <built-in method startswith of str object at 0x7f6f1a840730>('    ')
E                    +    where <built-in method startswith of str object at 0x7f6f1a840730> = 'Also in PEP-257.'.startswith

func       = <function old_func6 at 0x7f6f1f717a60>
knd        = 'old'
li         = 1
line       = 'Also in PEP-257.'
new_func   = <function old_func6 at 0x7f6f1f717b00>
old_func   = <function old_func6 at 0x7f6f1f717a60>

../../../../BUILDROOT/numpy-1.26.0-2.fc40.x86_64/usr/lib64/python3.13/site-packages/numpy/lib/tests/test_utils.py:104: AssertionError
______________________ test_deprecate_preserve_whitespace ______________________

    @pytest.mark.skipif(sys.flags.optimize == 2, reason="-OO discards docstrings")
    def test_deprecate_preserve_whitespace():
>       assert_('\n        Bizarre' in new_func5.__doc__)
E       AssertionError


../../../../BUILDROOT/numpy-1.26.0-2.fc40.x86_64/usr/lib64/python3.13/site-packages/numpy/lib/tests/test_utils.py:116: AssertionError

-----------------------------------------------------

One of the failures is caused by DeprecationWarning: 'ctypes.ARRAY' is deprecated and slated for removal in Python 3.15 -- we should look if upstream has fixed this, but otherwise not treating DeprecationWarning as errors is a way to unblock this.


All other failures seem to be caused by docstring dedentation: https://github.com/python/cpython/issues/81283 -- we should look if upstream has fixed this and offer a fix ourselves if needed.

The tests that fail due to the docstring dedentation were removed in https://github.com/numpy/numpy/pull/24154

The tested function was deprecated and while doing that, the tests were removed entirely. I don't quite understand that approach, but that is what upstream did. We should probably just deselect the tests until we update to a newer version.

https://src.fedoraproject.org/rpms/numpy/pull-request/40 should do the trick

Thank you, merged and building.

No need to build anything, that's why I did not include a changelog entry. Sorry about not making that clear.

Oh well. No worries. :)